style: apply rubocop corrections

Author: gildesmarais

Makefile

@@ -32,13 +32,6 @@ test-domain:
 	fi
 	bundle exec rspec --example "$(DOMAIN)" spec/html2rss/configs_dynamic_spec.rb
 
-test-debug:
-	@if [ -z "$(CONFIG)" ]; then \
-		echo "Usage: make test-debug CONFIG=github.com/releases.yml"; \
-		exit 1; \
-	fi
-	DEBUG_CONFIG=$(CONFIG) bundle exec rspec spec/html2rss/configs_dynamic_spec.rb
-
 # Migration commands
 migrate-tests:
 	bin/migrate_to_dynamic_tests

bin/rspec_changed_configs

@@ -3,7 +3,7 @@
 
 changed_files = `git diff --name-only origin/master | grep 'lib/html2rss/configs/.*/.*.yml'`.split("\n")
 
-if changed_files.count.positive?
+if changed_files.any?
   # Use dynamic test file with environment variable to filter changed configs
   config_names = changed_files.map { |file| file.sub('lib/html2rss/configs/', '') }
 

spec/html2rss/configs_dynamic_spec.rb

@@ -14,23 +14,14 @@
   end
 
   config_files.each do |config_file|
-    relative_path = config_file.sub('lib/html2rss/configs/', '')
-    config_name = relative_path.tr('/', '_').gsub('.yml', '')
-    domain = relative_path.split('/').first
+    config_name = config_file.sub('lib/html2rss/configs/', '').tr('/', '_').gsub('.yml', '')
+    domain = config_file.sub('lib/html2rss/configs/', '').split('/').first
 
-    describe "#{relative_path} (#{config_name})", config: config_name, domain: domain do
-      it_behaves_like 'config.yml', relative_path
-
-      # Add debugging hook for specific configs
-      if ENV['DEBUG_CONFIG'] == relative_path
-        it 'debugs the config' do
-          puts "Debugging config: #{relative_path}"
-          puts "File path: #{config_file}"
-          puts "Config name: #{config_name}"
-          puts "Domain: #{domain}"
-          expect(relative_path).to be_a(String) # Add meaningful expectation
-        end
-      end
+    describe "#{config_file.sub('lib/html2rss/configs/', '')} (#{config_name})",
+             config: config_name,
+             domain: domain,
+             relative_path: config_file.sub('lib/html2rss/configs/', '') do
+      it_behaves_like 'config.yml', config_file.sub('lib/html2rss/configs/', '')
     end
   end
 end