fix(devx): pin prettier and harden config validation

Author: gildesmarais

.github/workflows/ruby.yml

@@ -19,6 +19,9 @@ jobs:
       - name: Install dependencies
         run: sudo apt-get install -yqq yamllint
 
+      - name: Install Node dependencies
+        run: npm ci --ignore-scripts --no-fund --no-audit
+
       - name: Set up Ruby
         uses: ruby/setup-ruby@v1
         with:

Makefile

@@ -3,7 +3,7 @@ default: lint validate test
 lint:
 	yamllint lib/html2rss/configs/ .github/
 	bundle exec rubocop -P -f quiet
-	npx prettier --check lib/**/*.yml .github/**/*.yml README.md
+	./node_modules/.bin/prettier --check lib/**/*.yml .github/**/*.yml README.md
 
 validate:
 	bundle exec ruby bin/validate_configs
@@ -53,4 +53,4 @@ restore-tests:
 
 lintfix:
 	bundle exec rubocop -a
-	npx prettier --write lib/**/*.yml .github/**/*.yml README.md
+	./node_modules/.bin/prettier --write lib/**/*.yml .github/**/*.yml README.md

bin/setup

@@ -7,7 +7,7 @@ bundle install
 
 echo
 echo "==> Installing Node dependencies (required for make lint)..."
-npm install --no-fund --no-audit --no-save prettier
+npm install --ignore-scripts --no-fund --no-audit
 
 echo
 echo "==> Checking system tools..."

bin/validate_configs

@@ -5,26 +5,30 @@ require 'bundler/setup'
 require 'html2rss'
 require 'yaml'
 
-unless Html2rss::Config.respond_to?(:validate)
-  warn 'Error: installed html2rss gem does not support Config.validate.'
-  warn 'Run: bundle update html2rss'
-  exit 1
-end
-
 files = Dir['lib/html2rss/configs/**/*.yml']
 failed = []
 
 files.each do |file|
-  config = YAML.safe_load_file(file, symbolize_names: true)
-  result = Html2rss::Config.validate(config)
+  begin
+    config = YAML.safe_load_file(file, symbolize_names: true)
+    result = Html2rss::Config.validate(config)
 
-  if result.success?
-    puts "ok   #{file}"
-  else
-    puts "FAIL #{file}"
-    result.errors.to_h.each do |key, messages|
-      Array(messages).each { |msg| warn "       #{key}: #{msg}" }
+    if result.success?
+      puts "ok   #{file}"
+    else
+      puts "FAIL #{file}"
+      result.errors.to_h.each do |key, messages|
+        Array(messages).each { |msg| warn "       #{key}: #{msg}" }
+      end
+      failed << file
     end
+  rescue Psych::Exception => e
+    puts "FAIL #{file}"
+    warn "       parse: #{e.message}"
+    failed << file
+  rescue StandardError => e
+    puts "FAIL #{file}"
+    warn "       validation: #{e.class}: #{e.message}"
     failed << file
   end
 end

package-lock.json

@@ -0,0 +1,6 @@
+{
+  "private": true,
+  "devDependencies": {
+    "prettier": "3.8.1"
+  }
+}