Merge remote-tracking branch 'upstream/main' into jackson-3-phase-2

Author: bitwiseman

.github/workflows/maven-build.yml

@@ -36,7 +36,7 @@ jobs:
       env:
         MAVEN_OPTS: ${{ env.JAVA_11_PLUS_MAVEN_OPTS }}
       run: mvn -B clean install -DskipTests --file pom.xml
-    - uses: actions/upload-artifact@v6
+    - uses: actions/upload-artifact@v7
       with:
         name: maven-target-directory
         path: target/
@@ -110,7 +110,7 @@ jobs:
       run: mvn -B clean install -D enable-ci --file pom.xml "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"
     - name: Save coverage data
       if: matrix.os == 'ubuntu' && matrix.java == '17'
-      uses: actions/upload-artifact@v6
+      uses: actions/upload-artifact@v7
       with:
         name: maven-test-target-directory
         path: target/
@@ -121,7 +121,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v6
-    - uses: actions/download-artifact@v7
+    - uses: actions/download-artifact@v8
       with:
         name: maven-test-target-directory
         path: target
@@ -139,7 +139,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v6
-    - uses: actions/download-artifact@v7
+    - uses: actions/download-artifact@v8
       with:
         name: maven-target-directory
         path: target

.github/workflows/publish_release_branch.yml

@@ -25,7 +25,7 @@ jobs:
           MAVEN_OPTS: ${{ env.JAVA_11_PLUS_MAVEN_OPTS }}
         run: mvn -B clean install site -D enable-ci --file pom.xml "-Dsurefire.argLine=--add-opens java.base/java.net=ALL-UNNAMED"
 
-      - uses: actions/upload-artifact@v6
+      - uses: actions/upload-artifact@v7
         with:
           name: maven-release-target-directory
           path: target/
@@ -78,7 +78,7 @@ jobs:
         run: |
           echo "version=$(mvn -B help:evaluate -Dexpression=project.version -q -DforceStdout)" >> $GITHUB_OUTPUT
 
-      - uses: actions/download-artifact@v7
+      - uses: actions/download-artifact@v8
         with:
           name: maven-release-target-directory
           path: target

pom.xml

@@ -337,7 +337,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-gpg-plugin</artifactId>
-          <version>3.2.7</version>
+          <version>3.2.8</version>
         </plugin>
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
@@ -365,7 +365,7 @@
         </plugin>
         <plugin>
           <artifactId>maven-surefire-plugin</artifactId>
-          <version>3.5.3</version>
+          <version>3.5.5</version>
           <configuration>
             <!-- SUREFIRE-1226 workaround -->
             <trimStackTrace>false</trimStackTrace>
@@ -379,7 +379,7 @@
         <plugin>
           <groupId>org.jacoco</groupId>
           <artifactId>jacoco-maven-plugin</artifactId>
-          <version>0.8.13</version>
+          <version>0.8.14</version>
           <configuration>
             <!-- no need to get data about external code. It dramatically reduces performance of JaCoCo for nothing -->
             <excludes>
@@ -636,7 +636,7 @@
           <dependency>
             <groupId>org.apache.bcel</groupId>
             <artifactId>bcel</artifactId>
-            <version>6.10.0</version>
+            <version>6.12.0</version>
           </dependency>
         </dependencies>
       </plugin>

src/main/java/org/kohsuke/github/GHEventInfo.java

@@ -1,6 +1,5 @@
 package org.kohsuke.github;
 
-import com.fasterxml.jackson.databind.node.ObjectNode;
 import com.infradna.tool.bridge_method_injector.WithBridgeMethods;
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 
@@ -84,8 +83,7 @@ static GHEvent transformTypeToGHEvent(String type) {
     private long id;
     private GHOrganization org;
 
-    // we don't want to expose Jackson dependency to the user. This needs databinding
-    private ObjectNode payload;
+    private Object payload;
 
     // these are all shallow objects
     private GHEventRepository repo;
@@ -174,7 +172,9 @@ public GHOrganization getOrganization() throws IOException {
      *             if payload cannot be parsed
      */
     public <T extends GHEventPayload> T getPayload(Class<T> type) throws IOException {
-        T v = GitHubClient.getMappingObjectReader(root()).forType(type).readValue(payload);
+        T v = GitHubClient.getMappingObjectReader(root())
+                .forType(type)
+                .readValue(GitHubClient.getMappingObjectWriter().writeValueAsString(payload));
         v.lateBind();
         return v;
     }

src/main/java/org/kohsuke/github/GHIssueSearchBuilder.java

@@ -57,6 +57,16 @@ public GHIssueSearchBuilder isClosed() {
         return q("is:closed");
     }
 
+    /**
+     * Filters results to only include issues (excludes pull requests).
+     *
+     * @return the gh issue search builder
+     */
+    public GHIssueSearchBuilder isIssue() {
+        terms.removeIf("is:pr"::equals);
+        return q("is:issue");
+    }
+
     /**
      * Is merged gh issue search builder.
      *
@@ -75,6 +85,16 @@ public GHIssueSearchBuilder isOpen() {
         return q("is:open");
     }
 
+    /**
+     * Filters results to only include pull requests (excludes issues).
+     *
+     * @return the gh issue search builder
+     */
+    public GHIssueSearchBuilder isPullRequest() {
+        terms.removeIf("is:issue"::equals);
+        return q("is:pr");
+    }
+
     /**
      * Mentions gh issue search builder.
      *
@@ -121,6 +141,19 @@ public GHIssueSearchBuilder q(String term) {
         return this;
     }
 
+    /**
+     * Filters results to a specific repository.
+     *
+     * @param owner
+     *            the repository owner
+     * @param name
+     *            the repository name
+     * @return the gh issue search builder
+     */
+    public GHIssueSearchBuilder repo(String owner, String name) {
+        return q("repo:" + owner + "/" + name);
+    }
+
     /**
      * Sort gh issue search builder.
      *

src/main/java/org/kohsuke/github/GHPullRequest.java

@@ -492,6 +492,16 @@ public boolean isMerged() throws IOException {
         return merged;
     }
 
+    /**
+     * Since a GHPullRequest is always a pull request, this method always returns true.
+     *
+     * @return true
+     */
+    @Override
+    public boolean isPullRequest() {
+        return true;
+    }
+
     /**
      * Retrieves all the commits associated to this pull request.
      *
@@ -520,7 +530,13 @@ public PagedIterable<GHPullRequestFileDetail> listFiles() {
     /**
      * Obtains all the review comments associated with this pull request.
      *
+     * <p>
+     * Unlike {@link GHPullRequestReview#listReviewComments()}, this method returns full
+     * {@link GHPullRequestReviewComment} objects including line-related fields such as
+     * {@link GHPullRequestReviewComment#getLine() line}, {@link GHPullRequestReviewComment#getSide() side}, etc.
+     *
      * @return the paged iterable
+     * @see GHPullRequestReview#listReviewComments()
      */
     public PagedIterable<GHPullRequestReviewComment> listReviewComments() {
         return root().createRequest()
@@ -539,6 +555,30 @@ public PagedIterable<GHPullRequestReview> listReviews() {
                 .toIterable(GHPullRequestReview[].class, item -> item.wrapUp(this));
     }
 
+    /**
+     * Converts a draft pull request to ready for review.
+     *
+     * @throws IOException
+     *             the io exception
+     * @throws IllegalStateException
+     *             if the pull request is not a draft
+     */
+    public void markReadyForReview() throws IOException {
+        if (!draft) {
+            throw new IllegalStateException("Pull request is not a draft");
+        }
+
+        StringBuilder inputBuilder = new StringBuilder();
+        addParameter(inputBuilder, "pullRequestId", this.getNodeId());
+
+        String graphqlBody = "mutation MarkReadyForReview { markPullRequestReadyForReview(input: {" + inputBuilder
+                + "}) { pullRequest { id } } }";
+
+        root().createGraphQLRequest(graphqlBody).sendGraphQL();
+
+        refresh();
+    }
+
     /**
      * Merge this pull request.
      *

src/main/java/org/kohsuke/github/GHPullRequestQueryBuilder.java

@@ -86,6 +86,18 @@ public PagedIterable<GHPullRequest> list() {
                 .toIterable(GHPullRequest[].class, item -> item.wrapUp(repo));
     }
 
+    /**
+     * Page size gh pull request query builder.
+     *
+     * @param pageSize
+     *            the page size
+     * @return the gh pull request query builder
+     */
+    public GHPullRequestQueryBuilder pageSize(int pageSize) {
+        req.with("per_page", pageSize);
+        return this;
+    }
+
     /**
      * Sort gh pull request query builder.
      *