Massive Optimisation of Custom Content

AKA: Past us massively overengineered the uninstall custom content handling and it was slow as all hell (affecting start up times too)

Testing with a Sonic '06 Randomiser Suite mod containing 6538 custom files, Version 3.42 would take two minutes to even start up if "Automatically Uninstall Mods" was active. A build with this change takes around 14 seconds to start up instead. As the same check is performed when installing mods with the option enabled, this also optimises the install time when a lot of custom files are present, as it no longer spends forever checking for them to remove first.

Author: Knuxfan24

Sonic-06-Mod-Manager/src/UnifyPatcher.cs

@@ -168,19 +168,18 @@ public static void UninstallMods() {
         /// </summary>
         public static void UninstallCustomFilesystem(ListView.ListViewItemCollection listViewItems) {
             if (Paths.CheckFileLegitimacy(Properties.Settings.Default.Path_GameExecutable)) { // If the game directory is empty/doesn't exist, ignore request
-                DirectoryInfo di = new DirectoryInfo(Path.GetDirectoryName(Properties.Settings.Default.Path_GameExecutable));
+                string[] gameFiles = Directory.GetFiles(Path.GetDirectoryName(Properties.Settings.Default.Path_GameExecutable), "*.*", SearchOption.AllDirectories); // Get the game files.
                 foreach (ListViewItem mod in listViewItems) {
                     string[] custom = INI.DeserialiseKey("Custom", mod.SubItems[6].Text).Split(','); // Deserialise 'Custom' key
 
                     if (custom[0] != string.Empty) { // Speeds things up a bit - ensures it's not checking a default null parameter
                         foreach (string file in custom) {
-                            foreach (var fi in di.EnumerateFiles($"*{file}", SearchOption.AllDirectories)) {
-                                try {
-                                    Console.WriteLine($"[{DateTime.Now:hh:mm:ss tt}] [Remove] {fi.FullName}");
-                                    File.Delete(fi.FullName); // If custom file is found, erase...
+                            foreach (string gameFile in gameFiles) {
+                                // Check if this file has the name of one of our custom files, if so, delete it.
+                                if (Path.GetFileName(gameFile) == file) {
+                                    Console.WriteLine($"[{DateTime.Now:hh:mm:ss tt}] [Remove] {gameFile}");
+                                    File.Delete(gameFile);
                                 }
-                                catch { }
-
                             }
                         }
                     }

Sonic-06-Mod-Manager/src/UnifyProgram.cs

@@ -40,7 +40,7 @@ namespace Unify
 {
     static class Program
     {
-        public static readonly string GlobalVersionNumber = $"Version 3.42";
+        public static readonly string GlobalVersionNumber = $"Version 3.43";
 
 #if !DEBUG
         public static readonly string VersionNumber = GlobalVersionNumber;