todo comment

iSapozhnik · iSapozhnik · commit 214d5eb56e26 · 2026-02-23T22:51:16.000+01:00
diff --git a/Sources/TextDiff/AppKit/DiffTokenLayouter.swift b/Sources/TextDiff/AppKit/DiffTokenLayouter.swift
@@ -181,6 +181,8 @@ enum DiffTokenLayouter {
         }
 
         lineText.append(text)
+        // TODO: Fix this later
+        // This now appends each token to lineText and calls size(withAttributes:) on the entire accumulated line every iteration, which makes layout cost grow quadratically with line length. On long unwrapped diffs (hundreds/thousands of tokens), this is a significant regression from the prior per-token measurement approach and can noticeably slow rendering even though the new performance tests only capture baselines and do not enforce thresholds.
         let combinedWidth = lineText.size(withAttributes: [.font: font]).width
         let textWidth = max(0, combinedWidth - lineTextWidth)
         return IncrementalTextWidth(

Original file line number	Diff line number	Diff line change
`@@ -181,6 +181,8 @@ enum DiffTokenLayouter {`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`lineText.append(text)`
	`184`	`+ // TODO: Fix this later`
	`185`	`+ // This now appends each token to lineText and calls size(withAttributes:) on the entire accumulated line every iteration, which makes layout cost grow quadratically with line length. On long unwrapped diffs (hundreds/thousands of tokens), this is a significant regression from the prior per-token measurement approach and can noticeably slow rendering even though the new performance tests only capture baselines and do not enforce thresholds.`
`184`	`186`	`let combinedWidth = lineText.size(withAttributes: [.font: font]).width`
`185`	`187`	`let textWidth = max(0, combinedWidth - lineTextWidth)`
`186`	`188`	`return IncrementalTextWidth(`