Avoid parsing the url twice (#402)

Author: bdraco

pyhap/hap_handler.py

@@ -145,6 +145,7 @@ def __init__(self, accessory_handler, client_address):
         self.command = None
         self.headers = None
         self.request_body = None
+        self.parsed_url = None
 
         self.response = None
 
@@ -199,6 +200,7 @@ def dispatch(self, request, body=None):
         self.command = request.method.decode()
         self.headers = {k.decode(): v.decode() for k, v in request.headers}
         self.request_body = body
+        self.parsed_url = urlparse(self.path)
         response = HAPResponse()
         self.response = response
 
@@ -210,7 +212,7 @@ def dispatch(self, request, body=None):
             self.headers,
         )
 
-        path = urlparse(self.path).path
+        path = self.parsed_url.path
         try:
             getattr(self, self.HANDLERS[self.command][path])()
         except UnprivilegedRequestException:
@@ -584,7 +586,7 @@ def handle_get_characteristics(self):
             raise UnprivilegedRequestException
 
         # Check that char exists and ...
-        params = parse_qs(urlparse(self.path).query)
+        params = parse_qs(self.parsed_url.query)
         response = self.accessory_handler.get_characteristics(
             params["id"][0].split(",")
         )

tests/test_hap_handler.py

@@ -3,6 +3,7 @@
 
 import json
 from unittest.mock import patch
+from urllib.parse import urlparse
 from uuid import UUID
 
 import pytest
@@ -697,6 +698,8 @@ def test_handle_get_characteristics_encrypted(driver):
     response = hap_handler.HAPResponse()
     handler.response = response
     handler.path = "/characteristics?id=1.11"
+    handler.parsed_url = urlparse(handler.path)
+
     handler.handle_get_characteristics()
 
     assert response.status_code == 200