Skip to content

Commit 1c1830b

Browse files
committed
proofread using llm
1 parent b445205 commit 1c1830b

19 files changed

Lines changed: 104 additions & 111 deletions

BugTracker.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ The INET project uses the GitHub issue tracker at **https://github.com/inet-fram
1111
</ul>
1212

1313
To report a bug or suggest an enhancement, log in with your GitHub username, and click *New issue*.
14-
Before submitting the bug report, please check that the problem was not reported before by someone else.
14+
Before submitting the bug report, please check if the problem has been reported by someone else.
1515

16-
If you haven't submitted a bug report before, please read the following pages carefully:
16+
If you have not submitted a bug report before, please read the following pages carefully:
1717

1818
* [Bug Writing Guidelines][2]{:target="_blank"}
1919
* [How to Report Bugs Effectively][3]{:target="_blank"}

CodingConventions.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ underMenu: Development
88

99
We know that indentation style is a personal matter but the codebase needs to look consistent, so please adhere to the conventions below.
1010

11-
* Bracket style: largely Stroustrup (Egyptian braces), except for classes, functions and the like where we prefer to place the opening braces on a new line
11+
* Bracket style: largely Stroustrup (Egyptian braces), except for classes, functions, and the like where we prefer to place the opening braces on a new line
1212
* 4-space indentation, NO TAB CHARACTERS, no trailing spaces
1313
* Do not align variable names in declaration blocks or multi-line function declarations. They are hard to maintain,
1414
and look awkward when very short and very long type names are mixed (e.g. `int` vs `const std::vector<SomeVeryLongTypeName>&`).
@@ -23,11 +23,11 @@ Choose *OMNeT++* as your code style. Pressing <kbd>Ctrl+Shift+F</kbd> will refor
2323

2424
## Naming Convention
2525

26-
Rules for variable names, function names, class names and other identifiers.
26+
Rules for variable names, function names, class names, and other identifiers.
2727

2828
* Use camel case
29-
* Variables and functions start with lower case
30-
* Types start with upper case
29+
* Variables and functions start with lowercase
30+
* Types start with uppercase
3131
* Constants and enum values are capitalized, with underscore as word separator
3232
* Don't abbreviate (too much)
3333
* Function names start with a verb
@@ -53,14 +53,14 @@ Consistent layout of class declarations throughout the project helps maintainers
5353

5454
## Functions
5555

56-
Misnamed and "kitchen-sink" functions are unfortunately quite common, and make the code hard to follow and reason about. Here's what you can do:
56+
Misnamed and "kitchen-sink" functions are unfortunately quite common and make the code hard to follow and reason about. Here's what you can do:
5757

5858
* Functions should be focused (i.e. do one thing only), and the name should reflect the purpose
5959
* Try to minimize side effects (modify class members and other non-local state as little as possible)
60-
* If you cannot find an accurate name for it, it is a strong indicator that the function should not exist in that form (e.g. needs to be split up, or the code organized in a different way)
60+
* If you cannot find an accurate name for it, it is a strong indicator that the function should not exist in that form (e.g. needs to be split up or the code organized in a different way)
6161
* If it has a side effect, the name should reflect that (e.g. *get* methods must not modify state)
6262
* Local variables should be declared close to their use, in the smallest scope possible (i.e. not C-style, at the top of the function)
63-
* Commenting: we prefer breaking up the function body into logical blocks, and adding a `//` comment above each block to document its intended *purpose*
63+
* Commenting: we prefer breaking up the function body into logical blocks and adding a `//` comment above each block to document its intended *purpose*
6464

6565
## C++ Style
6666

CommunityCoordinators.md

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,20 @@ We see two general directions:
1616

1717
## Improve Publicity
1818

19-
We'd like to have more, more up to date, and higher quality information to be available about the INET Framework.
19+
We'd like to have more, more up-to-date, and higher quality information available about the INET Framework.
2020

21-
* keep the INET web site up to date with new information
22-
* regularly collect progress information from INET developers/contributors, and disseminate it over various channels (mailing list, twitter, etc.)
23-
* collect and organize teaching materials
24-
* collect third-party tutorials, demos, related projects
21+
* Keep the INET website up-to-date with new information
22+
* Regularly collect progress information from INET developers/contributors and disseminate it over various channels (mailing list, Twitter, etc.)
23+
* Collect and organize teaching materials
24+
* Collect third-party tutorials, demos, and related projects
2525

2626
## Harness the Potential of the Community
2727

28-
We see a great potential in the user community of the INET Framework. We have several people in the community with extensive knowledge on specific areas of computer networks, and there are many who are willing to contribute to INET as an open-source project. We'd like to achieve that people who have the knowledge and willingness to contribute to INET have an easier job to find ways to connect.
28+
We see great potential in the user community of the INET Framework. We have several people in the community with extensive knowledge in specific areas of computer networks, and there are many who are willing to contribute to INET as an open-source project. We'd like to make it easier for people with knowledge and willingness to contribute to INET to find ways to connect.
2929

30-
* find [advisors](ComponentAdvisors.html) for various INET components
31-
* collect feedback on issues and priorities of the user community
32-
* look for potential contributions (third-party projects, papers with INET-based simulations, etc.)
33-
* collect and advertise masters thesis topics that could result in contributions
34-
* work out and operate a bounty system
35-
36-
Tools: email, web, social media
30+
* Find [advisors](ComponentAdvisors.html) for various INET components
31+
* Collect feedback on issues and priorities of the user community
32+
* Look for potential contributions (third-party projects, papers with INET-based simulations, etc.)
33+
* Collect and advertise master's thesis topics that could result in contributions
34+
* Work out and operate a bounty system
3735

ContribGettingStarted.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ INET is developed using the *git* revision control system, with the repository h
1010

1111
<div class="alert alert-info">
1212
{% capture tmp %}
13-
**New to git?** Read about it on its [web site](http://git-scm.com){:target="_blank"},
13+
**New to git?** Read about it on its [website](http://git-scm.com){:target="_blank"},
1414
from the [GitHub help](https://help.github.com/articles/good-resources-for-learning-git-and-github/){:target="_blank"},
1515
or [try it hands-on in a terminal](http://try.github.com/){:target="_blank"}.
1616
{% endcapture %} {{ tmp | markdownify }}
@@ -21,22 +21,21 @@ We recommend the following workflow:
2121
1. Create an account on GitHub, and fork the INET project to create your
2222
own version. Clone the new repository to your computer.
2323

24-
2. Create a new topic branch for your changes, by branching the `master` (stable)
25-
branch.
24+
2. Create a new topic branch for your changes by branching the `master` (stable) branch.
2625

2726
<div class="alert alert-warning">
2827
<b>Note:</b> It is NOT safe to start off from an existing topic branch.
2928
Topic branches should be considered a private playing field of the person
30-
who created them, and may be deleted, rebased, or their history rewritten
29+
who created them and may be deleted, rebased, or have their history rewritten
3130
at any time. If a topic (or attic) branch looks interesting to you, contact
32-
the person who works in that branch -- don't assume anything without asking.
31+
the person who works in that branch don't assume anything without asking.
3332
</div>
3433

3534
3. Commit your changes into your topic branch.
3635

37-
* We recommend that you pull from the INET repository from time to time,
36+
* We recommend that you pull from the INET repository from time to time
3837
and rebase your topic branch to the tip of the `master` branch.
39-
* Try to keep to the coding conventions of the INET Framework. If you implement
38+
* Try to adhere to the coding conventions of the INET Framework. If you implement
4039
a new component, you can take inspiration from existing parts of the framework.
4140
* If you have questions or something to discuss, don't hesitate to post to the mailing list.
4241

ContributionIdeas.md

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,24 +4,23 @@ title: Contribution Ideas
44
underMenu: Contributing
55
---
66

7-
Let us give you some hints what you can work on. Further ideas are also welcome.
7+
Let us give you some hints on what you can work on. Further ideas are also welcome.
88

99
### Code
1010

11-
If you are interested, please contact us so we can discuss the details,
12-
and avoid possible duplication of work.
11+
If you are interested, please contact us so we can discuss the details and avoid possible duplication of work.
1312

1413
* Improve IPv6 support
1514
* Refine MPLS and RSVP-TE
1615
* Revise HttpTools
17-
* SIP
18-
* TLS
16+
* Work on SIP
17+
* Work on TLS
1918
* ...
2019

2120
### Other
2221

23-
* A Tictoc-like tutorial for INET (or several tutorials, specialized for different kinds of networks)
24-
* Tutorial or demo videos (preferably with narration)
22+
* Create a Tictoc-like tutorial for INET (or several tutorials specialized for different kinds of networks)
23+
* Create tutorial or demo videos (preferably with narration)
2524
* Put together well-thought-out example simulations
2625
* ...
2726

DocumentationGuidelines.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,25 +8,25 @@ We maintain documentation in the following forms:
88

99
* **INET Framework User's Guide** is meant to provide information for users who want to assemble new models from pre-existing components. It provides an overview of the components and architecture of the framework.
1010
* **INET Framework Developer's Guide** is meant to provide information for the developers who intend to extend INET with new components, written in C++.
11-
* **INET Reference**, built from NED and C++ source, provides cross-linked, browsable reference information about the modules and classes of the implementation
11+
* **INET Reference**, built from NED and C++ source, provides cross-linked, browsable reference information about the modules and classes of the implementation.
1212

1313
The following auxiliary files are managed by the core INET maintainers:
1414

15-
* **ChangeLogs**. Every source folder contains a `ChangeLog` file in a fixed format. ChangeLogs exist so that users can get a high level overview of the history of that component. It is usually derived from the git log by heavy editing for conciseness and clarity, e.g. by combining a series of related commit messages into a single change summary. (The git log is often too detailed and contains too much "noise" for end-user consumption.)
16-
* **WHATSNEW** (in the project root directory) is updated before each release, and contains a summary of changes in the whole framework.
15+
* **ChangeLogs**. Every source folder contains a `ChangeLog` file in a fixed format. ChangeLogs exist so that users can get a high-level overview of the history of that component. It is usually derived from the git log by heavy editing for conciseness and clarity, e.g. by combining a series of related commit messages into a single change summary. (The git log is often too detailed and contains too much "noise" for end-user consumption.)
16+
* **WHATSNEW** (in the project root directory) is updated before each release and contains a summary of changes in the whole framework.
1717
* **AUTHORS** (in the project root directory) records the names of those who contributed to the project. The [Contributors](/Contributors.html) page should always contain a mirror of this file.
1818

1919
## INET User's Guide and Developer's Guide
2020

2121
Technically:
2222

2323
* Sources are in the repository under [doc/src/users-guide][2] and [doc/src/developers-guide][3], in RestructuredText.
24-
* PDF and/or HTML are built by the release manager for each release
24+
* PDF and/or HTML are built by the release manager for each release.
2525

2626
Content and level of detail:
2727

28-
* The purpose of the User's Guide is to provide an overview of INET, and provide high-level information about every implemented protocol model or component, potentially including practical advice on how to use them or combine them with other models.
29-
* The purpose of the Developer's Guide is to help users and contributors who want to understand the internal architechure and mechanisms of INET, and wish to extend it with new components, written in C++.
28+
* The purpose of the User's Guide is to provide an overview of INET and provide high-level information about every implemented protocol model or component, potentially including practical advice on how to use them or combine them with other models.
29+
* The purpose of the Developer's Guide is to help users and contributors who want to understand the internal architecture and mechanisms of INET and wish to extend it with new components, written in C++.
3030
* Must not duplicate information in protocol standards, in the INET Reference, etc.
3131

3232
If you wish to contribute, please check the **Authors Guide** chapters in both documents to see what kind of content is expected before writing anything.
@@ -39,7 +39,7 @@ NED documentation:
3939

4040
* We use explicit hyperlinks, i.e. the tilde notation is necessary to create a hyperlink to other modules. Examples: `the ~TCP module` (hyperlinks the TCP module), but: `the TCP protocol` (no hyperlink).
4141
* NED comments document the external interface: purpose, standards compliance, parametrization, gates, etc.
42-
* Provide a reference to the protocol specification, and also describe what parts of the specification are implemented and what parts are missing.
42+
* Provide a reference to the protocol specification and also describe what parts of the specification are implemented and what parts are missing.
4343

4444
C++ documentation:
4545

Extensions.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ There are several INET-based model frameworks, maintained by independent researc
1010

1111
* [Veins](http://veins.car2x.org/){:target="_blank"} is an open source Inter-Vehicular Communication (IVC) simulation framework composed of an event-based network simulator and a road traffic microsimulation model.
1212

13-
* [SimuLTE](http://github.com/inet-framework/simulte){:target="_blank"} is LTE user plane simulation model, with eNodeB and UE models.
13+
* [SimuLTE](http://github.com/inet-framework/simulte){:target="_blank"} is an LTE user plane simulation model, with eNodeB and UE models.
1414

15-
* [INETMANET](http://github.com/aarizaq/inetmanet-2.0){:target="_blank"} is fork of INET with experimental features related to mobile and ad-hoc networks.
15+
* [INETMANET](http://github.com/aarizaq/inetmanet-2.0){:target="_blank"} is a fork of INET with experimental features related to mobile and ad-hoc networks.
1616

17-
* [MiXiM](https://github.com/omnetpp/mixim){:target="_blank"} is not an INET extension, but an independent OMNeT++ modeling framework that focuses on the wireless physical, data link and networ layers. MiXiM can be used together with INET. Newer versions of INET (from 2.99.0 up) have the features of MiXiM, and much of the MiXiM code integrated.
17+
* [MiXiM](https://github.com/omnetpp/mixim){:target="_blank"} is not an INET extension, but an independent OMNeT++ modeling framework that focuses on the wireless physical, data link and network layers. MiXiM can be used together with INET. Newer versions of INET (from 2.99.0 up) have the features of MiXiM, and much of the MiXiM code integrated.
1818

1919
* The [Vehicular Networks and Distributed Control Systems](http://vehicular.omnetpp.org){:target="_blank"} page lists extensions related to the automotive industry.
2020

GettingStarted.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,14 @@ Here are some things you can do after having installed INET successfully.
88

99
### Try Some Example Simulations
1010

11-
Find the `inet` project in the IDE workspace, and explore it.
12-
Sources of protocol implementations and other components are in the `src/` folder.
11+
Find the `inet` project in the IDE workspace and explore it.
12+
The sources of protocol implementations and other components are in the `src/` folder.
1313
The `examples/` folder contains several example simulation models, that is,
1414
networks assembled from components under `src/`.
1515

16-
You can launch an example simulation by selecting its folder, and clicking *Run*
16+
You can launch an example simulation by selecting its folder and clicking *Run*
1717
on the toolbar. The simulation will execute as a GUI application, letting you
18-
explore, run, pause, and single-step the simulation model. Simulation results
18+
explore, run, pause, and single-step the simulation model. The simulation results
1919
will be placed into the `results/` subfolder; you can view them by
2020
double-clicking the created `vec` or `sca` files.
2121

@@ -26,14 +26,14 @@ pages, each about 5-10 minutes to read, are automatically opened in the IDE
2626
when you first start it. You can also access them later from the *Help* menu
2727
(*Help Contents -> OMNeT++ Documentation -> Getting Started*).
2828

29-
* **OMNeT++ at a Glance**: explains the purpose of various files: `ini`, `ned`, `msg` and so on.
29+
* **OMNeT++ at a Glance**: explains the purpose of various files: `ini`, `ned`, `msg`, and so on.
3030

3131
* **Getting Started with the Simulation IDE**: an illustrated guide to performing basic tasks in the IDE.
3232

3333
Then, we strongly recommend that you go through the basic tutorial that comes with OMNeT++.
3434
It will take more than a few minutes, but it's the quickest way to get you going.
3535

36-
* **Tictoc tutorial**. It consists of steps that start from a very simple simulation model
36+
* **Tictoc tutorial**: It consists of steps that start from a very simple simulation model
3737
and progressively makes it more complex, introducing you to new functionality along the way.
3838

3939
### Follow the INET Tutorials
@@ -42,18 +42,18 @@ Follow the tutorials that come with the INET Framework.
4242

4343
* [INET Tutorials](https://inet.omnetpp.org/docs/tutorials)
4444

45-
Study the showcases that higlight how to use specific features in INET.
45+
Study the showcases that highlight how to use specific features in INET.
4646

4747
* [INET Showcases](https://inet.omnetpp.org/docs/showcases)
4848

4949
### Modify Simulations or Create New Ones
5050

5151
Armed with knowledge gained from experience in the previous steps, you should be
52-
able to modify the example simulations, or create simple new ones.
52+
able to modify the example simulations or create simple new ones.
5353

5454
### Learn More
5555

56-
For more in-depth knowledge, e.g. to be able to understand and modify
56+
For more in-depth knowledge, e.g., to be able to understand and modify
5757
the components INET provides, you need to study the documentation.
5858

5959
* [OMNeT++ User Manual](https://omnetpp.org/doc/omnetpp/manual)

0 commit comments

Comments
 (0)