fix: Add hidden-attribute to field-blocks

Author: jissereitsma

Form/Field/Field.php

@@ -4,6 +4,7 @@
 namespace Loki\AdminComponents\Form\Field;
 
 use Loki\AdminComponents\Form\Field\FieldType\Editor;
+use Loki\AdminComponents\Form\Field\FieldType\Input;
 use Magento\Framework\DataObject;
 use Magento\Framework\View\Element\AbstractBlock;
 use RuntimeException;
@@ -84,6 +85,10 @@ public function getFieldAttributes(): array
             $fieldAttributes['required'] = null;
         }
 
+        if ($this->isHidden() && $this->getFieldType() instanceof Input) {
+            $fieldAttributes['type'] = 'hidden';
+        }
+
         return $fieldAttributes;
     }
 
@@ -107,4 +112,14 @@ public function isVisible(): bool
 
         return true;
     }
+
+    public function isHidden(): bool
+    {
+        $hidden = $this->getData('hidden');
+        if (is_bool($hidden)) {
+            return $hidden;
+        }
+
+        return false;
+    }
 }

view/adminhtml/templates/form/field.phtml

@@ -34,13 +34,20 @@ if (false === $field->isVisible()) {
     return;
 }
 
+$cssClass[] = 'admin__field';
+if ($field->isHidden()) {
+    $cssClass[] = 'hidden';
+}
+
 $depends = $field->getDepends();
 $dependStatement = '';
 if (!empty($depends)) {
     $dependStatement = 'x-show="item.'.$depends['propertyName'] . " == '".$depends['propertyValue']."'\"";
 }
+
+$cssClass = implode(' ', $cssClass);
 ?>
-<div class="admin__field" <?= $escaper->escapeHtml($dependStatement) ?>>
+<div class="<?= $cssClass ?>" <?= $escaper->escapeHtml($dependStatement) ?>>
     <div class="admin__field-label">
         <label for="<?= $escaper->escapeHtml($field->getCode()) ?>">
             <span><?= $escaper->escapeHtml($field->getLabel()) ?></span>

view/adminhtml/templates/form/field_type/input.phtml

@@ -1,14 +1,13 @@
 <?php
 declare(strict_types=1);
 
-/** @version 0.5.1 */
-
 use Magento\Framework\Escaper;
 use Magento\Framework\View\Element\Template;
 use Loki\AdminComponents\Form\Field\Field;
 use Loki\AdminComponents\Form\Field\FieldType\Input;
 use Loki\Components\Util\Block\TemplateRenderer;
 
+/** @version 0.5.1 */
 /** @var Escaper $escaper */
 /** @var Template $block */
 /** @var Field $field */