Default unknown field types to "input"

Author: jissereitsma

Form/Field/Field.php

@@ -83,6 +83,11 @@ public function getSortOrder(): int
 
     public function isVisible(): bool
     {
-        return (bool)$this->getData('visible');
+        $visible = $this->getData('visible');
+        if (is_bool($visible)) {
+            return $visible;
+        }
+
+        return true;
     }
 }

Form/FieldResolver.php

@@ -37,8 +37,7 @@ public function resolve(FormRepository $formRepository, array $fieldDefinitions)
             $code = $tableColumn['COLUMN_NAME'];
 
             if (empty($fieldType)) {
-                // @todo: echo 'Unknown field type: '.$tableColumn['DATA_TYPE'];
-                continue;
+                $fieldType = 'input';
             }
 
             $block = $this->layout->createBlock(Template::class);
@@ -57,7 +56,7 @@ public function resolve(FormRepository $formRepository, array $fieldDefinitions)
                 $fieldData = array_merge($fieldData, $fieldDefinition);
             }
 
-            $fields[$code.$fieldData['sort_order']] = $this->fieldFactory->create(
+            $fields[$code] = $this->fieldFactory->create(
                 $block,
                 $fieldData,
             );