Merge pull request LokiExtensions#18 from LokiExtensions/bug/javascript-columns-array

JavaScript TypeError: columns initialized as object instead of array

Author: jissereitsma

view/adminhtml/templates/script/component-partial/columns-selector-component-partial.phtml

@@ -12,9 +12,11 @@ use Magento\Framework\View\Element\Template;
         activeColumns: null,
         initActiveColumns() {
             this.activeColumns = new Set();
-            this.columns.forEach(column => {
-                this.activeColumns.add(column.code);
-            })
+            if (Array.isArray(this.columns)) {
+                this.columns.forEach(column => {
+                    this.activeColumns.add(column.code);
+                })
+            }
         },
         isColumnActive() {
             const columnName = this.$el.getAttribute('data-column');

view/adminhtml/templates/script/component-type/grid-component-type.phtml

@@ -17,7 +17,7 @@ use Magento\Framework\View\Element\Template;
         ...LokiAdminFiltersComponentPartial,
         ...LokiAdminMassActionsComponentPartial,
         ...LokiComponentType,
-        columns: {},
+        columns: [],
         columnPositions: {},
         showOtherActions: false,
         gridFilters: {},