Skip to content

Commit 44ca7e8

Browse files
committed
Remove unused dev dependencies: php-http/httplug, symfony/http-client
Neither package was imported or used anywhere in source or tests. symfony/http-client was only implicitly needed to make the auto-discovery test pass; updated that test to instead verify the expected LogicException when no PSR-18 client is installed. https://claude.ai/code/session_017km7GVfNGXQe2UGceb34hf
1 parent 422923a commit 44ca7e8

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

composer.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,8 @@
1717
"require-dev": {
1818
"nyholm/psr7": "^1.2",
1919
"php-http/discovery": "^1.7",
20-
"php-http/httplug": "^2.0",
2120
"php-http/mock-client": "^1.3",
22-
"phpunit/phpunit": "^8.5",
23-
"symfony/http-client": "^5.0"
21+
"phpunit/phpunit": "^8.5"
2422
},
2523
"autoload": {
2624
"psr-4": {

tests/IpdataTest.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,11 @@ public function testCustomBaseUrl()
184184
$this->assertEquals('eu-api.ipdata.co', $request->getUri()->getHost());
185185
}
186186

187-
public function testConstructWithDiscovery()
187+
public function testConstructWithDiscoveryThrowsWhenNoClientAvailable()
188188
{
189-
$ipdata = new Ipdata('secret_key');
190-
$this->assertInstanceOf(Ipdata::class, $ipdata);
189+
$this->expectException(\LogicException::class);
190+
$this->expectExceptionMessage('Could not find any installed HTTP clients');
191+
new Ipdata('secret_key');
191192
}
192193

193194
private function createIpdata(ClientInterface $httpClient): Ipdata

0 commit comments

Comments
 (0)