Changed order of constructor arguments (#2)

* changed order of constructor parameters

* updated comment

Author: Nyholm

README.md

@@ -24,7 +24,7 @@ use Nyholm\Psr7\Factory\Psr17Factory;
 
 $httpClient = new Psr18Client();
 $psr17Factory = new Psr17Factory();
-$ipdata = new Ipdata($httpClient, 'my_api_key', $psr17Factory);
+$ipdata = new Ipdata('my_api_key', $httpClient, $psr17Factory);
 ```
 
 ## How to use

src/Ipdata.php

@@ -37,12 +37,12 @@ class Ipdata
     private $requestFactory;
 
     /**
-     * Get an instance of the API client. Give it PSR-18 client, an API key and a PSR-17 request factory.
+     * Get an instance of the API client. Give it an API key, a PSR-18 client and a PSR-17 request factory.
      *
      * @param ClientInterface|null         $httpClient     if null, we will try to use php-http/discovery to find an installed client
      * @param RequestFactoryInterface|null $requestFactory if null, we will try to use php-http/discovery to find an installed factory
      */
-    public function __construct(ClientInterface $httpClient = null, ?string $apiKey = null, RequestFactoryInterface $requestFactory = null)
+    public function __construct(string $apiKey, ClientInterface $httpClient = null, RequestFactoryInterface $requestFactory = null)
     {
         if (null === $httpClient) {
             if (!class_exists(Psr18ClientDiscovery::class)) {

tests/IpdataTest.php

@@ -137,13 +137,13 @@ public function testParseInvalidJsonResponse()
 
     public function testConstructWithDiscovery()
     {
-        $ipdata = new Ipdata(null, 'secret_key');
+        $ipdata = new Ipdata('secret_key');
         $this->assertInstanceOf(Ipdata::class, $ipdata);
     }
 
     private function createIpdata(ClientInterface $httpClient): Ipdata
     {
-        return new Ipdata($httpClient, 'secret_key', new Psr17Factory());
+        return new Ipdata('secret_key', $httpClient, new Psr17Factory());
     }
 
     private function createResponse(array $data = [], int $statusCode = 200): ResponseInterface