Bump golangci/golangci-lint-action from 6 to 7 (#431)

* Bump golangci/golangci-lint-action from 6 to 7

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 6 to 7.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v6...v7)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update golangci-lint configuration and fix linting issues

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Andreas Fritzler <andreas.fritzler@sap.com>

Author: dependabot[bot]

.github/workflows/lint.yml

@@ -15,6 +15,6 @@ jobs:
         with:
           go-version-file: 'go.mod'
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.64
+          version: v2.0

.golangci.yml

@@ -1,61 +1,66 @@
+version: "2"
 run:
-  timeout: 10m
   allow-parallel-runners: true
-
-issues:
-  # don't skip warning about doc comments
-  # don't exclude the default set of lint
-  exclude-use-default: false
-  # restore some of the defaults
-  # (fill in the rest as needed)
-  exclude-rules:
-    - path: "clientutils/*"
-      linters:
-        - lll
-    - path: "envtestutils/*"
-      linters:
-        - lll
-    - path: "unstructuredutils/*"
-      linters:
-        - lll
-    - path: "metautils/*"
-      linters:
-        - lll
-    - path: "kustomizeutils/*"
-      linters:
-        - lll
-    - path: "configutils/*"
-      linters:
-        - lll
-    - path: "conditionutils/*"
-      linters:
-        - lll
-    - path: "testutils/*"
-      linters:
-        - lll
-    - path: "cmdutils/*"
-      linters:
-        - dupl
 linters:
-  disable-all: true
+  default: none
   enable:
     - copyloopvar
     - dupl
     - errcheck
+    - ginkgolinter
     - goconst
     - gocyclo
-    - gofmt
-    - goimports
-    - gosimple
     - govet
     - ineffassign
-    - ginkgolinter
     - lll
     - misspell
     - nakedret
     - prealloc
     - staticcheck
-    - typecheck
     - unconvert
     - unparam
-    - unused
+    - unused
+  exclusions:
+    generated: lax
+    rules:
+      - linters:
+          - lll
+        path: clientutils/*
+      - linters:
+          - lll
+        path: envtestutils/*
+      - linters:
+          - lll
+        path: unstructuredutils/*
+      - linters:
+          - lll
+        path: metautils/*
+      - linters:
+          - lll
+        path: kustomizeutils/*
+      - linters:
+          - lll
+        path: configutils/*
+      - linters:
+          - lll
+        path: conditionutils/*
+      - linters:
+          - lll
+        path: testutils/*
+      - linters:
+          - dupl
+        path: cmdutils/*
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -75,7 +75,7 @@ GOLANGCILINT ?= $(LOCALBIN)/golangci-lint
 ADDLICENSE_VERSION ?= v1.1.1
 GOIMPORTS_VERSION ?= v0.31.0
 MOCKGEN_VERSION ?= v0.5.0
-GOLANGCILINT_VERSION ?= v1.64
+GOLANGCILINT_VERSION ?= v2.0
 
 .PHONY: addlicense
 addlicense: $(ADDLICENSE) ## Download addlicense locally if necessary.
@@ -95,4 +95,4 @@ $(MOCKGEN): $(LOCALBIN)
 .PHONY: goimports
 golangci-lint: $(GOLANGCILINT) ## Download golangci-lint locally if necessary.
 $(GOLANGCILINT): $(LOCALBIN)
-	test -s $(LOCALBIN)/golangci-lint || GOBIN=$(LOCALBIN) go install github.com/golangci/golangci-lint/cmd/golangci-lint@$(GOLANGCILINT_VERSION)
+	test -s $(LOCALBIN)/golangci-lint || GOBIN=$(LOCALBIN) go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCILINT_VERSION)

clientutils/clientutils.go

@@ -467,7 +467,7 @@ func setObject(dst, src client.Object) error {
 // IsOlderThan returns a function that determines whether an object is older than another.
 func IsOlderThan(obj client.Object) func(other client.Object) (bool, error) {
 	return func(other client.Object) (bool, error) {
-		return obj.GetCreationTimestamp().Time.After(other.GetCreationTimestamp().Time), nil
+		return obj.GetCreationTimestamp().After(other.GetCreationTimestamp().Time), nil
 	}
 }
 

metautils/metautils_test.go

@@ -31,7 +31,7 @@ type BadList struct {
 
 func (b *BadList) DeepCopyObject() runtime.Object {
 	return &BadList{
-		*b.ListMeta.DeepCopy(),
+		*b.DeepCopy(),
 		b.TypeMeta,
 	}
 }