getTabIdentifiers method implementation for W3C client

Author: itnelo

README.md

@@ -72,6 +72,7 @@ $socketConnector = new SocketConnector(
     ],
 );
 $browser = new Browser($loop, $socketConnector);
+$browser = $browser->withRejectErrorResponse(false);
 
 $hubClient = new W3CClient(
     $browser,

src/Client/W3CClient.php

@@ -62,7 +62,9 @@ class W3CClient implements ClientInterface
      *
      * ```
      * $loop = \React\EventLoop\Factory::create();
+     *
      * $browser = new \React\Http\Browser($loop);
+     * $browser = $browser->withRejectErrorResponse(false);
      *
      * $hubClient = new \Itnelo\React\WebDriver\Client\W3CClient(
      *     $browser,
@@ -149,8 +151,8 @@ function (ResponseInterface $response) use ($sessionOpeningDeferred) {
                     preg_match('/sessionid[":\s]+([a-z\d]{32})/Ui', $responseBody, $matches);
 
                     if (!isset($matches[1])) {
-                        // todo: locate an error message or set it as "undefined error".
-                        throw new RuntimeException('Unable to locate session identifier in the response.');
+                        // todo: locate an error message or set it as "undefined error"
+                        throw new RuntimeException('Unable to locate a session identifier in the response.');
                     }
 
                     $sessionIdentifier = $matches[1];
@@ -192,9 +194,54 @@ public function removeSession(string $sessionIdentifier): PromiseInterface
      */
     public function getTabIdentifiers(string $sessionIdentifier): PromiseInterface
     {
-        // TODO: Implement getTabIdentifiers() method.
+        $tabLookupDeferred = new Deferred();
 
-        return reject(new RuntimeException('Not implemented.'));
+        $requestUri = sprintf(
+            'http://%s:%d/wd/hub/session/%s/window/handles',
+            $this->_options['server']['host'],
+            $this->_options['server']['port'],
+            $sessionIdentifier
+        );
+
+        $requestHeaders = [
+            'Content-Type' => 'application/json; charset=UTF-8',
+        ];
+
+        $responsePromise = $this->httpClient->get($requestUri, $requestHeaders);
+
+        $responsePromise->then(
+            function (ResponseInterface $response) use ($tabLookupDeferred) {
+                try {
+                    $responseBody     = (string) $response->getBody();
+                    $bodyDeserialized = json_decode($responseBody, true);
+
+                    if (!array_key_exists('value', $bodyDeserialized) || !is_array($bodyDeserialized['value'])) {
+                        // todo: locate an error message or set it as "undefined error"
+                        throw new RuntimeException('Unable to locate tab identifiers in the response.');
+                    }
+
+                    $tabIdentifiers = $bodyDeserialized['value'];
+                    $tabLookupDeferred->resolve($tabIdentifiers);
+                } catch (Throwable $exception) {
+                    $reason = new RuntimeException(
+                        'Unable to open a selenium hub session (response deserialization).',
+                        0,
+                        $exception
+                    );
+
+                    $tabLookupDeferred->reject($reason);
+                }
+            },
+            function (Throwable $rejectionReason) use ($tabLookupDeferred) {
+                $reason = new RuntimeException('Unable to open a selenium hub session (request).', 0, $rejectionReason);
+
+                $tabLookupDeferred->reject($reason);
+            }
+        );
+
+        $tabIdentifierListPromise = $tabLookupDeferred->promise();
+
+        return $tabIdentifierListPromise;
     }
 
     /**

src/SeleniumHubDriver.php

@@ -139,9 +139,12 @@ public function removeSession(string $sessionIdentifier): PromiseInterface
      */
     public function getTabIdentifiers(string $sessionIdentifier): PromiseInterface
     {
-        // TODO: Implement getTabIdentifiers() method.
+        $sessionIdentifierPromise = $this->hubClient->getTabIdentifiers($sessionIdentifier);
 
-        return reject(new RuntimeException('Not implemented.'));
+        return $this->timeoutInterceptor->applyTimeout(
+            $sessionIdentifierPromise,
+            'Unable to complete a tab lookup command.'
+        );
     }
 
     /**

src/WebDriverFactory.php

@@ -120,6 +120,10 @@ function (OptionsResolver $commandOptionsResolver) {
         $socketConnector = new SocketConnector($loop, $optionsResolved['browser']);
         $httpClient      = new Browser($loop, $socketConnector);
 
+        // Selenium hub sends some valid responses with 5xx status codes, so we need to disable eager promise rejection
+        // to properly parse error message and other details from the body.
+        $httpClient = $httpClient->withRejectErrorResponse(false);
+
         $hubClient          = new W3CClient($httpClient, ['server' => $optionsResolved['hub']]);
         $timeoutInterceptor = new TimeoutInterceptor($loop, $optionsResolved['command']['timeout']);