Skip to content

Commit b32987c

Browse files
Fixed tests
Change-Id: I13594b5f53b5625735d307bd7014ff7be9308ada
1 parent fe21ca7 commit b32987c

5 files changed

Lines changed: 30 additions & 54 deletions

File tree

websockets-rxjava-example/build.gradle

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,7 @@ android {
4242
proguardFiles = [getDefaultProguardFile('proguard-android.txt'), 'src/main/proguard-project.txt']
4343
}
4444
}
45+
lintOptions {
46+
disable 'InvalidPackage'
47+
}
4548
}

websockets-rxjava-example/src/test/java/com/example/RxJsonWebSocketsRealTest.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.example;
1818

19-
import com.appunite.websocket.NewWebSocket;
2019
import com.appunite.websocket.rx.RxWebSockets;
2120
import com.appunite.websocket.rx.object.GsonObjectSerializer;
2221
import com.appunite.websocket.rx.object.RxObjectWebSockets;
@@ -25,6 +24,8 @@
2524
import com.google.common.collect.ImmutableList;
2625
import com.google.gson.Gson;
2726
import com.google.gson.GsonBuilder;
27+
import com.squareup.okhttp.OkHttpClient;
28+
import com.squareup.okhttp.Request;
2829

2930
import org.apache.http.Header;
3031
import org.junit.Before;
@@ -59,11 +60,12 @@ public void setUp() throws Exception {
5960
.registerTypeAdapter(MessageType.class, new MessageType.SerializerDeserializer())
6061
.create();
6162

62-
final NewWebSocket newWebSocket = new NewWebSocket();
63-
final RxWebSockets rxWebSockets = new RxWebSockets(newWebSocket,
64-
SERVER_URI,
65-
ImmutableList.of("chat"),
66-
ImmutableList.<Header>of());
63+
final RxWebSockets rxWebSockets = new RxWebSockets(new OkHttpClient(),
64+
new Request.Builder()
65+
.get()
66+
.url("ws://10.10.0.2:8080/ws")
67+
.addHeader("Sec-WebSocket-Protocol", "chat")
68+
.build());
6769
socket = new RxObjectWebSockets(rxWebSockets, new GsonObjectSerializer(gson, Message.class));
6870
}
6971

websockets-rxjava-example/src/test/java/com/example/RxWebSocketsRealTest.java

Lines changed: 8 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -16,46 +16,31 @@
1616

1717
package com.example;
1818

19-
import com.appunite.websocket.NewWebSocket;
2019
import com.appunite.websocket.rx.RxWebSockets;
2120
import com.appunite.websocket.rx.messages.RxEvent;
22-
import com.google.common.collect.ImmutableList;
21+
import com.squareup.okhttp.OkHttpClient;
22+
import com.squareup.okhttp.Request;
2323

24-
import org.apache.http.Header;
25-
import org.apache.http.message.BasicHeader;
2624
import org.junit.Before;
2725
import org.junit.Ignore;
2826
import org.junit.Test;
2927

30-
import java.net.URI;
31-
import java.net.URISyntaxException;
32-
3328
import rx.Subscription;
3429
import rx.functions.Action1;
3530
import rx.schedulers.Schedulers;
3631

3732
public class RxWebSocketsRealTest {
3833

39-
private static final URI SERVER_URI;
40-
41-
static {
42-
try {
43-
SERVER_URI = new URI("ws://192.168.0.142:8080/ws");
44-
} catch (URISyntaxException e) {
45-
throw new RuntimeException(e);
46-
}
47-
}
48-
49-
5034
private RxWebSockets socket;
5135

5236
@Before
5337
public void setUp() throws Exception {
54-
final NewWebSocket newWebSocket = new NewWebSocket();
55-
socket = new RxWebSockets(newWebSocket,
56-
SERVER_URI,
57-
ImmutableList.of("chat"),
58-
ImmutableList.<Header>of());
38+
socket = new RxWebSockets(new OkHttpClient(),
39+
new Request.Builder()
40+
.get()
41+
.url("ws://10.10.0.2:8080/ws")
42+
.addHeader("Sec-WebSocket-Protocol", "chat")
43+
.build());
5944

6045
}
6146

websockets-rxjava-example/src/test/java/com/example/SocketRealTest.java

Lines changed: 10 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -16,24 +16,21 @@
1616

1717
package com.example;
1818

19-
import com.appunite.websocket.NewWebSocket;
20-
import com.appunite.websocket.rx.*;
19+
import com.appunite.websocket.rx.RxWebSockets;
2120
import com.appunite.websocket.rx.object.GsonObjectSerializer;
2221
import com.appunite.websocket.rx.object.RxObjectWebSockets;
2322
import com.example.model.DataMessage;
24-
import com.example.model.MessageType;
2523
import com.example.model.Message;
26-
import com.google.common.collect.ImmutableList;
24+
import com.example.model.MessageType;
2725
import com.google.gson.Gson;
2826
import com.google.gson.GsonBuilder;
27+
import com.squareup.okhttp.OkHttpClient;
28+
import com.squareup.okhttp.Request;
2929

30-
import org.apache.http.Header;
3130
import org.junit.Before;
3231
import org.junit.Ignore;
3332
import org.junit.Test;
3433

35-
import java.net.URI;
36-
import java.net.URISyntaxException;
3734
import java.util.logging.Logger;
3835

3936
import rx.Observable;
@@ -43,17 +40,6 @@
4340

4441
public class SocketRealTest {
4542

46-
private static final URI SERVER_URI;
47-
48-
static {
49-
try {
50-
SERVER_URI = new URI("ws://192.168.0.142:8080/ws");
51-
} catch (URISyntaxException e) {
52-
throw new RuntimeException(e);
53-
}
54-
}
55-
56-
5743
private Socket socket;
5844

5945
@Before
@@ -63,11 +49,12 @@ public void setUp() throws Exception {
6349
.registerTypeAdapter(MessageType.class, new MessageType.SerializerDeserializer())
6450
.create();
6551

66-
final NewWebSocket newWebSocket = new NewWebSocket();
67-
final RxWebSockets webSockets = new RxWebSockets(newWebSocket,
68-
SERVER_URI,
69-
ImmutableList.of("chat"),
70-
ImmutableList.<Header>of());
52+
final RxWebSockets webSockets = new RxWebSockets(new OkHttpClient(),
53+
new Request.Builder()
54+
.get()
55+
.url("ws://10.10.0.2:8080/ws")
56+
.addHeader("Sec-WebSocket-Protocol", "chat")
57+
.build());
7158
final RxObjectWebSockets jsonWebSockets = new RxObjectWebSockets(webSockets, new GsonObjectSerializer(gson, Message.class));
7259
final SocketConnection socketConnection = new SocketConnectionImpl(jsonWebSockets, Schedulers.computation());
7360
socket = new Socket(socketConnection, Schedulers.computation());

websockets-rxjava-example/src/test/java/com/example/SocketTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.example;
1818

19-
import com.appunite.websocket.NotConnectedException;
2019
import com.appunite.websocket.rx.object.ObjectParseException;
2120
import com.appunite.websocket.rx.object.ObjectWebSocketSender;
2221
import com.appunite.websocket.rx.object.messages.RxObjectEvent;
@@ -83,7 +82,7 @@ public void testConnection_registerIsSent() throws Exception {
8382
}
8483
}
8584

86-
private void register() throws IOException, InterruptedException, NotConnectedException,
85+
private void register() throws IOException, InterruptedException,
8786
ObjectParseException {
8887
connection.onNext(new RxObjectEventConnected(sender), 0);
8988
testScheduler.triggerActions();

0 commit comments

Comments
 (0)