Remove link to platform on audit cmd (#706)

Author: attiasas

cli/scancommands.go

@@ -846,6 +846,7 @@ func UploadCdxCmd(c *components.Context) error {
 	uploadCmd := upload.NewUploadCycloneDxCommand().SetFileToUpload(c.Arguments[0]).
 		SetServerDetails(serverDetails).
 		SetUploadRepository(c.GetStringFlagValue(flags.UploadRepoPath)).
-		SetProjectKey(c.GetStringFlagValue(flags.Project))
+		SetProjectKey(c.GetStringFlagValue(flags.Project)).
+		SetPrintDeploymentView(true)
 	return commandsCommon.Exec(uploadCmd)
 }

commands/audit/audit.go

@@ -285,7 +285,7 @@ func (auditCmd *AuditCommand) getResultWriter(cmdResults *results.SecurityComman
 	if !cmdResults.EntitledForJas {
 		messages = []string{coreutils.PrintTitle("In addition to SCA, the ‘jf audit’ command supports the following Advanced Security scans: 'Contextual Analysis', 'Secrets Detection', 'IaC', and ‘SAST’.\nThese scans are available within Advanced Security license. Read more - ") + coreutils.PrintLink(utils.JasInfoURL)}
 	}
-	if cmdResults.ResultsPlatformUrl != "" {
+	if cmdResults.ResultsPlatformUrl != "" && auditCmd.gitContext != nil {
 		messages = append(messages, output.GetCommandResultsPlatformUrlMessage(cmdResults, true))
 	}
 	var tableNotes []string
@@ -744,7 +744,7 @@ func processScanResults(params *AuditParams, cmdResults *results.SecurityCommand
 	var err error
 	uploadPath := ""
 	if params.uploadCdxResults {
-		log.Info("Finished scanning. Uploading scan results to Artifactory")
+		log.Debug("Finished scanning. Uploading scan results to Artifactory")
 		if params.rtResultRepository == "" {
 			return cmdResults.AddGeneralError(errors.New("results repository was not provided, can't upload scan results to Artifactory"), false)
 		}

commands/upload/uploadcdx.go

@@ -29,6 +29,7 @@ type UploadCycloneDxCommand struct {
 	filePrefix      string
 
 	// Options
+	printDeploymentView   bool
 	scanResultsRepository string
 	projectKey            string
 }
@@ -75,6 +76,11 @@ func (ucc *UploadCycloneDxCommand) SetProjectKey(projectKey string) *UploadCyclo
 	return ucc
 }
 
+func (ucc *UploadCycloneDxCommand) SetPrintDeploymentView(printDeploymentView bool) *UploadCycloneDxCommand {
+	ucc.printDeploymentView = printDeploymentView
+	return ucc
+}
+
 func (ucc *UploadCycloneDxCommand) ServerDetails() (*config.ServerDetails, error) {
 	return ucc.serverDetails, nil
 }
@@ -127,7 +133,7 @@ func (ucc *UploadCycloneDxCommand) Upload() (artifactPath string, err error) {
 		return
 	}
 	// Upload the CycloneDx file to the JFrog repository
-	if artifactPath, err = createRepositoryIfNeededAndUploadFile(ucc.fileToUpload, ucc.serverDetails, ucc.scanResultsRepository, ucc.projectKey); err != nil {
+	if artifactPath, err = createRepositoryIfNeededAndUploadFile(ucc.fileToUpload, ucc.serverDetails, ucc.scanResultsRepository, ucc.projectKey, ucc.printDeploymentView); err != nil {
 		return "", fmt.Errorf("failed to upload file %s to repository %s: %w", ucc.fileToUpload, ucc.scanResultsRepository, err)
 	}
 	return
@@ -157,7 +163,7 @@ func validateInputFile(cdxFilePath string) (err error) {
 	return
 }
 
-func createRepositoryIfNeededAndUploadFile(filePath string, serverDetails *config.ServerDetails, scanResultsRepository, relatedProjectKey string) (artifactPath string, err error) {
+func createRepositoryIfNeededAndUploadFile(filePath string, serverDetails *config.ServerDetails, scanResultsRepository, relatedProjectKey string, printDeploymentView bool) (artifactPath string, err error) {
 	// scanResultsRepository may be the repository name and after the slash the path in the repository, we want to extract the repository name
 	repoName := strings.Split(scanResultsRepository, "/")[0]
 	if repoName == "" {
@@ -176,7 +182,7 @@ func createRepositoryIfNeededAndUploadFile(filePath string, serverDetails *confi
 	log.Debug(fmt.Sprintf("Uploading scan results to %s", scanResultsRepository))
 	// target repo is <repository name>/<repository path>, If the target path ends with a slash, the path is assumed to be a folder.
 	// Else it is assumed to be a file. so we add a slash to the end of the repo to indicate that it is a folder.
-	uploaded, err := artifactory.UploadArtifactsByPattern(filePath, serverDetails, clientUtils.AddTrailingSlashIfNeeded(scanResultsRepository), relatedProjectKey)
+	uploaded, err := artifactory.UploadArtifactsByPattern(filePath, serverDetails, clientUtils.AddTrailingSlashIfNeeded(scanResultsRepository), relatedProjectKey, printDeploymentView)
 	if err != nil {
 		return "", fmt.Errorf("failed to upload file %s to repository %s: %w", filePath, scanResultsRepository, err)
 	}

go.mod

@@ -16,7 +16,7 @@ require (
 	github.com/jfrog/gofrog v1.7.6
 	github.com/jfrog/jfrog-apps-config v1.0.1
 	github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260310063831-ad6064f2f373
-	github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260225195817-bc599cec3973
+	github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260324124720-40db37833f61
 	github.com/jfrog/jfrog-client-go v1.55.1-0.20260310073256-b6a77f9c75e5
 	github.com/magiconair/properties v1.8.10
 	github.com/owenrumney/go-sarif/v3 v3.2.3

go.sum

@@ -185,6 +185,8 @@ github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260310063831-ad6064f2f373 h1:9
 github.com/jfrog/jfrog-cli-artifactory v0.8.1-0.20260310063831-ad6064f2f373/go.mod h1:zjbDerW+Pin6VExtlgwRtpnvtI/ySJTnmqnOwXbsrmc=
 github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260225195817-bc599cec3973 h1:awB01Y4m0cWzmXuR3waf5IQnoQxDlbUmqT+FMWOpjbs=
 github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260225195817-bc599cec3973/go.mod h1:yhi+XpiEx18a3t8CZ6M2VpAf3EGqKpBhTzoPBTFe0dk=
+github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260324124720-40db37833f61 h1:fPGsJPPFCBr9qE9n0+fobbRZOdN2m2Ovr//8K07jil4=
+github.com/jfrog/jfrog-cli-core/v2 v2.60.1-0.20260324124720-40db37833f61/go.mod h1:yhi+XpiEx18a3t8CZ6M2VpAf3EGqKpBhTzoPBTFe0dk=
 github.com/jfrog/jfrog-client-go v1.55.1-0.20260310073256-b6a77f9c75e5 h1:BBo1kC74XgmFh4B5cNEhC/mhb70/ScLoDNw+P0d26rg=
 github.com/jfrog/jfrog-client-go v1.55.1-0.20260310073256-b6a77f9c75e5/go.mod h1:sCE06+GngPoyrGO0c+vmhgMoVSP83UMNiZnIuNPzU8U=
 github.com/jhump/protoreflect v1.15.1 h1:HUMERORf3I3ZdX05WaQ6MIpd/NJ434hTp5YiKgfCL6c=

utils/artifactory/artifactoryutils.go

@@ -86,14 +86,24 @@ func getArtifactoryRepositoryConfig(tech techutils.Technology) (repoConfig *proj
 	return
 }
 
-func UploadArtifactsByPattern(pattern string, serverDetails *config.ServerDetails, repo, relatedProjectKey string) (uploaded []string, err error) {
+func UploadArtifactsByPattern(pattern string, serverDetails *config.ServerDetails, repo, relatedProjectKey string, printDeploymentView bool) (uploaded []string, err error) {
 	uploadCmd := generic.NewUploadCommand()
 	uploadCmd.SetUploadConfiguration(&artifactoryUtils.UploadConfiguration{Threads: 1}).SetServerDetails(serverDetails).SetSpec(spec.NewBuilder().Pattern(pattern).Project(relatedProjectKey).Target(repo).Flat(true).BuildSpec())
 	uploadCmd.SetDetailedSummary(true).SetQuiet(true)
 	err = uploadCmd.Run()
 	result := uploadCmd.Result()
 	defer common.CleanupResult(result, &err)
-	return getArtifactsPaths(repo, result.Reader()), common.PrintDeploymentView(result.Reader())
+	if view, e := common.GetDeploymentViewString(result.Reader()); e != nil {
+		log.Debug(fmt.Sprintf("failed to get deployment view: %v", e))
+	} else if view != "" {
+		view = fmt.Sprintf("These files were uploaded:\n\n%s", view)
+		if printDeploymentView {
+			log.Info(view)
+		} else {
+			log.Debug(view)
+		}
+	}
+	return getArtifactsPaths(repo, result.Reader()), err
 }
 
 func getArtifactsPaths(repo string, reader *content.ContentReader) (paths []string) {

utils/results/output/reportartifact.go

@@ -44,7 +44,6 @@ func UploadCommandResults(serverDetails *config.ServerDetails, rtResultRepositor
 	// Set the results platform URL in the command results and log it
 	if resultsUrl := getCommandScanResultsPlatformUrl(cdxResults, serverDetails, filepath.ToSlash(filepath.Join(rtResultRepository, artifactFinalRepoPath)), artifactName); resultsUrl != "" {
 		cmdResults.SetResultsPlatformUrl(resultsUrl)
-		log.Info(GetCommandResultsPlatformUrlMessage(cmdResults, false))
 	}
 	return filepath.ToSlash(filepath.Join(artifactFinalRepoPath, artifactName)), nil
 }