bean parser: dot notation fix #486

Author: jknack

coverage-report/src/test/java/org/jooby/issues/Issue483.java

@@ -1,5 +1,6 @@
 package org.jooby.issues;
 
+import java.util.List;
 import java.util.Optional;
 
 import org.jooby.Parser;
@@ -8,6 +9,28 @@
 
 public class Issue483 extends ServerFeature {
 
+  public static class Member {
+    String firstname;
+
+    String lastname;
+
+    @Override
+    public String toString() {
+      return firstname + " " + lastname;
+    }
+  }
+
+  public static class Group {
+
+    List<Member> members;
+
+    @Override
+    public String toString() {
+      return Optional.ofNullable(members).map(it -> it.toString()).orElse("[]");
+    }
+
+  }
+
   public static class NullableBean {
 
     String foo;
@@ -23,24 +46,44 @@ public String toString() {
   {
     parser(Parser.bean(true));
 
-    get("/483", req -> {
+    get("/483/dot", req -> {
+      return req.params().toList(Member.class);
+    });
+
+    get("/483/nested", req -> {
+      return req.params(Group.class);
+    });
+
+    get("/483/null", req -> {
       return req.params(NullableBean.class).toString();
     });
 
   }
 
+  @Test
+  public void dotNotation() throws Exception {
+    request()
+        .get("/483/dot?0.firstname=Pedro&0.lastname=PicaPiedra")
+        .expect("[Pedro PicaPiedra]");
+
+    request()
+        .get("/483/nested?members.0.firstname=Pedro&members.0.lastname=PicaPiedra")
+        .expect("[Pedro PicaPiedra]");
+
+  }
+
   @Test
   public void documentNullBeanInjection() throws Exception {
     request()
-        .get("/483?foo=foo")
+        .get("/483/null?foo=foo")
         .expect("foonull");
 
     request()
-        .get("/483?foo=foo&bar")
+        .get("/483/null?foo=foo&bar")
         .expect("fooOptional[]");
 
     request()
-        .get("/483?foo=foo&bar=bar")
+        .get("/483/null?foo=foo&bar=bar")
         .expect("fooOptional[bar]");
   }
 

jooby/src/main/java/org/jooby/internal/parser/bean/BeanPlan.java

@@ -186,7 +186,7 @@ private List<BeanPath> compile(final Iterator<String> it, final TypeLiteral bean
   }
 
   private List<Tuple2<String, Integer>> segments(final String path) {
-    List<String> segments = Splitter.on(CharMatcher.anyOf("[]")).trimResults()
+    List<String> segments = Splitter.on(CharMatcher.anyOf("[].")).trimResults()
         .omitEmptyStrings()
         .splitToList(path);
     List<Tuple2<String, Integer>> result = new ArrayList<>(segments.size());