named executor failure fix #567

Author: jknack

coverage-report/src/test/java/org/jooby/issues/Issue556.java

@@ -0,0 +1,23 @@
+package org.jooby.issues;
+
+import java.util.concurrent.Executors;
+
+import org.jooby.assets.AssetsBase;
+import org.junit.Test;
+
+public class Issue556 extends AssetsBase {
+
+  {
+    executor("async", Executors.newFixedThreadPool(10));
+
+    get("/556/async", deferred("async", () -> "Async"));
+  }
+
+  @Test
+  public void async() throws Exception {
+    request()
+        .get("/556/async")
+        .expect("Async");
+  }
+
+}

jooby/src/main/java/org/jooby/Jooby.java

@@ -691,6 +691,8 @@ public EnvDep(final Predicate<String> predicate, final Consumer<Config> callback
 
   private List<Consumer<Binder>> executors = new ArrayList<>();
 
+  private boolean defaultExecSet;
+
   /**
    * Creates a new {@link Jooby} application.
    */
@@ -2306,6 +2308,7 @@ public Jooby executor(final ExecutorService executor) {
    * @return This jooby instance.
    */
   public Jooby executor(final Executor executor) {
+    this.defaultExecSet = true;
     this.executors.add(binder -> {
       binder.bind(Key.get(String.class, Names.named("deferred"))).toInstance("deferred");
       binder.bind(Key.get(Executor.class, Names.named("deferred"))).toInstance(executor);
@@ -2363,6 +2366,7 @@ public Jooby executor(final String name, final Executor executor) {
    * @return This jooby instance.
    */
   public Jooby executor(final String name) {
+    defaultExecSet = true;
     this.executors.add(binder -> {
       binder.bind(Key.get(String.class, Names.named("deferred"))).toInstance(name);
     });
@@ -2483,8 +2487,8 @@ private Injector bootstrap(final Config args,
       throw new IllegalStateException("Required property 'application.secret' is missing");
     }
 
-    /** executors . */
-    if (executors.isEmpty()) {
+    /** executors: */
+    if (!defaultExecSet) {
       // default executor
       executor(MoreExecutors.directExecutor());
     }