Merge pull request #735 from pierredavidbelanger/731

A minimal test (failing) to show that a Netty buffer is not accessible

Author: jknack

coverage-report/src/test/java/org/jooby/issues/Issue731.java

@@ -0,0 +1,26 @@
+package org.jooby.issues;
+
+import org.jooby.test.ServerFeature;
+import org.junit.Test;
+
+import java.util.concurrent.Executors;
+
+public class Issue731 extends ServerFeature {
+
+  {
+
+    executor("worker1", Executors.newSingleThreadExecutor());
+
+    post("/", deferred("worker1", req -> req.body(String.class)));
+
+  }
+
+  @Test
+  public void appShouldBeAbleToReadTheRequestBodyWhenDeferred() throws Exception {
+    request()
+            .post("/")
+            .body("HelloWorld!", "text/plain")
+            .expect(200)
+            .expect("HelloWorld!");
+  }
+}

jooby-netty/src/main/java/org/jooby/internal/netty/NettyRequest.java

@@ -43,6 +43,7 @@
 import com.google.common.collect.Multimap;
 
 import io.netty.buffer.ByteBuf;
+import io.netty.buffer.ByteBufHolder;
 import io.netty.buffer.ByteBufInputStream;
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelHandlerContext;
@@ -63,6 +64,7 @@
 import io.netty.handler.codec.http.websocketx.WebSocketServerHandshakerFactory;
 import io.netty.handler.codec.http2.HttpConversionUtil;
 import io.netty.util.AttributeKey;
+import io.netty.util.ReferenceCounted;
 
 public class NettyRequest implements NativeRequest {
 
@@ -242,7 +244,15 @@ public void startAsync(final Executor executor, final Runnable runnable) {
     channel.attr(NEED_FLUSH).set(false);
     channel.attr(ASYNC).set(true);
 
-    executor.execute(runnable);
+    ReferenceCounted referenceCounted = ((ByteBufHolder) req).content();
+    referenceCounted.retain();
+    executor.execute(() -> {
+      try {
+        runnable.run();
+      } finally {
+        referenceCounted.release();
+      }
+    });
   }
 
   private org.jooby.Cookie cookie(final Cookie c) {