skip unsupported mvc route attributes fix #568

Author: jknack

jooby/src/main/java/org/jooby/Jooby.java

@@ -634,64 +634,64 @@ public EnvDep(final Predicate<String> predicate, final Consumer<Config> callback
   /**
    * Keep track of routes.
    */
-  private Set<Object> bag = new LinkedHashSet<>();
+  private transient Set<Object> bag = new LinkedHashSet<>();
 
   /**
    * The override config. Optional.
    */
-  private Config srcconf;
+  private transient Config srcconf;
 
-  private final AtomicBoolean started = new AtomicBoolean(false);
+  private final transient AtomicBoolean started = new AtomicBoolean(false);
 
   /** Keep the global injector instance. */
-  private Injector injector;
+  private transient Injector injector;
 
   /** Session store. */
-  private Session.Definition session = new Session.Definition(Session.Mem.class);
+  private transient Session.Definition session = new Session.Definition(Session.Mem.class);
 
   /** Env builder. */
-  private Env.Builder env = Env.DEFAULT;
+  private transient Env.Builder env = Env.DEFAULT;
 
   /** Route's prefix. */
-  private String prefix;
+  private transient String prefix;
 
   /** startup callback . */
-  private List<CheckedConsumer<Registry>> onStart = new ArrayList<>();
+  private transient List<CheckedConsumer<Registry>> onStart = new ArrayList<>();
 
   /** stop callback . */
-  private List<CheckedConsumer<Registry>> onStop = new ArrayList<>();
+  private transient List<CheckedConsumer<Registry>> onStop = new ArrayList<>();
 
   /** Mappers . */
   @SuppressWarnings("rawtypes")
-  private Mapper mapper;
+  private transient Mapper mapper;
 
   /** Don't add same mapper twice . */
-  private Set<String> mappers = new HashSet<>();
+  private transient Set<String> mappers = new HashSet<>();
 
   /** Bean parser . */
-  private Optional<Parser> beanParser = Optional.empty();
+  private transient Optional<Parser> beanParser = Optional.empty();
 
-  private ServerLookup server = new ServerLookup();
+  private transient ServerLookup server = new ServerLookup();
 
-  private String dateFormat;
+  private transient String dateFormat;
 
-  private Charset charset;
+  private transient Charset charset;
 
-  private String[] languages;
+  private transient String[] languages;
 
-  private ZoneId zoneId;
+  private transient ZoneId zoneId;
 
-  private Integer port;
+  private transient Integer port;
 
-  private Integer securePort;
+  private transient Integer securePort;
 
-  private String numberFormat;
+  private transient String numberFormat;
 
-  private boolean http2;
+  private transient boolean http2;
 
-  private List<Consumer<Binder>> executors = new ArrayList<>();
+  private transient List<Consumer<Binder>> executors = new ArrayList<>();
 
-  private boolean defaultExecSet;
+  private transient boolean defaultExecSet;
 
   /**
    * Creates a new {@link Jooby} application.

jooby/src/main/java/org/jooby/Route.java

@@ -1229,19 +1229,20 @@ public Definition attr(final String name, final Object value) {
       requireNonNull(name, "Attribute name is required.");
       requireNonNull(value, "Attribute value is required.");
 
-      validate(value);
-      attributes.put(name, value);
+      if (valid(value)) {
+        attributes.put(name, value);
+      }
       return this;
     }
 
-    private boolean validate(final Object value) {
+    private boolean valid(final Object value) {
       return Match(value).option(
           Case(v -> Primitives.isWrapperType(Primitives.wrap(v.getClass())), true),
           Case(instanceOf(String.class), true),
           Case(instanceOf(Enum.class), true),
           Case(instanceOf(Class.class), true),
-          Case(c -> c.getClass().isArray(), v -> validate(Array.get(v, 0))))
-          .getOrElseThrow(() -> new IllegalArgumentException("Unsupported attribute: " + value));
+          Case(c -> c.getClass().isArray(), v -> valid(Array.get(v, 0))))
+          .getOrElse(false);
     }
 
     /**
@@ -1623,7 +1624,9 @@ public static Route unwrap(final Route route) {
    * The most advanced route handler which let you decided if the next route handler in the chain
    * can be executed or not. Example of filters are:
    *
-   * <p>Auth handler example:</p>
+   * <p>
+   * Auth handler example:
+   * </p>
    *
    * <pre>
    *   String token = req.header("token").value();
@@ -1637,7 +1640,9 @@ public static Route unwrap(final Route route) {
    *   }
    * </pre>
    *
-   * <p>Logging/Around handler example:</p>
+   * <p>
+   * Logging/Around handler example:
+   * </p>
    *
    * <pre>
    *   long start = System.currentTimeMillis();

jooby/src/test/java/org/jooby/RouteDefinitionTest.java

@@ -1,6 +1,7 @@
 package org.jooby;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
 
 import java.util.Arrays;
@@ -321,7 +322,7 @@ public void src() throws Exception {
     Function<String, Route.Definition> route = path -> new Route.Definition("*", path, () -> null);
     Route.Definition r = route.apply("/");
 
-    assertEquals("org.jooby.RouteDefinitionTest:321", r.source().toString());
+    assertEquals("org.jooby.RouteDefinitionTest:322", r.source().toString());
   }
 
   @Test
@@ -345,10 +346,12 @@ public void attrsArray() throws Exception {
     assertTrue(Arrays.equals(new int[]{7 }, (int[]) r.attr("i")));
   }
 
-  @Test(expected = IllegalArgumentException.class)
+  @Test
   public void attrUnsupportedType() throws Exception {
     Function<String, Route.Definition> route = path -> new Route.Definition("*", path, () -> null);
-    route.apply("/").attr("i", new Object());
+    Route.Definition r = route.apply("/");
+    r.attr("i", new Object());
+    assertNull(r.attr("i"));
   }
 
 }