Skip to content

Commit 194b5d0

Browse files
committed
Make store_operation_duration histogram more narrow.
1 parent 5447630 commit 194b5d0

2 files changed

Lines changed: 1 addition & 13 deletions

File tree

nativelink-scheduler/src/simple_scheduler_state_manager.rs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1188,9 +1188,6 @@ where
11881188
.unique_qualifier
11891189
.instance_name()
11901190
.as_str();
1191-
let worker_id = awaited_action
1192-
.worker_id()
1193-
.map(std::string::ToString::to_string);
11941191
let priority = Some(awaited_action.action_info().priority);
11951192

11961193
// Build base attributes for metrics

nativelink-util/src/metrics.rs

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1622,29 +1622,20 @@ pub static STORE_METRICS: LazyLock<StoreMetrics> = LazyLock::new(|| {
16221622
// memory, a filesystem, or network storage. The current values were
16231623
// determined empirically and might need adjustment.
16241624
.with_boundaries(vec![
1625-
// Microsecond range
1626-
0.001, // 1μs
1627-
0.005, // 5μs
1628-
0.01, // 10μs
1629-
0.05, // 50μs
16301625
0.1, // 100μs
16311626
// Sub-millisecond range
1632-
0.2, // 200μs
16331627
0.5, // 500μs
16341628
1.0, // 1ms
16351629
// Low millisecond range
1636-
2.0, // 2ms
16371630
5.0, // 5ms
16381631
10.0, // 10ms
1639-
20.0, // 20ms
16401632
50.0, // 50ms
16411633
100.0, // 100ms
16421634
// Higher latency range
1643-
200.0, // 200ms
16441635
500.0, // 500ms
16451636
1000.0, // 1 second
1646-
2000.0, // 2 seconds
16471637
5000.0, // 5 seconds
1638+
10000.0, // 10 seconds
16481639
])
16491640
.build(),
16501641

0 commit comments

Comments
 (0)