[PHP8.4] Deprecate implicitly nullable parameter types (#304)

AppVeyor fail is unrelated

Author: heelc29

Tests/DatabaseQueryTest.php

@@ -9,8 +9,8 @@
 use Joomla\Database\DatabaseInterface;
 use Joomla\Database\DatabaseQuery;
 use Joomla\Database\Exception\QueryTypeAlreadyDefinedException;
-use Joomla\Database\ParameterType;
 use Joomla\Database\Exception\UnknownTypeException;
+use Joomla\Database\ParameterType;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 

Tests/Mysql/MysqlPreparedStatementTest.php

@@ -8,7 +8,6 @@
 
 use Joomla\Database\DatabaseDriver;
 use Joomla\Database\Exception\ExecutionFailureException;
-use Joomla\Database\Mysqli\MysqliStatement;
 use Joomla\Test\DatabaseTestCase;
 
 class MysqlPreparedStatementTest extends DatabaseTestCase

src/Command/ExportCommand.php

@@ -16,9 +16,9 @@
 use Joomla\Database\Exception\UnsupportedAdapterException;
 use Joomla\Filesystem\File;
 use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Input\InputOption;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Style\SymfonyStyle;
-use Symfony\Component\Console\Input\InputOption;
 
 /**
  * Console command for exporting the database

src/DatabaseDriver.php

@@ -1721,7 +1721,7 @@ public function getMonitor()
      *
      * @since   2.0.0
      */
-    public function setMonitor(QueryMonitorInterface $monitor = null)
+    public function setMonitor(?QueryMonitorInterface $monitor = null)
     {
         $this->monitor = $monitor;
 

src/DatabaseQuery.php

@@ -303,7 +303,7 @@ abstract class DatabaseQuery implements QueryInterface
      *
      * @since   1.0
      */
-    public function __construct(DatabaseInterface $db = null)
+    public function __construct(?DatabaseInterface $db = null)
     {
         $this->db = $db;
     }

src/Exception/ConnectionFailureException.php

@@ -25,7 +25,7 @@ class ConnectionFailureException extends \RuntimeException
      *
      * @since   2.0.0
      */
-    public function __construct($message = '', $code = 0, \Exception $previous = null)
+    public function __construct($message = '', $code = 0, ?\Exception $previous = null)
     {
         // PDO uses strings for exception codes, PHP forces numeric codes, so "force" the string code to be used
         parent::__construct($message, 0, $previous);

src/Exception/ExecutionFailureException.php

@@ -34,7 +34,7 @@ class ExecutionFailureException extends \RuntimeException
      *
      * @since   1.5.0
      */
-    public function __construct($query, $message = '', $code = 0, \Exception $previous = null)
+    public function __construct($query, $message = '', $code = 0, ?\Exception $previous = null)
     {
         // PDO uses strings for exception codes, PHP forces numeric codes, so "force" the string code to be used
         parent::__construct($message, 0, $previous);

src/Exception/PrepareStatementFailureException.php

@@ -25,7 +25,7 @@ class PrepareStatementFailureException extends \RuntimeException
      *
      * @since   2.0.0
      */
-    public function __construct($message = '', $code = 0, \Exception $previous = null)
+    public function __construct($message = '', $code = 0, ?\Exception $previous = null)
     {
         // PDO uses strings for exception codes, PHP forces numeric codes, so "force" the string code to be used
         parent::__construct($message, 0, $previous);

src/QueryInterface.php

@@ -10,9 +10,9 @@
 namespace Joomla\Database;
 
 use Joomla\Database\Exception\QueryTypeAlreadyDefinedException;
+use Joomla\Database\Exception\UnknownTypeException;
 use Joomla\Database\Query\LimitableInterface;
 use Joomla\Database\Query\PreparableInterface;
-use Joomla\Database\Exception\UnknownTypeException;
 
 /**
  * Joomla Framework Query Building Interface.

src/Sqlsrv/SqlsrvDriver.php

@@ -120,7 +120,7 @@ public function connect()
             'pwd'                  => $this->options['password'],
             'CharacterSet'         => 'UTF-8',
             'ReturnDatesAsStrings' => true,
-            'Encrypt'              => $this->options['encrypt']
+            'Encrypt'              => $this->options['encrypt'],
         ];
 
         // Attempt to connect to the server.