Skip to content

SRA reads extraction command is a single string rather than an array of strings #326

@MrCreosote

Description

@MrCreosote

That makes user attacks possible as subprocess can't quote arguments correctly.

command = self.SRA_TOOLKIT_PATH + ' --split-3 -T -O '
command += tmp_dir + ' ' + scratch_sra_file_path

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions