Skip to content

Commit b882000

Browse files
committed
openboard-team#491 do not lock when processing key/motion events because one could be sent while another is already processing
1 parent e429c02 commit b882000

1 file changed

Lines changed: 16 additions & 20 deletions

File tree

app/src/main/java/io/github/sds100/keymapper/inputmethod/latin/KeyEventRelayServiceWrapper.kt

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -98,17 +98,15 @@ class KeyEventRelayServiceWrapperImpl(
9898
targetPackageName: String,
9999
callbackId: String,
100100
): Boolean {
101-
synchronized(keyEventRelayServiceLock) {
102-
if (keyEventRelayService == null) {
103-
return false
104-
}
101+
if (keyEventRelayService == null) {
102+
return false
103+
}
105104

106-
try {
107-
return keyEventRelayService!!.sendKeyEvent(event, targetPackageName, callbackId)
108-
} catch (e: DeadObjectException) {
109-
keyEventRelayService = null
110-
return false
111-
}
105+
try {
106+
return keyEventRelayService!!.sendKeyEvent(event, targetPackageName, callbackId)
107+
} catch (e: DeadObjectException) {
108+
keyEventRelayService = null
109+
return false
112110
}
113111
}
114112

@@ -117,17 +115,15 @@ class KeyEventRelayServiceWrapperImpl(
117115
targetPackageName: String,
118116
callbackId: String,
119117
): Boolean {
120-
synchronized(keyEventRelayServiceLock) {
121-
if (keyEventRelayService == null) {
122-
return false
123-
}
118+
if (keyEventRelayService == null) {
119+
return false
120+
}
124121

125-
try {
126-
return keyEventRelayService!!.sendMotionEvent(event, targetPackageName, callbackId)
127-
} catch (e: DeadObjectException) {
128-
keyEventRelayService = null
129-
return false
130-
}
122+
try {
123+
return keyEventRelayService!!.sendMotionEvent(event, targetPackageName, callbackId)
124+
} catch (e: DeadObjectException) {
125+
keyEventRelayService = null
126+
return false
131127
}
132128
}
133129

0 commit comments

Comments
 (0)