- unit tests improvements

Author: kodeart

Tests/LogConstructorTest.php

@@ -7,7 +7,6 @@
 
 class LogConstructorTest extends TestCase
 {
-
     public function test_construction_with_config_array()
     {
         $log = new Log([

Tests/LogDeferredTest.php

@@ -51,7 +51,7 @@ public function test_log_suppression()
         $this->assertSame('', $processor->formatted());
     }
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->SUT = new Log([
             'deferred' => true,

Tests/LogTest.php

@@ -42,9 +42,9 @@ public function test_log_suppression()
 
         $processor->update([
             [
-                'level' => -1, // this is ignored
+                'level'     => -1, // this is ignored
                 'levelname' => 'DEBUG',
-                'message' => 'Hello',
+                'message'   => 'Hello',
                 'timestamp' => 1234567890
             ]
         ]);
@@ -57,11 +57,11 @@ public function test_exception()
         $processor = new Memory([]);
         $this->SUT->exception(new Exception('The message', 1), $processor);
 
-        $this->assertAttributeContains('[CRITICAL]', 'formatted', $processor);
-        $this->assertAttributeContains('The message', 'formatted', $processor);
+         $this->assertAttributeContains('[CRITICAL]', 'formatted', $processor);
+         $this->assertAttributeContains('The message', 'formatted', $processor);
     }
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->SUT = new Log([]);
     }

Tests/Processors/DefaultProcessorPropertiesTest.php

@@ -7,7 +7,6 @@
 
 class DefaultProcessorPropertiesTest extends TestCase
 {
-
     public function test_defaults()
     {
         $processor = new Memory([]);

Tests/Processors/FileTest.php

@@ -7,7 +7,6 @@
 
 class FileTest extends TestCase
 {
-
     /**
      * @var vfsStreamDirectory
      */
@@ -21,15 +20,15 @@ public function test_update()
         $processor = new File(['dir' => $this->dir->url()]);
         $processor->update([
             [
-                'level' => -1,
+                'level'     => -1,
                 'levelname' => 'DEBUG',
-                'message' => 'Test 1',
+                'message'   => 'Test 1',
                 'timestamp' => 1234567890
             ],
             [
-                'level' => -1,
+                'level'     => -1,
                 'levelname' => 'DEBUG',
-                'message' => 'Test 2',
+                'message'   => 'Test 2',
                 'timestamp' => 1234567891
             ]
         ]);
@@ -38,12 +37,12 @@ public function test_update()
         $this->assertTrue($this->dir->hasChild($subdirectory));
 
         $content = $this->dir->getChild($subdirectory . DIRECTORY_SEPARATOR . $file)->getContent();
-        $this->assertContains("1234567891 [DEBUG]: Test 2\n", $content);
+        $this->assertStringContainsString("1234567891 [DEBUG]: Test 2\n", $content);
     }
 
     public function test_when_directory_does_not_exist()
     {
-        $dir = $this->dir->url() . '/nonexistent/';
+        $dir = $this->dir->url() . '/nonexistent';
 
         $this->expectException(FileProcessorException::class);
         $this->expectExceptionMessage('Log directory "' . $dir . '" must exist');
@@ -57,14 +56,14 @@ public function test_when_directory_is_not_writable()
         $dir = $this->dir->url();
 
         $this->expectException(FileProcessorException::class);
-        $this->expectExceptionMessage('Log directory "' . $dir . '/" must be writable');
+        $this->expectExceptionMessage('Log directory "' . $dir . '" must be writable');
 
         vfsStreamWrapper::getRoot()->chmod(0400);
         $processor = new File(['dir' => $dir]);
         $processor->update([]);
     }
 
-    protected function setUp()
+    protected function setUp(): void
     {
         $this->dir = vfsStream::setup();
     }

Tests/Processors/MemoryTest.php

@@ -2,27 +2,25 @@
 
 namespace Koded\Logging\Processors;
 
-use function Koded\Stdlib\dump;
 use PHPUnit\Framework\TestCase;
 
 class MemoryTest extends TestCase
 {
-
     public function test_formatting()
     {
         $processor = new Memory([]);
 
         $processor->update([
             [
-                'level' => -1,
+                'level'     => -1,
                 'levelname' => 'TEST',
-                'message' => 'Hello',
+                'message'   => 'Hello',
                 'timestamp' => 1234567890
             ],
             [
-                'level' => -1,
+                'level'     => -1,
                 'levelname' => 'TEST',
-                'message' => 'World',
+                'message'   => 'World',
                 'timestamp' => 1234567891
             ]
         ]);