- reverted the set() and has() signatures (Deprecated implicit conversion in 8.1)

Author: kodeart

AccessorTrait.php

@@ -50,7 +50,7 @@ public function get(string $index, mixed $default = null): mixed
         return $this->storage[$index] ?? $default;
     }
 
-    public function has(mixed $index): bool
+    public function has(string $index): bool
     {
         return array_key_exists($index, $this->storage);
     }

ExtendedArguments.php

@@ -58,7 +58,7 @@ public function append(string $index, mixed $value): static
         return $this;
     }
 
-    public function has(mixed $index): bool
+    public function has(string $index): bool
     {
         $storage = & $this->storage;
         foreach (explode('.', $index) as $i) {

Interfaces.php

@@ -102,11 +102,11 @@ public function get(string $index, mixed $default = null): mixed;
     /**
      * Checks if the key exist.
      *
-     * @param mixed $index The index name
+     * @param string $index The index name
      *
      * @return bool
      */
-    public function has(mixed $index): bool;
+    public function has(string $index): bool;
 
     /**
      * Checks if two properties has equal values.
@@ -152,12 +152,12 @@ interface Argument extends Data
      * Value mutator.
      * Sets a value for a property.
      *
-     * @param int|string $index The name of the property
+     * @param string $index The name of the property
      * @param mixed  $value The value
      *
      * @return static
      */
-    public function set(mixed $index, mixed $value): static;
+    public function set(string $index, mixed $value): static;
 
     /**
      * Imports multiple values. The existing are overridden.

MutatorTrait.php

@@ -21,7 +21,7 @@ public function __set($index, $value)
         return $this->set($index, $value);
     }
 
-    public function set(mixed $index, mixed $value): static
+    public function set(string $index, mixed $value): static
     {
         $this->storage[$index] = $value;
         return $this;

tests/ArgumentObjectTest.php

@@ -218,7 +218,7 @@ public function test_indirect_array_modification()
     public function test_some_implicit_conversion_pain($store)
     {
         // Here comes the fun...
-        $this->assertTrue($store->has(3.14), 'Key exists? Lets see...');
+        $this->assertFalse($store->has(3.14), 'Key DOES NOT exist. Lets see...');
         $this->assertNotSame('oh no', $store->get(3.14), 'Wait what? (test is false positive btw)');
         $this->assertSame(null, $store->get(3.14), 'I expected something else');
         $this->assertSame('oh no', $store->get(3), 'The amazing implicit conversion of 3.14 and the override of the existing key 3');
@@ -249,7 +249,6 @@ public function pain()
             '3.140' => 'yes',
         ];
 
-        // using set()
         $store = new Arguments;
         foreach ($data as $index => $value) {
             $store->set($index, $value);

tests/ImmutableObjectTest.php

@@ -37,8 +37,14 @@ public function test_should_transform_immutable_to_argument_object()
     public function test_should_get_things()
     {
         $this->assertNull($this->SUT->get('fubar'));
-        $this->assertTrue($this->SUT->get(true));
-        $this->assertTrue($this->SUT->has(null));
+
+        $this->assertTrue($this->SUT->get(true), 'All 3 are valid :(');
+        $this->assertTrue($this->SUT->get(1));
+        $this->assertTrue($this->SUT->get('1'));
+
+        $this->assertSame('null', $this->SUT->get(''), 'NULL key is typecasted to ""');
+        $this->assertNull($this->SUT->get('null'), 'No to be confused, this is a normal string');
+
         $this->assertSame('bar', $this->SUT->foo);
         $this->assertSame(0, $this->SUT->get('0'));
         $this->assertSame(0, $this->SUT->{0});