Fix unit testing and code quality pipeline (#8)

Author: vipul-rawat

.github/workflows/cicd.yml

@@ -16,21 +16,24 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go-version: ['1.21', '1.22']
+        go-version: ['1.22', '1.21']
 
     steps:
       - name: Checkout code into go module directory
         uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
 
       - name: Set up Go ${{ matrix.go-version }}
-        uses: actions/setup-go@v4
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go-version }}
         id: Go
 
       - name: Get dependencies
         run: |
           go mod download
+          go mod tidy
 
       - name: Test
         run: |
@@ -59,5 +62,5 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.57.2
+          version: v1.59.1
           args: --timeout=9m

.golangci.yml

@@ -1,3 +1,4 @@
+---
 linters-settings:
   dupl:
     threshold: 100
@@ -8,7 +9,9 @@ linters-settings:
     statements: 50
   gci:
     sections:
-      - prefix(kops.dev)
+      - standard
+      - default
+      - localmodule
   goconst:
     min-len: 2
     min-occurrences: 2
@@ -28,10 +31,10 @@ linters-settings:
   gocyclo:
     min-complexity: 10
   goimports:
-    local-prefixes: kops.dev
+    local-prefixes: github.com/golangci/golangci-lint
   golint:
     min-confidence: 0
-  gomnd:
+  mnd:
     checks:
       - argument
       - case
@@ -40,6 +43,11 @@ linters-settings:
   govet:
     enable:
       - shadow
+    settings:
+      printf:
+        funcs:
+          - (gofr.dev/pkg/gofr/Logger).Logf
+          - (gofr.dev/pkg/gofr/Logger).Errorf
   lll:
     line-length: 140
   maligned:
@@ -50,6 +58,38 @@ linters-settings:
     allow-unused: false # report any unused nolint directives
     require-explanation: true # require an explanation for nolint directives
     require-specific: true # require nolint directives to be specific about which linter is being skipped
+  revive:
+    rules:
+      # default revive rules, they have to be present otherwise they are disabled
+      - name: blank-imports
+      - name: context-as-argument
+      - name: context-keys-type
+      - name: dot-imports
+      - name: empty-block
+      - name: error-naming
+      - name: error-return
+      - name: error-strings
+      - name: errorf
+      - name: increment-decrement
+      - name: indent-error-flow
+      - name: range
+      - name: receiver-naming
+      - name: redefines-builtin-id
+      - name: superfluous-else
+      - name: time-naming
+      - name: unexported-return
+      - name: unreachable-code
+      - name: unused-parameter
+      - name: var-declaration
+      - name: var-naming
+      # additional revive rules
+      - name: bare-return
+      - name: bool-literal-in-expr
+      - name: comment-spacings
+      - name: early-return
+      - name: defer
+      - name: deep-exit
+      - name: unused-receiver
 
 linters:
   # please, do not use `enable-all`: it's deprecated and will be removed soon.
@@ -60,7 +100,9 @@ linters:
     - bodyclose
     - dogsled
     - dupl
+    - err113
     - errcheck
+    - errorlint
     - exhaustive
     - exportloopref
     - funlen
@@ -71,17 +113,17 @@ linters:
     - gocritic
     - gocyclo
     - godot
-    - goerr113
     - gofmt
     - goimports
-    - gomnd
     - goprintffuncname
     - gosec
     - gosimple
     - govet
     - ineffassign
     - lll
+    - mirror
     - misspell
+    - mnd
     - nakedret
     - nestif
     - noctx
@@ -91,9 +133,11 @@ linters:
     - rowserrcheck
     - staticcheck
     - stylecheck
+    - thelper
     - unconvert
     - unparam
     - unused
+    - usestdlibvars
     - whitespace
     - wsl
 
@@ -103,7 +147,7 @@ linters:
 
 
 service:
-  golangci-lint-version: 1.58.x
+  golangci-lint-version: 1.59.x
 
 issues:
   # exclude-use-default: false