Refactor Placement enum and update positioning strategy

Moved the Placement enum from geometry.dart to a new placement.dart file and updated all imports accordingly. Renamed positioning_strategy.dart for clarity and added support for positioning relative to a Window in PositioningStrategy, including dynamic bounds retrieval. Updated context menu region logic to use the new relativeToWindow method for menu positioning.

Author: lijy91

packages/cnativeapi/macos/Classes/cnativeapi.mm

@@ -38,8 +38,8 @@
 #include "../../src/libnativeapi/src/application.cpp"
 #include "../../src/libnativeapi/src/display_manager.cpp"
 #include "../../src/libnativeapi/src/foundation/id_allocator.cpp"
-#include "../../src/libnativeapi/src/foundation/positioning_strategy.cpp"
 #include "../../src/libnativeapi/src/menu.cpp"
+#include "../../src/libnativeapi/src/positioning_strategy.cpp"
 #include "../../src/libnativeapi/src/preferences.cpp"
 #include "../../src/libnativeapi/src/secure_storage.cpp"
 #include "../../src/libnativeapi/src/tray_manager.cpp"

packages/cnativeapi/src/libnativeapi

@@ -7,7 +7,8 @@ export 'src/display_manager.dart';
 export 'src/foundation/event.dart';
 export 'src/foundation/event_emitter.dart';
 export 'src/foundation/geometry.dart';
-export 'src/foundation/positioning_strategy.dart';
+export 'src/placement.dart';
+export 'src/positioning_strategy.dart';
 export 'src/foundation/storage.dart';
 export 'src/image.dart';
 export 'src/menu.dart';

packages/nativeapi/lib/nativeapi.dart

@@ -1,87 +1 @@
 export 'dart:ui' show Offset, Size, Rect;
-
-import 'package:cnativeapi/cnativeapi.dart' show native_placement_t;
-
-/// Placement options for positioning UI elements relative to an anchor.
-///
-/// Placement defines how a UI element (such as a menu or popover) should be
-/// positioned relative to a reference point or rectangle.
-///
-/// Example:
-/// ```dart
-/// // Position menu below the anchor, horizontally centered
-/// menu.open(strategy, Placement.bottom);
-///
-/// // Position menu below the anchor, aligned to the left
-/// menu.open(strategy, Placement.bottomStart);
-///
-/// // Position menu above the anchor, aligned to the right
-/// menu.open(strategy, Placement.topEnd);
-/// ```
-enum Placement {
-  /// Position above the anchor, horizontally centered.
-  top,
-
-  /// Position above the anchor, aligned to the start (left).
-  topStart,
-
-  /// Position above the anchor, aligned to the end (right).
-  topEnd,
-
-  /// Position to the right of the anchor, vertically centered.
-  right,
-
-  /// Position to the right of the anchor, aligned to the start (top).
-  rightStart,
-
-  /// Position to the right of the anchor, aligned to the end (bottom).
-  rightEnd,
-
-  /// Position below the anchor, horizontally centered.
-  bottom,
-
-  /// Position below the anchor, aligned to the start (left).
-  bottomStart,
-
-  /// Position below the anchor, aligned to the end (right).
-  bottomEnd,
-
-  /// Position to the left of the anchor, vertically centered.
-  left,
-
-  /// Position to the left of the anchor, aligned to the start (top).
-  leftStart,
-
-  /// Position to the left of the anchor, aligned to the end (bottom).
-  leftEnd;
-
-  /// Convert this Placement to a native placement enum value.
-  native_placement_t toNative() {
-    switch (this) {
-      case Placement.top:
-        return native_placement_t.NATIVE_PLACEMENT_TOP;
-      case Placement.topStart:
-        return native_placement_t.NATIVE_PLACEMENT_TOP_START;
-      case Placement.topEnd:
-        return native_placement_t.NATIVE_PLACEMENT_TOP_END;
-      case Placement.right:
-        return native_placement_t.NATIVE_PLACEMENT_RIGHT;
-      case Placement.rightStart:
-        return native_placement_t.NATIVE_PLACEMENT_RIGHT_START;
-      case Placement.rightEnd:
-        return native_placement_t.NATIVE_PLACEMENT_RIGHT_END;
-      case Placement.bottom:
-        return native_placement_t.NATIVE_PLACEMENT_BOTTOM;
-      case Placement.bottomStart:
-        return native_placement_t.NATIVE_PLACEMENT_BOTTOM_START;
-      case Placement.bottomEnd:
-        return native_placement_t.NATIVE_PLACEMENT_BOTTOM_END;
-      case Placement.left:
-        return native_placement_t.NATIVE_PLACEMENT_LEFT;
-      case Placement.leftStart:
-        return native_placement_t.NATIVE_PLACEMENT_LEFT_START;
-      case Placement.leftEnd:
-        return native_placement_t.NATIVE_PLACEMENT_LEFT_END;
-    }
-  }
-}

packages/nativeapi/lib/src/foundation/geometry.dart

@@ -3,9 +3,9 @@ import 'dart:ffi';
 import 'package:ffi/ffi.dart' as ffi;
 import 'package:nativeapi/src/foundation/cnativeapi_bindings_mixin.dart';
 import 'package:nativeapi/src/foundation/event_emitter.dart';
-import 'package:nativeapi/src/foundation/geometry.dart';
 import 'package:nativeapi/src/foundation/native_handle_wrapper.dart';
-import 'package:nativeapi/src/foundation/positioning_strategy.dart';
+import 'package:nativeapi/src/placement.dart';
+import 'package:nativeapi/src/positioning_strategy.dart';
 import 'package:nativeapi/src/image.dart';
 import 'package:nativeapi/src/menu_event.dart';
 

packages/nativeapi/lib/src/menu.dart

@@ -0,0 +1,85 @@
+import 'package:cnativeapi/cnativeapi.dart' show native_placement_t;
+
+/// Placement options for positioning UI elements relative to an anchor.
+///
+/// Placement defines how a UI element (such as a menu or popover) should be
+/// positioned relative to a reference point or rectangle.
+///
+/// Example:
+/// ```dart
+/// // Position menu below the anchor, horizontally centered
+/// menu.open(strategy, Placement.bottom);
+///
+/// // Position menu below the anchor, aligned to the left
+/// menu.open(strategy, Placement.bottomStart);
+///
+/// // Position menu above the anchor, aligned to the right
+/// menu.open(strategy, Placement.topEnd);
+/// ```
+enum Placement {
+  /// Position above the anchor, horizontally centered.
+  top,
+
+  /// Position above the anchor, aligned to the start (left).
+  topStart,
+
+  /// Position above the anchor, aligned to the end (right).
+  topEnd,
+
+  /// Position to the right of the anchor, vertically centered.
+  right,
+
+  /// Position to the right of the anchor, aligned to the start (top).
+  rightStart,
+
+  /// Position to the right of the anchor, aligned to the end (bottom).
+  rightEnd,
+
+  /// Position below the anchor, horizontally centered.
+  bottom,
+
+  /// Position below the anchor, aligned to the start (left).
+  bottomStart,
+
+  /// Position below the anchor, aligned to the end (right).
+  bottomEnd,
+
+  /// Position to the left of the anchor, vertically centered.
+  left,
+
+  /// Position to the left of the anchor, aligned to the start (top).
+  leftStart,
+
+  /// Position to the left of the anchor, aligned to the end (bottom).
+  leftEnd;
+
+  /// Convert this Placement to a native placement enum value.
+  native_placement_t toNative() {
+    switch (this) {
+      case Placement.top:
+        return native_placement_t.NATIVE_PLACEMENT_TOP;
+      case Placement.topStart:
+        return native_placement_t.NATIVE_PLACEMENT_TOP_START;
+      case Placement.topEnd:
+        return native_placement_t.NATIVE_PLACEMENT_TOP_END;
+      case Placement.right:
+        return native_placement_t.NATIVE_PLACEMENT_RIGHT;
+      case Placement.rightStart:
+        return native_placement_t.NATIVE_PLACEMENT_RIGHT_START;
+      case Placement.rightEnd:
+        return native_placement_t.NATIVE_PLACEMENT_RIGHT_END;
+      case Placement.bottom:
+        return native_placement_t.NATIVE_PLACEMENT_BOTTOM;
+      case Placement.bottomStart:
+        return native_placement_t.NATIVE_PLACEMENT_BOTTOM_START;
+      case Placement.bottomEnd:
+        return native_placement_t.NATIVE_PLACEMENT_BOTTOM_END;
+      case Placement.left:
+        return native_placement_t.NATIVE_PLACEMENT_LEFT;
+      case Placement.leftStart:
+        return native_placement_t.NATIVE_PLACEMENT_LEFT_START;
+      case Placement.leftEnd:
+        return native_placement_t.NATIVE_PLACEMENT_LEFT_END;
+    }
+  }
+}

packages/nativeapi/lib/src/placement.dart

@@ -3,6 +3,7 @@ import 'dart:ffi';
 import 'package:ffi/ffi.dart' as ffi;
 import 'package:nativeapi/src/foundation/cnativeapi_bindings_mixin.dart';
 import 'package:nativeapi/src/foundation/geometry.dart';
+import 'package:nativeapi/src/window.dart';
 
 /// Type of positioning strategy.
 enum PositioningStrategyType {
@@ -22,7 +23,7 @@ enum PositioningStrategyType {
 /// such as menus, tooltips, or popovers. It supports various positioning modes:
 /// - Absolute: Fixed screen coordinates
 /// - CursorPosition: Current mouse cursor position
-/// - Relative: Position relative to a rectangle
+/// - Relative: Position relative to a rectangle or window
 ///
 /// Example:
 /// ```dart
@@ -35,22 +36,29 @@ enum PositioningStrategyType {
 /// // Position menu relative to a rectangle with offset
 /// final buttonRect = Rect.fromLTWH(10, 10, 100, 30);
 /// menu.open(PositioningStrategy.relative(buttonRect, Offset(0, 10)));
+///
+/// // Position menu relative to a window with offset
+/// final window = WindowManager.instance.create(options);
+/// menu.open(PositioningStrategy.relativeToWindow(window, Offset(0, 10)));
 /// ```
 class PositioningStrategy with CNativeApiBindingsMixin {
   final PositioningStrategyType _type;
   final Offset? _absolutePosition;
   final Rect? _relativeRectangle;
   final Offset? _relativeOffset;
+  final Window? _relativeWindow;
 
   PositioningStrategy._({
     required PositioningStrategyType type,
     Offset? absolutePosition,
     Rect? relativeRectangle,
     Offset? relativeOffset,
+    Window? relativeWindow,
   }) : _type = type,
        _absolutePosition = absolutePosition,
        _relativeRectangle = relativeRectangle,
-       _relativeOffset = relativeOffset;
+       _relativeOffset = relativeOffset,
+       _relativeWindow = relativeWindow;
 
   /// Create a strategy for absolute positioning at fixed coordinates.
   ///
@@ -101,6 +109,34 @@ class PositioningStrategy with CNativeApiBindingsMixin {
     );
   }
 
+  /// Create a strategy for positioning relative to a window.
+  ///
+  /// This method stores a reference to the window and will obtain its bounds
+  /// dynamically when [relativeRectangle] is accessed, ensuring the position
+  /// reflects the window's current state.
+  ///
+  /// Example:
+  /// ```dart
+  /// final window = WindowManager.instance.create(options);
+  /// // Position menu at bottom of window (no offset)
+  /// final strategy = PositioningStrategy.relativeToWindow(window);
+  /// menu.open(strategy);
+  ///
+  /// // Position menu at bottom of window with 10px vertical offset
+  /// final strategy2 = PositioningStrategy.relativeToWindow(window, Offset(0, 10));
+  /// menu.open(strategy2);
+  /// ```
+  factory PositioningStrategy.relativeToWindow(
+    Window window, [
+    Offset offset = Offset.zero,
+  ]) {
+    return PositioningStrategy._(
+      type: PositioningStrategyType.relative,
+      relativeWindow: window,
+      relativeOffset: offset,
+    );
+  }
+
   /// Get the type of this positioning strategy.
   PositioningStrategyType get type => _type;
 
@@ -112,13 +148,25 @@ class PositioningStrategy with CNativeApiBindingsMixin {
   /// Get the relative rectangle (for Relative type).
   ///
   /// Only valid when type == PositioningStrategyType.relative
-  Rect? get relativeRectangle => _relativeRectangle;
+  /// If the strategy was created with a Window, this will return the
+  /// window's current bounds (obtained dynamically).
+  Rect? get relativeRectangle {
+    if (_relativeWindow != null) {
+      return _relativeWindow!.bounds;
+    }
+    return _relativeRectangle;
+  }
 
   /// Get the relative offset point (for Relative type).
   ///
   /// Only valid when type == PositioningStrategyType.relative
   Offset? get relativeOffset => _relativeOffset;
 
+  /// Get the relative window (for Relative type created with Window).
+  ///
+  /// Only valid when type == PositioningStrategyType.relative and strategy was created with a Window
+  Window? get relativeWindow => _relativeWindow;
+
   /// Convert this strategy to a native positioning strategy handle.
   ///
   /// The caller is responsible for freeing the returned handle using
@@ -147,7 +195,7 @@ class PositioningStrategy with CNativeApiBindingsMixin {
         return bindings.native_positioning_strategy_cursor_position();
 
       case PositioningStrategyType.relative:
-        final rect = _relativeRectangle;
+        final rect = relativeRectangle; // This will get window bounds if needed
         if (rect == null) {
           throw StateError(
             'Relative rectangle is required for relative strategy',

…src/foundation/positioning_strategy.dart …iveapi/lib/src/positioning_strategy.dartpackages/nativeapi/lib/src/foundation/positioning_strategy.dart renamed to packages/nativeapi/lib/src/positioning_strategy.dart packages/nativeapi/lib/src/foundation/positioning_strategy.dart renamed to packages/nativeapi/lib/src/positioning_strategy.dart

@@ -1,7 +1,7 @@
 import 'package:flutter/gestures.dart';
 import 'package:flutter/widgets.dart';
-import 'package:nativeapi/src/foundation/geometry.dart' show Placement;
-import 'package:nativeapi/src/foundation/positioning_strategy.dart';
+import 'package:nativeapi/src/placement.dart';
+import 'package:nativeapi/src/positioning_strategy.dart';
 import 'package:nativeapi/src/menu.dart';
 import 'package:nativeapi/src/window.dart';
 import 'package:nativeapi/src/window_manager.dart';
@@ -80,8 +80,8 @@ class _ContextMenuRegionState extends State<ContextMenuRegion> {
 
         // Open the menu at the click position using relative positioning
         widget.menu.open(
-          PositioningStrategy.relative(
-            _activeWindow!.contentBounds,
+          PositioningStrategy.relativeToWindow(
+            _activeWindow!,
             Offset(event.position.dx, event.position.dy),
           ),
           widget.placement,