properly exit dsa_int_validate_pqg

karel-m · karel-m · commit 5e718499420f · 2017-09-14T20:07:32.000+02:00
diff --git a/src/pk/dsa/dsa_verify_key.c b/src/pk/dsa/dsa_verify_key.c
@@ -60,8 +60,7 @@ int dsa_int_validate_pqg(dsa_key *key, int *stat)
    if ( key->qord >= LTC_MDSA_MAX_GROUP || key->qord <= 15 ||
         (unsigned long)key->qord >= mp_unsigned_bin_size(key->p) ||
         (mp_unsigned_bin_size(key->p) - key->qord) >= LTC_MDSA_DELTA ) {
-      err = CRYPT_OK;
-      goto error;
+      return CRYPT_OK;
    }
 
    /* FIPS 186-4 chapter 4.1: 1 < g < p */

Original file line number	Diff line number	Diff line change
`@@ -60,8 +60,7 @@ int dsa_int_validate_pqg(dsa_key key, int stat)`
`60`	`60`	`if ( key->qord >= LTC_MDSA_MAX_GROUP \|\| key->qord <= 15 \|\|`
`61`	`61`	`(unsigned long)key->qord >= mp_unsigned_bin_size(key->p) \|\|`
`62`	`62`	`(mp_unsigned_bin_size(key->p) - key->qord) >= LTC_MDSA_DELTA ) {`
`63`		`- err = CRYPT_OK;`
`64`		`- goto error;`
	`63`	`+ return CRYPT_OK;`
`65`	`64`	`}`
`66`	`65`
`67`	`66`	`/* FIPS 186-4 chapter 4.1: 1 < g < p */`