Merge pull request #1974 from montegoulding/ideperf

[[ PERF ]] Ide performance issues

Author: livecodepanos

Toolset/palettes/message box/behaviors/revmessageboxbehavior.livecodescript

@@ -667,8 +667,8 @@ private command __UpdateIntelligenceDisplay
    else
       local tControl
       put the name of it into tControl
-      set the label of button "Open Stacks" of group "Stacks" of me to tIntelligence & ": " & tControl
-      enable button "Open Stacks" of group "Stacks" of me
+      set the label of button "Open Stacks" of group "Stacks" of card "Single Line" of me to tIntelligence & ": " & tControl
+      enable button "Open Stacks" of group "Stacks" of card "Single Line" of me
    end if
    positionOpenStacksButton
    unlock messages

Toolset/palettes/message box/behaviors/revmessageboxsinglelinecardbehavior.livecodescript

@@ -68,8 +68,8 @@ on layoutCard
    set the rect of field "results" of me to tLeft,(tTop + tHeight),tRight,tBottom
 
    put (tRight - tLeft) into tWidth
-   set the width of graphic "line" to tWidth
-   set the loc of graphic "line" to (tWidth/2),(tTop+tHeight)
+   set the width of graphic "line" of me to tWidth
+   set the loc of graphic "line" of me to (tWidth/2),(tTop+tHeight)
 
    unlock messages
    send "positionOpenStacksButton" to me in 0 milliseconds

Toolset/palettes/message box/behaviors/revmessageboxsinglelinemessagebehavior.livecodescript

@@ -22,8 +22,13 @@ on enterInField
    returnInField
 end enterInField
 
+local sColorizeMsg
+
 on textChanged
-   dispatch "revSEColorizeField" to stack "revSEUtilities" with the long id of me
+   cancel sColorizeMsg
+   get the long id of me
+   send "revSEColorizeField it" to stack "revSEUtilities" in 100 milliseconds
+   put the result into sColorizeMsg
    revDisplayAutoComplete(the text of me)
 end textChanged
 
@@ -78,6 +83,8 @@ command revInitialise
    end if
 end revInitialise
 
+local sColorizeAutocompleteMsg
+
 command revDisplayAutoComplete pString
    lock screen
    local tString
@@ -87,13 +94,20 @@ command revDisplayAutoComplete pString
       put tString into lMatchingHistory
       put the number of lines in lMatchingHistory into lNumMatching
       put 1 into lMatchingIndex
-      put field "message" & char (the number of chars of field "message" +1) to (the number of chars of line 1 of lMatchingHistory) of  line 1 of lMatchingHistory into field "auto complete"
+      get field "message" & char (the number of chars of field "message" +1) to (the number of chars of line 1 of lMatchingHistory) of  line 1 of lMatchingHistory
+      if it is the text of field "auto complete" then
+         unlock screen
+         return empty
+      end if
+      put it into field "auto complete"
       set the hscroll of field "auto complete" to the hscroll of field "message"
    else 
       put empty into field "auto complete"
    end if
-   
-   dispatch "revSEColorizeField" to stack "revSEUtilities" with the long id of field "auto complete"
+   cancel sColorizeAutocompleteMsg
+   get the long id of field "auto complete"
+   send "revSEColorizeField it" to stack "revSEUtilities" in 100 milliseconds
+   put the result into sColorizeAutocompleteMsg
    set the textColor of char 1 to -1 of field "auto complete" to "gray70"
    unlock screen
 end revDisplayAutoComplete

Toolset/palettes/script editor/behaviors/revsecommoneditorbehavior.livecodescript

@@ -1234,7 +1234,7 @@ end getUpdateGutterRequestDetails
 #  The gutter's scroll is updated immediately. Also a message is sent to the gutter to hide its
 #  mutable objects (the breakpoint / compilation error images). These are show again when the update is
 #  actually carried out.
-command updateGutterRequest pOffset, pSelectedLine, pOldLines, pNewLines, pTextChanged, pUpdateCompilationErrors, pForceBreakpointRedraw
+command updateGutterRequest pOffset, pSelectedLine, pOldLines, pNewLines, pTextChanged, pUpdateCompilationErrors, pForceBreakpointRedraw, pNow
    updateGutterMergeRequestDetails pOffset, pSelectedLine, pOldLines, pNewLines, pTextChanged, pUpdateCompilationErrors, pForceBreakpointRedraw
    if sGutterUpdateRequest is not empty then
       cancel sGutterUpdateRequest
@@ -1247,11 +1247,13 @@ command updateGutterRequest pOffset, pSelectedLine, pOldLines, pNewLines, pTextC
    if exists(field "Numbers" of group "Gutter") then
       set the vScroll of field "Numbers" of group "Gutter" to the vScroll of field "Script" of me
    end if
-   # BUGFIX-20140
-   # 2017-JUL-28 bhall2001 Due to blocking nature of scrolling and key presses, don't send in time.
-   # UI effect is Gutter lags behind scrolling of Script Editor   
-   updateGutterDo
-   put the result into sGutterUpdateRequest
+   
+   if pNow then
+      updateGutterDo
+   else
+      send "updateGutterDo" to me in 200 milliseconds
+      put the result into sGutterUpdateRequest
+   end if
 end updateGutterRequest
 
 # update gutter stubs
@@ -1359,8 +1361,6 @@ end selectionChangedByArrowKey
 -- PM-2016-09-22: [[ Bug 15887 ]] Distinguish between "selectionChanged" sent by the engine and \
       -- "selectionChangedByArrowKey pArrowKey"
 on handleSelectionChanged
-   saveLastSelections
-   
    caretUpdate
 end handleSelectionChanged
 
@@ -1394,6 +1394,7 @@ on selectionUpdate
    lock screen
    __CheckHighlights
    __ClearCurrentPlaceholder
+   saveLastSelections
    unlock screen
 end selectionUpdate
 
@@ -2070,7 +2071,7 @@ on scrollBarDrag
    lock screen
    put tVScroll into sVScroll
 
-   updateGutterRequest empty, empty, empty, empty, false, true
+   updateGutterRequest empty, empty, empty, empty, false, true, empty, true
    unlock screen
 end scrollBarDrag