Remove unnecessary changes

Author: gtsiolis

internal/container/start_test.go

@@ -5,7 +5,6 @@ import (
 	"context"
 	"errors"
 	"io"
-	"strings"
 	"testing"
 
 	"github.com/localstack/lstk/internal/log"
@@ -54,37 +53,3 @@ func TestEmitPostStartPointers_WithoutWebApp(t *testing.T) {
 	assert.Contains(t, got, "> Tip:")
 }
 
-func TestServicePortRange_ReturnsExpectedPorts(t *testing.T) {
-	ports := servicePortRange()
-
-	require.Len(t, ports, 51)
-	assert.Equal(t, "443", ports[0].ContainerPort)
-	assert.Equal(t, "443", ports[0].HostPort)
-	assert.Equal(t, "4510", ports[1].ContainerPort)
-	assert.Equal(t, "4510", ports[1].HostPort)
-	assert.Equal(t, "4559", ports[50].ContainerPort)
-	assert.Equal(t, "4559", ports[50].HostPort)
-}
-
-func TestFilterHostEnv(t *testing.T) {
-	tests := []struct {
-		name     string
-		env      string
-		expected bool
-	}{
-		{"CI is included", "CI=true", true},
-		{"LOCALSTACK_DISABLE_EVENTS is included", "LOCALSTACK_DISABLE_EVENTS=1", true},
-		{"LOCALSTACK_HOST is included", "LOCALSTACK_HOST=0.0.0.0", true},
-		{"LOCALSTACK_AUTH_TOKEN is excluded", "LOCALSTACK_AUTH_TOKEN=secret", false},
-		{"PATH is excluded", "PATH=/usr/bin", false},
-		{"HOME is excluded", "HOME=/root", false},
-		{"LOCALSTACK_BUILD_VERSION is included", "LOCALSTACK_BUILD_VERSION=3.0.0", true},
-	}
-
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			got := strings.HasPrefix(tt.env, "CI=") || (strings.HasPrefix(tt.env, "LOCALSTACK_") && !strings.HasPrefix(tt.env, "LOCALSTACK_AUTH_TOKEN="))
-			assert.Equal(t, tt.expected, got)
-		})
-	}
-}

test/integration/start_test.go

@@ -233,15 +233,15 @@ func TestStartCommandPassesCIAndLocalStackEnvVars(t *testing.T) {
 	cleanup()
 	t.Cleanup(cleanup)
 
-	t.Setenv("CI", "true")
-	t.Setenv("LOCALSTACK_DISABLE_EVENTS", "1")
-	t.Setenv("LOCALSTACK_AUTH_TOKEN", "host-token")
-
 	mockServer := createMockLicenseServer(true)
 	defer mockServer.Close()
 
 	ctx := testContext(t)
-	_, stderr, err := runLstk(t, ctx, "", env.With(env.APIEndpoint, mockServer.URL), "start")
+	_, stderr, err := runLstk(t, ctx, "", env.With(env.APIEndpoint, mockServer.URL).
+		With(env.CI, "true").
+		With(env.DisableEvents, "1").
+		With(env.AuthToken, "host-token"),
+		"start")
 	require.NoError(t, err, "lstk start failed: %s", stderr)
 	requireExitCode(t, 0, err)