Stabilize browser suite route readiness

Author: KSemenenko

full-suite-stabilization.plan.md

@@ -251,6 +251,18 @@ Tracked failing tests from the current baseline:
   - move the remaining SPA route-changing interactions onto the shared `ClickAndContinueAsync(..., noWaitAfter: true)` path
   - harden reader timing and reverse-transition assertions against poll jitter while keeping the user-visible behavior contract intact
   - route editor open/theme/split/title flows through the shared route helpers and interaction driver so local and CI follow the same readiness path
+- [x] `Release Pipeline` run `24234983323` fails remotely in `Shell` and `Editor` after commit `ee5f0fb`
+  Symptom:
+  - `Shell` still times out in a small route-transition cluster where the UI remains on `library-page` after import/playback actions instead of completing the intended move into `editor`, `learn`, or `reader`
+  - `Editor` still flakes in local-history flows, with one test timing out after opening `/settings` and another timing out after a raw page reload while the editor is already visibly present
+  Root cause:
+  - several remaining SPA route-changing clicks were still using default Playwright navigation waiting instead of the shared no-wait click contract plus explicit route-ready waits, so CI could stall on scheduled client-side transitions
+  - some return-to-editor paths only waited for `editor-page` instead of full Monaco readiness
+  - `EditorLocalHistoryFlowTests` still bypassed the shared route helpers with raw `GotoAsync("/settings")` and raw `ReloadAsync()`, which made the tests diverge from the rest of the browser harness under slower remote startup
+  Fix path:
+  - move the remaining route-changing shell, reader, and studio clicks onto `UiInteractionDriver.ClickAndContinueAsync(..., noWaitAfter: true)` where the test already owns the post-click readiness contract
+  - upgrade learn/teleprompter/editor return waits to the shared ready helpers so route completion is measured by the real interactive surface, not just the shell frame
+  - route editor local-history settings/reload operations through `ShellRouteDriver.OpenSettingsAsync(...)` and `BrowserRouteDriver.ReloadPageAsync(...)` so local and CI share the same readiness path
 
 ## Ordered Plan
 
@@ -289,6 +301,7 @@ Tracked failing tests from the current baseline:
   - `dotnet build ./PrompterOne.slnx -warnaserror` passed
   - `dotnet test @./tests/dotnet-test-progress.rsp --solution ./PrompterOne.slnx --max-parallel-test-modules 1` passed with `1162/1162` green in `7m 42.943s`
   - post-format verification repeated successfully with `dotnet build ./PrompterOne.slnx -warnaserror` and `dotnet test @./tests/dotnet-test-progress.rsp --solution ./PrompterOne.slnx --max-parallel-test-modules 1`, ending at `1162/1162` green in `7m 35.996s`
+  - latest post-remediation verification repeated successfully with `dotnet format ./PrompterOne.slnx`, `dotnet build ./PrompterOne.slnx -warnaserror`, and `dotnet test @./tests/dotnet-test-progress.rsp --solution ./PrompterOne.slnx --max-parallel-test-modules 1`, ending at `1162/1162` green in `7m 47.418s`
 
 - [ ] Step 5. Publish directly to `main`.
   Actions:
@@ -327,3 +340,9 @@ Tracked failing tests from the current baseline:
   - `dotnet test @./tests/dotnet-test-progress.rsp --project ./tests/PrompterOne.Web.UITests.Reader/PrompterOne.Web.UITests.Reader.csproj` passed with `168/168`
   - `dotnet test @./tests/dotnet-test-progress.rsp --project ./tests/PrompterOne.Web.UITests.Studio/PrompterOne.Web.UITests.Studio.csproj` passed with `38/38`
   - `dotnet test @./tests/dotnet-test-progress.rsp --solution ./PrompterOne.slnx --max-parallel-test-modules 1` passed with `1162/1162` green in `7m 44.199s`
+- [x] Follow-up remediation for remote run `24234983323`
+  Result:
+  - `dotnet format ./PrompterOne.slnx` passed
+  - `dotnet build ./PrompterOne.slnx -warnaserror` passed
+  - `dotnet test @./tests/dotnet-test-progress.rsp --solution ./PrompterOne.slnx --max-parallel-test-modules 1` passed with `1162/1162` green in `7m 47.418s`
+  - `Shell`, `Reader`, `Studio`, and `Editor` all completed green inside that solution-level validation run

tests/PrompterOne.Web.UITests.Editor/Editor/EditorLocalHistoryFlowTests.cs

@@ -1,3 +1,4 @@
+using Microsoft.Playwright;
 using PrompterOne.Shared.Contracts;
 using static Microsoft.Playwright.Assertions;
 
@@ -37,7 +38,11 @@ await UiScenarioArtifacts.CapturePageAsync(
                 BrowserTestConstants.EditorFlow.LocalHistoryScenario,
                 BrowserTestConstants.EditorFlow.LocalHistorySavedStep);
 
-            await page.ReloadAsync();
+            await BrowserRouteDriver.ReloadPageAsync(
+                page,
+                CurrentRoute(page),
+                UiTestIds.Editor.Page,
+                "editor-local-history-reload-saved");
             await EditorMonacoDriver.WaitUntilReadyAsync(page);
             await page.GetByTestId(UiTestIds.Editor.ToolsTab).ClickAsync();
             await Expect(sourceInput).ToHaveValueAsync(secondRevisionText);
@@ -50,7 +55,11 @@ await UiScenarioArtifacts.CapturePageAsync(
                 BrowserTestConstants.EditorFlow.LocalHistoryScenario,
                 BrowserTestConstants.EditorFlow.LocalHistoryRestoredStep);
 
-            await page.ReloadAsync();
+            await BrowserRouteDriver.ReloadPageAsync(
+                page,
+                CurrentRoute(page),
+                UiTestIds.Editor.Page,
+                "editor-local-history-reload-restored");
             await EditorMonacoDriver.WaitUntilReadyAsync(page);
             await page.GetByTestId(UiTestIds.Editor.ToolsTab).ClickAsync();
             await Expect(sourceInput).ToHaveValueAsync(firstRevisionText);
@@ -70,7 +79,7 @@ await EditorIsolatedDraftDriver.CreateSeededDraftAsync(
             var sourceInput = EditorMonacoDriver.SourceInput(page);
             var originalText = await sourceInput.InputValueAsync();
 
-            await page.GotoAsync(BrowserTestConstants.Routes.Settings);
+            await ShellRouteDriver.OpenSettingsAsync(page, "editor-local-history-settings-disable");
             await page.GetByTestId(UiTestIds.Settings.NavFiles).ClickAsync();
             await Expect(page.GetByTestId(UiTestIds.Settings.FilesPanel)).ToBeVisibleAsync();
             await page.GetByTestId(UiTestIds.Settings.FileAutoSave).ClickAsync();
@@ -91,11 +100,15 @@ await UiScenarioArtifacts.CapturePageAsync(
                 BrowserTestConstants.EditorFlow.LocalHistoryAutosaveScenario,
                 BrowserTestConstants.EditorFlow.LocalHistoryAutosaveDisabledStep);
 
-            await page.ReloadAsync();
+            await BrowserRouteDriver.ReloadPageAsync(
+                page,
+                CurrentRoute(page),
+                UiTestIds.Editor.Page,
+                "editor-local-history-reload-autosave-disabled");
             await EditorMonacoDriver.WaitUntilReadyAsync(page);
             await Expect(sourceInput).ToHaveValueAsync(originalText);
 
-            await page.GotoAsync(BrowserTestConstants.Routes.Settings);
+            await ShellRouteDriver.OpenSettingsAsync(page, "editor-local-history-settings-enable");
             await page.GetByTestId(UiTestIds.Settings.NavFiles).ClickAsync();
             await page.GetByTestId(UiTestIds.Settings.FileAutoSave).ClickAsync();
             await Expect(page.GetByTestId(UiTestIds.Settings.FileAutoSave))
@@ -119,8 +132,15 @@ await UiScenarioArtifacts.CapturePageAsync(
                 BrowserTestConstants.EditorFlow.LocalHistoryAutosaveScenario,
                 BrowserTestConstants.EditorFlow.LocalHistoryAutosaveEnabledStep);
 
-            await page.ReloadAsync();
+            await BrowserRouteDriver.ReloadPageAsync(
+                page,
+                CurrentRoute(page),
+                UiTestIds.Editor.Page,
+                "editor-local-history-reload-autosave-enabled");
             await EditorMonacoDriver.WaitUntilReadyAsync(page);
             await Expect(sourceInput).ToHaveValueAsync(resavedText);
         });
+
+    private static string CurrentRoute(IPage page) =>
+        new Uri(page.Url).PathAndQuery;
 }

tests/PrompterOne.Web.UITests.Reader/Learn/EditorLearnScreenFlowTests.cs

@@ -35,9 +35,10 @@ await Expect(page.GetByTestId(UiTestIds.Editor.SegmentNavigation(2))).ToHaveAttr
             await Expect(page.GetByTestId(UiTestIds.Editor.SourceHighlight)).ToContainTextAsync("Benefits Block");
 
             await Expect(page.GetByTestId(UiTestIds.Header.EditorLearn)).ToBeVisibleAsync();
-            await page.GetByTestId(UiTestIds.Header.EditorLearn).ClickAsync();
-            await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.LearnDemo);
-            await Expect(page.GetByTestId(UiTestIds.Learn.Page)).ToBeVisibleAsync(new() { Timeout = BrowserTestConstants.Timing.ExtendedVisibleTimeoutMs });
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.EditorLearn),
+                noWaitAfter: true);
+            await PlaybackRouteDriver.WaitForLearnReadyAsync(page, BrowserTestConstants.Routes.LearnDemo);
 
             await ReaderRouteDriver.OpenLearnAsync(page, BrowserTestConstants.Routes.LearnDemo);
             await Expect(page.GetByTestId(UiTestIds.Learn.Page)).ToBeVisibleAsync(new() { Timeout = BrowserTestConstants.Timing.ExtendedVisibleTimeoutMs });

tests/PrompterOne.Web.UITests.Shell/AppShell/HeaderPlaybackLaunchFlowTests.cs

@@ -20,43 +20,49 @@ await page.SetViewportSizeAsync(
             await ShellRouteDriver.OpenLibraryAsync(page);
 
             await UiInteractionDriver.ClickAndContinueAsync(
-                page.GetByTestId(UiTestIds.Library.CardLearn(BrowserTestConstants.Scripts.QuantumId)));
-            await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.LearnQuantum);
-            await Expect(page.GetByTestId(UiTestIds.Learn.Page)).ToBeVisibleAsync();
+                page.GetByTestId(UiTestIds.Library.CardLearn(BrowserTestConstants.Scripts.QuantumId)),
+                noWaitAfter: true);
+            await PlaybackRouteDriver.WaitForLearnReadyAsync(page, BrowserTestConstants.Routes.LearnQuantum);
             await Expect(page.GetByTestId(UiTestIds.Header.Title))
                 .ToHaveTextAsync(BrowserTestConstants.Scripts.QuantumTitle);
             await UiScenarioArtifacts.CapturePageAsync(
                 page,
                 BrowserTestConstants.AppShellFlow.PlaybackLaunchScenario,
                 BrowserTestConstants.AppShellFlow.LearnLaunchStep);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Header.Back));
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.Back),
+                noWaitAfter: true);
             await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.EditorQuantum);
-            await Expect(page.GetByTestId(UiTestIds.Editor.Page)).ToBeVisibleAsync();
+            await EditorMonacoDriver.WaitUntilReadyAsync(page);
             await Expect(page.GetByTestId(UiTestIds.Header.Title))
                 .ToHaveTextAsync(BrowserTestConstants.Scripts.QuantumTitle);
             await UiScenarioArtifacts.CapturePageAsync(
                 page,
                 BrowserTestConstants.AppShellFlow.PlaybackLaunchScenario,
                 BrowserTestConstants.AppShellFlow.LearnBackStep);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Header.Home));
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.Home),
+                noWaitAfter: true);
             await ShellRouteDriver.WaitForLibraryReadyAsync(page, AppRoutes.Library);
 
             await UiInteractionDriver.ClickAndContinueAsync(
-                page.GetByTestId(UiTestIds.Library.CardRead(BrowserTestConstants.Scripts.QuantumId)));
-            await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.TeleprompterQuantum);
-            await Expect(page.GetByTestId(UiTestIds.Teleprompter.Page)).ToBeVisibleAsync();
+                page.GetByTestId(UiTestIds.Library.CardRead(BrowserTestConstants.Scripts.QuantumId)),
+                noWaitAfter: true);
+            await PlaybackRouteDriver.WaitForTeleprompterReadyAsync(page, BrowserTestConstants.Routes.TeleprompterQuantum);
             await Expect(page.GetByTestId(UiTestIds.Header.Title))
                 .ToHaveTextAsync(BrowserTestConstants.Scripts.QuantumTitle);
             await UiScenarioArtifacts.CapturePageAsync(
                 page,
                 BrowserTestConstants.AppShellFlow.PlaybackLaunchScenario,
                 BrowserTestConstants.AppShellFlow.TeleprompterLaunchStep);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Header.Back));
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.Back),
+                noWaitAfter: true);
             await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.EditorQuantum);
-            await Expect(page.GetByTestId(UiTestIds.Editor.Page)).ToBeVisibleAsync();
+            await EditorMonacoDriver.WaitUntilReadyAsync(page);
             await Expect(page.GetByTestId(UiTestIds.Header.Title))
                 .ToHaveTextAsync(BrowserTestConstants.Scripts.QuantumTitle);
             await UiScenarioArtifacts.CapturePageAsync(
@@ -77,7 +83,9 @@ await page.SetViewportSizeAsync(
 
             await ShellRouteDriver.OpenGoLiveRouteAsync(page, BrowserTestConstants.Routes.GoLiveDemo);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.GoLive.OpenSettings));
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.GoLive.OpenSettings),
+                noWaitAfter: true);
             await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.Settings);
             await Expect(page.GetByTestId(UiTestIds.Settings.Page)).ToBeVisibleAsync();
             await Expect(page.GetByTestId(UiTestIds.Header.Title))
@@ -87,7 +95,9 @@ await UiScenarioArtifacts.CapturePageAsync(
                 BrowserTestConstants.AppShellFlow.SettingsOriginScenario,
                 BrowserTestConstants.AppShellFlow.SettingsLaunchStep);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Header.Back));
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.Back),
+                noWaitAfter: true);
             await ShellRouteDriver.WaitForGoLiveReadyAsync(page, BrowserTestConstants.Routes.GoLiveDemo);
             await UiScenarioArtifacts.CapturePageAsync(
                 page,

tests/PrompterOne.Web.UITests.Shell/AppShell/NavigationFlowTests.cs

@@ -21,13 +21,17 @@ public async Task ShellHeader_OpensGoLive_FromLibraryAndSettings()
         {
             await ShellRouteDriver.OpenLibraryAsync(page);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Header.GoLive));
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.GoLive),
+                noWaitAfter: true);
             await BrowserRouteDriver.WaitForRouteAsync(page, AppRoutes.GoLive);
             await Expect(page.GetByTestId(UiTestIds.GoLive.Page)).ToBeVisibleAsync();
 
             await ShellRouteDriver.OpenSettingsAsync(page);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Header.GoLive));
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.GoLive),
+                noWaitAfter: true);
             await BrowserRouteDriver.WaitForRouteAsync(page, AppRoutes.GoLive);
             await Expect(page.GetByTestId(UiTestIds.GoLive.Page)).ToBeVisibleAsync();
         }
@@ -52,9 +56,10 @@ await EditorRouteDriver.OpenReadyAsync(
 
             await page.EvaluateAsync("value => window.__prompterSpaNonce = value", nonce);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Header.EditorLearn));
-            await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.LearnQuantum);
-            await Expect(page.GetByTestId(UiTestIds.Learn.Page)).ToBeVisibleAsync();
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.EditorLearn),
+                noWaitAfter: true);
+            await PlaybackRouteDriver.WaitForLearnReadyAsync(page, BrowserTestConstants.Routes.LearnQuantum);
             await Assert.That(await page.EvaluateAsync<string>("() => window.__prompterSpaNonce")).IsEqualTo(nonce);
 
             await EditorRouteDriver.OpenReadyAsync(
@@ -63,14 +68,17 @@ await EditorRouteDriver.OpenReadyAsync(
                 $"{nameof(ScreenNavigation_UsesSpaRoutingWithoutReloadingBrowserContext)}-return");
             await page.EvaluateAsync("value => window.__prompterSpaNonce = value", nonce);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Header.EditorRead));
-            await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.TeleprompterQuantum);
-            await Expect(page.GetByTestId(UiTestIds.Teleprompter.Page)).ToBeVisibleAsync();
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Header.EditorRead),
+                noWaitAfter: true);
+            await PlaybackRouteDriver.WaitForTeleprompterReadyAsync(page, BrowserTestConstants.Routes.TeleprompterQuantum);
             await Assert.That(await page.EvaluateAsync<string>("() => window.__prompterSpaNonce")).IsEqualTo(nonce);
 
-            await UiInteractionDriver.ClickAndContinueAsync(page.GetByTestId(UiTestIds.Teleprompter.Back));
+            await UiInteractionDriver.ClickAndContinueAsync(
+                page.GetByTestId(UiTestIds.Teleprompter.Back),
+                noWaitAfter: true);
             await BrowserRouteDriver.WaitForRouteAsync(page, BrowserTestConstants.Routes.EditorQuantum);
-            await Expect(page.GetByTestId(UiTestIds.Editor.Page)).ToBeVisibleAsync();
+            await EditorMonacoDriver.WaitUntilReadyAsync(page);
             await Assert.That(await page.EvaluateAsync<string>("() => window.__prompterSpaNonce")).IsEqualTo(nonce);
         }
         finally