Skip to content

Commit bde102c

Browse files
committed
Remove editor browser test parallel locks
1 parent 07435ac commit bde102c

13 files changed

Lines changed: 1 addition & 12 deletions

AGENTS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ Rule format:
122122
- Selector-contract remediation requests must be handled repo-wide across all relevant test files (`Web.Tests` and `Web.UITests`), not as partial per-file cleanups.
123123
- Browser and editor acceptance tests must be stable against seeded demo content, user-entered text, and import filename variations: assert invariant UI behavior, use shared fixtures/constants, and wait on explicit ready or completion signals instead of incidental page titles, transient text, or race-prone intermediate chrome.
124124
- Editor browser tests that mutate document content must create or import an isolated script for that scenario and edit that script only; do not point multiple mutating tests at the same seeded library script or shared draft state.
125+
- Do not keep `NotInParallel` on browser-test classes that already use isolated browser contexts and isolated writable scripts; parallel locks need a concrete documented shared-resource conflict, not legacy caution.
125126
- When the user asks to stabilize failing tests or gather a red baseline, prioritize reproducing the failures, capturing the failing test list, and fixing the suites before spending time on git history, commit hygiene, or other bookkeeping.
126127
- Repo-wide quality audits and agent-generated review handoff artifacts must be written as root-level task files so other coding agents can pick them up quickly; do not bury those temporary audit results under `docs/` unless the task is explicitly about durable product documentation.
127128
- Repo-wide cleanup and review passes must explicitly inventory forbidden implementation string literals, `MarkupString` or raw-HTML UI composition, duplicated JS/CSS patterns, architecture-boundary drift, and `foreach`-driven test scenarios that should become isolated TUnit cases.

tests/PrompterOne.Web.UITests.Editor/Editor/EditorAiScrollStabilityTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
namespace PrompterOne.Web.UITests;
77

88
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
9-
[NotInParallel(nameof(EditorAiScrollStabilityTests))]
109
public sealed class EditorAiScrollStabilityTests(StandaloneAppFixture fixture)
1110
{
1211
private readonly StandaloneAppFixture _fixture = fixture;

tests/PrompterOne.Web.UITests.Editor/Editor/EditorFloatingToolbarLayoutTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ namespace PrompterOne.Web.UITests;
77
[System.Obsolete]
88

99
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
10-
[NotInParallel(nameof(EditorFloatingToolbarLayoutTests))]
1110
public sealed class EditorFloatingToolbarLayoutTests(StandaloneAppFixture fixture)
1211
{
1312
private readonly record struct LayoutBounds(double Y, double Height);

tests/PrompterOne.Web.UITests.Editor/Editor/EditorInteractionTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ namespace PrompterOne.Web.UITests;
77
[System.Obsolete]
88

99
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
10-
[NotInParallel(nameof(EditorInteractionTests))]
1110
public sealed partial class EditorInteractionTests(StandaloneAppFixture fixture)
1211
{
1312
private readonly StandaloneAppFixture _fixture = fixture;

tests/PrompterOne.Web.UITests.Editor/Editor/EditorMonacoAssistanceFlowTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ namespace PrompterOne.Web.UITests;
66
[System.Obsolete]
77

88
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
9-
[NotInParallel(nameof(EditorMonacoAssistanceFlowTests))]
109
public sealed class EditorMonacoAssistanceFlowTests(StandaloneAppFixture fixture)
1110
{
1211
private const int TitleLineNumber = 1;

tests/PrompterOne.Web.UITests.Editor/Editor/EditorMonacoAssistanceRegressionTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ namespace PrompterOne.Web.UITests;
55
[System.Obsolete]
66

77
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
8-
[NotInParallel(nameof(EditorMonacoAssistanceRegressionTests))]
98
public sealed class EditorMonacoAssistanceRegressionTests(StandaloneAppFixture fixture)
109
{
1110
private const int TitleLineNumber = 1;

tests/PrompterOne.Web.UITests.Editor/Editor/EditorSelectionRenderRegressionTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ namespace PrompterOne.Web.UITests;
66
[System.Obsolete]
77

88
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
9-
[NotInParallel(nameof(EditorSelectionRenderRegressionTests))]
109
public sealed class EditorSelectionRenderRegressionTests(StandaloneAppFixture fixture) : AppUiTestBase(fixture)
1110
{
1211
[Test]

tests/PrompterOne.Web.UITests.Editor/Editor/EditorToolbarCoverageTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ namespace PrompterOne.Web.UITests;
88
[System.Obsolete]
99

1010
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
11-
[NotInParallel(nameof(EditorToolbarCoverageTests))]
1211
public sealed class EditorToolbarCoverageTests(StandaloneAppFixture fixture)
1312
{
1413
private readonly StandaloneAppFixture _fixture = fixture;

tests/PrompterOne.Web.UITests.Editor/Editor/EditorToolbarDropdownPaintTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ namespace PrompterOne.Web.UITests;
77
[System.Obsolete]
88

99
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
10-
[NotInParallel(nameof(EditorToolbarDropdownPaintTests))]
1110
public sealed class EditorToolbarDropdownPaintTests(StandaloneAppFixture fixture)
1211
: AppUiTestBase(fixture)
1312
{

tests/PrompterOne.Web.UITests.Editor/Editor/EditorToolbarSemanticVisualTests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ namespace PrompterOne.Web.UITests;
77
[System.Obsolete]
88

99
[ClassDataSource<StandaloneAppFixture>(Shared = SharedType.PerClass)]
10-
[NotInParallel(nameof(EditorToolbarSemanticVisualTests))]
1110
public sealed class EditorToolbarSemanticVisualTests(StandaloneAppFixture fixture)
1211
{
1312
private readonly StandaloneAppFixture _fixture = fixture;

0 commit comments

Comments
 (0)