Merge pull request #13 from managed-code-hub/tests-review

Tests review

Author: vitalik23

ManagedCode.Storage.Azure/AzureStorage.cs

@@ -227,9 +227,9 @@ public async Task UploadAsync(BlobMetadata blobMetadata, byte[] data, Cancellati
 
     public async Task<string> UploadAsync(string content, CancellationToken cancellationToken = default)
     {
-        string fileName = Guid.NewGuid().ToString("N").ToLowerInvariant();
+        string fileName = $"{Guid.NewGuid().ToString("N").ToLowerInvariant()}.txt";
 
-        var blobClient = _blobContainerClient.GetBlobClient($"{fileName}.txt");
+        var blobClient = _blobContainerClient.GetBlobClient(fileName);
         await blobClient.UploadAsync(BinaryData.FromString(content), cancellationToken);
 
         return fileName;

ManagedCode.Storage.Core/LocalFile.cs

@@ -130,12 +130,12 @@ public void Close()
         }
     }
 
-    public static async Task<LocalFile> FromStream(Stream stream)
+    public static async Task<LocalFile> FromStreamAsync(Stream stream)
     {
         var file = new LocalFile();
         await stream.CopyToAsync(file.FileStream);
-        await file.DisposeAsync();
-        file.Close();
+        file.FileStream.Dispose();
+
         return file;
     }
 }

ManagedCode.Storage.Tests/Azure/AzureStorageTests.cs

@@ -32,8 +32,8 @@ protected override ServiceProvider ConfigureServices()
         {
             Container = "managed-code-bucket",
             ConnectionString =
-            "DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://localhost:10000/devstoreaccount1;QueueEndpoint=http://localhost:10001/devstoreaccount1;TableEndpoint=http://localhost:10002/devstoreaccount1;",
-        });
+                "DefaultEndpointsProtocol=http;AccountName=devstoreaccount1;AccountKey=Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==;BlobEndpoint=http://localhost:10000/devstoreaccount1;QueueEndpoint=http://localhost:10001/devstoreaccount1;TableEndpoint=http://localhost:10002/devstoreaccount1;",
+            });
         return services.BuildServiceProvider();
     }