[sdk-base] add default parameters to coordinate conversion functions (#491)

Author: tobrun

sdk-base/src/main/java/com/mapbox/maps/plugin/delegates/MapCameraManagerDelegate.kt

@@ -28,9 +28,9 @@ interface MapCameraManagerDelegate {
    */
   fun cameraForCoordinateBounds(
     bounds: CoordinateBounds,
-    padding: EdgeInsets,
-    bearing: Double?,
-    pitch: Double?
+    padding: EdgeInsets = EdgeInsets(0.0, 0.0, 0.0, 0.0),
+    bearing: Double? = null,
+    pitch: Double? = null
   ): CameraOptions
 
   /**
@@ -45,9 +45,9 @@ interface MapCameraManagerDelegate {
    */
   fun cameraForCoordinates(
     coordinates: List<Point>,
-    padding: EdgeInsets,
-    bearing: Double?,
-    pitch: Double?
+    padding: EdgeInsets = EdgeInsets(0.0, 0.0, 0.0, 0.0),
+    bearing: Double? = null,
+    pitch: Double? = null
   ): CameraOptions
 
   /**
@@ -83,9 +83,9 @@ interface MapCameraManagerDelegate {
    */
   fun cameraForGeometry(
     geometry: Geometry,
-    padding: EdgeInsets,
-    bearing: Double?,
-    pitch: Double?
+    padding: EdgeInsets = EdgeInsets(0.0, 0.0, 0.0, 0.0),
+    bearing: Double? = null,
+    pitch: Double? = null
   ): CameraOptions
 
   /**

sdk/src/test/java/com/mapbox/maps/MapboxMapTest.kt

@@ -457,6 +457,56 @@ class MapboxMapTest {
     verify { nativeMap.cameraForCoordinateBounds(bounds, edgeInsets, 0.0, 1.0) }
   }
 
+  @Test
+  fun cameraForCoordinateBoundsOverload() {
+    val bounds = mockk<CoordinateBounds>()
+    mapboxMap.cameraForCoordinateBounds(bounds)
+    verify {
+      nativeMap.cameraForCoordinateBounds(
+        bounds,
+        EdgeInsets(0.0, 0.0, 0.0, 0.0),
+        null,
+        null
+      )
+    }
+  }
+
+  @Test
+  fun cameraForCoordinateBoundsOverloadPadding() {
+    val bounds = mockk<CoordinateBounds>()
+    val padding = EdgeInsets(1.1, 1.3, 1.4, 1.2)
+    mapboxMap.cameraForCoordinateBounds(bounds, padding)
+    verify { nativeMap.cameraForCoordinateBounds(bounds, padding, null, null) }
+  }
+
+  @Test
+  fun cameraForCoordinateBoundsOverloadBearing() {
+    val bounds = mockk<CoordinateBounds>()
+    mapboxMap.cameraForCoordinateBounds(bounds, bearing = 2.0)
+    verify {
+      nativeMap.cameraForCoordinateBounds(
+        bounds,
+        EdgeInsets(0.0, 0.0, 0.0, 0.0),
+        2.0,
+        null
+      )
+    }
+  }
+
+  @Test
+  fun cameraForCoordinateBoundsOverloadPitch() {
+    val bounds = mockk<CoordinateBounds>()
+    mapboxMap.cameraForCoordinateBounds(bounds, pitch = 2.0)
+    verify {
+      nativeMap.cameraForCoordinateBounds(
+        bounds,
+        EdgeInsets(0.0, 0.0, 0.0, 0.0),
+        null,
+        2.0
+      )
+    }
+  }
+
   @Test
   fun coordinateBoundsForCamera() {
     val cameraOptions = mockk<CameraOptions>()
@@ -495,6 +545,27 @@ class MapboxMapTest {
     verify { nativeMap.cameraForCoordinates(points, edgeInsets, 0.0, 1.0) }
   }
 
+  @Test
+  fun cameraForCoordinatesOverload() {
+    val points = mockk<List<Point>>()
+    mapboxMap.cameraForCoordinates(points)
+    verify { nativeMap.cameraForCoordinates(points, EdgeInsets(0.0, 0.0, 0.0, 0.0), null, null) }
+  }
+
+  @Test
+  fun cameraForCoordinatesOverloadBearing() {
+    val points = mockk<List<Point>>()
+    mapboxMap.cameraForCoordinates(points, bearing = 2.0)
+    verify { nativeMap.cameraForCoordinates(points, EdgeInsets(0.0, 0.0, 0.0, 0.0), 2.0, null) }
+  }
+
+  @Test
+  fun cameraForCoordinatesOverloadPitch() {
+    val points = mockk<List<Point>>()
+    mapboxMap.cameraForCoordinates(points, pitch = 2.0)
+    verify { nativeMap.cameraForCoordinates(points, EdgeInsets(0.0, 0.0, 0.0, 0.0), null, 2.0) }
+  }
+
   @Test
   fun cameraForGeometry() {
     val point = mockk<Point>()
@@ -503,6 +574,27 @@ class MapboxMapTest {
     verify { nativeMap.cameraForGeometry(point, edgeInsets, 0.0, 1.0) }
   }
 
+  @Test
+  fun cameraForGeometryOverload() {
+    val point = mockk<Point>()
+    mapboxMap.cameraForGeometry(point)
+    verify { nativeMap.cameraForGeometry(point, EdgeInsets(0.0, 0.0, 0.0, 0.0), null, null) }
+  }
+
+  @Test
+  fun cameraForGeometryOverloadBearing() {
+    val point = mockk<Point>()
+    mapboxMap.cameraForGeometry(point, bearing = 2.0)
+    verify { nativeMap.cameraForGeometry(point, EdgeInsets(0.0, 0.0, 0.0, 0.0), 2.0, null) }
+  }
+
+  @Test
+  fun cameraForGeometryOverloadPitch() {
+    val point = mockk<Point>()
+    mapboxMap.cameraForGeometry(point, pitch = 2.0)
+    verify { nativeMap.cameraForGeometry(point, EdgeInsets(0.0, 0.0, 0.0, 0.0), null, 2.0) }
+  }
+
   @Test
   fun pixelForCoordinate() {
     val point = mockk<Point>()