Making the default sources and map in native go, remvoing unreferenced methods and addressing review comments

Signed-off-by: Manish Ranjan Mahanta <mmahanta@microsoft.com>

Author: Manish Ranjan Mahanta

internal/gcs-sidecar/handlers.go

@@ -530,7 +530,7 @@ func (b *Bridge) modifyServiceSettings(req *request) (err error) {
 					settings.Settings = allowedLogSources
 				}
 			default:
-				log.G(req.ctx).Tracef("modifyServiceSettings for LogForwardService with RPCType: %v, skipping policy enforcement", settings.RPCType)
+				log.G(req.ctx).Warningf("modifyServiceSettings for LogForwardService with RPCType: %v, skipping policy enforcement", settings.RPCType)
 			}
 			modifyRequest.Settings = settings
 			buf, err := json.Marshal(modifyRequest)
@@ -544,10 +544,10 @@ func (b *Bridge) modifyServiceSettings(req *request) (err error) {
 			newRequest.message = buf
 			req = &newRequest
 		} else {
-			log.G(req.ctx).Tracef("modifyServiceSettings for LogForwardService with empty settings, skipping policy enforcement")
+			log.G(req.ctx).Warningf("modifyServiceSettings for LogForwardService with empty settings, skipping policy enforcement")
 		}
 	default:
-		log.G(req.ctx).Tracef("modifyServiceSettings with PropertyType: %v, skipping policy enforcement", modifyRequest.PropertyType)
+		log.G(req.ctx).Warningf("modifyServiceSettings with PropertyType: %v, skipping policy enforcement", modifyRequest.PropertyType)
 	}
 	b.forwardRequestToGcs(req)
 	return nil

internal/vm/vmutils/etw/default-logsources.json

@@ -0,0 +1,66 @@
+package etw
+
+// defaultLogSourcesInfo is the native Go representation of the default-logsources.json file.
+var defaultLogSourcesInfo = LogSourcesInfo{
+	LogConfig: LogConfig{
+		Sources: []Source{
+			{
+				Type: "ETW",
+				Providers: []EtwProvider{
+					{
+						ProviderName: "microsoft.windows.hyperv.compute",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft-windows-guest-network-service",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.filesystem.cimfs",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.filesystem.unionfs",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft-windows-bitlocker-driver",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft-windows-bitlocker-api",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.security.keyguard",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.security.keyguard.attestation.verify",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.containers.setup",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.containers.storage",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.containers.library",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.containers.dynamicimage",
+						Level:        "Information",
+					},
+					{
+						ProviderName: "microsoft.windows.logforwardservice.provider",
+						Level:        "Information",
+					},
+				},
+			},
+		},
+	},
+}

internal/vm/vmutils/etw/default-sources.go

@@ -0,0 +1,75 @@
+package etw
+
+import (
+	"strings"
+	"testing"
+)
+
+func TestDefaultSources_ETWProvidersExistInETWMap(t *testing.T) {
+	if len(etwNameToGuidMap) == 0 {
+		t.Fatal("etwNameToGuidMap is empty")
+	}
+
+	for si, src := range defaultLogSourcesInfo.LogConfig.Sources {
+		// Only ETW sources should be validated against etwNameToGuidMap.
+		if !strings.EqualFold(src.Type, "ETW") {
+			continue
+		}
+
+		for pi, p := range src.Providers {
+			if p.ProviderName == "" {
+				t.Fatalf("empty ProviderName at source index %d provider index %d", si, pi)
+			}
+
+			key := strings.ToLower(p.ProviderName)
+			if _, ok := etwNameToGuidMap[key]; !ok {
+				t.Fatalf(
+					"provider not found in etwNameToGuidMap: source index=%d provider index=%d provider=%q lookup key=%q",
+					si, pi, p.ProviderName, key,
+				)
+			}
+		}
+	}
+}
+func TestDefaultSources_NoDuplicateProviders(t *testing.T) {
+	providerSet := make(map[string]struct{})
+
+	for si, src := range defaultLogSourcesInfo.LogConfig.Sources {
+		if !strings.EqualFold(src.Type, "ETW") {
+			continue
+		}
+		for pi, p := range src.Providers {
+			key := strings.ToLower(p.ProviderName)
+			if _, exists := providerSet[key]; exists {
+				t.Fatalf("duplicate provider found: source index=%d provider index=%d provider=%q", si, pi, p.ProviderName)
+			}
+			providerSet[key] = struct{}{}
+		}
+	}
+}
+
+func TestDefaultSources_NoProviderGUIDProvided(t *testing.T) {
+	for si, src := range defaultLogSourcesInfo.LogConfig.Sources {
+		if !strings.EqualFold(src.Type, "ETW") {
+			continue
+		}
+		for pi, p := range src.Providers {
+			if p.ProviderGUID != "" {
+				t.Fatalf("ProviderGUID should not be provided: source index=%d provider index=%d provider=%q guid=%q", si, pi, p.ProviderName, p.ProviderGUID)
+			}
+		}
+	}
+}
+
+func TestDefaultSources_AtLeastOneETWSource(t *testing.T) {
+	found := false
+	for _, src := range defaultLogSourcesInfo.LogConfig.Sources {
+		if strings.EqualFold(src.Type, "ETW") {
+			found = true
+			break
+		}
+	}
+	if !found {
+		t.Fatal("no ETW source found in defaultLogSourcesInfo")
+	}
+}