license.txt

[Reissner]

you describe license.txt to be added in the root folder, but not within the toolbox folder
which is what it deployed.
On the other hand, typically, when installing a mltbx file, the user is asked about whether (s)he accepts the license agreement.
This is only possible if license.txt is deployed, i.e. if it is within the toolbox folder.
So I see some inconsistency.

Also in your text you mention differences in the versions.
In fact, the prj file really depends on that .
It would be important to describe the process of packaging.
How to include the license... but this is only one aspect.
there are much more.

[michellehirsch]

@rpurser47 I think I raised this same flag a while back, that it's important to include a license.txt in the distributed toolbox. Since the recommendation is to release the toolbox folder directly, I think users will need to keep a second copy of their license.txt inside toolbox. Do you agree, or are there better approaches that could work with the simplified release process?

[Reissner]

Happy to hear, that you share the conviction that it is important.
Currently, your suggestion is to keep the license.txt in the root folder, but it should be in toolbox/.
This is to allow the user to read it by need.
I dont know whether there is a generic way to do so.
My second problem is, that even if I pace the license.txt in the toolbox folder,
I cannot figure out how to force MATLAB to ask for acceptance when trying to install.
If i install programmatically via matlab.addons.toolbox.installToolbox('xxx.mltbx',acceptLicense),
it never asks also.
What do I wrong?
I think the documentation is not complete at this place.

I must tell you that I have R2018b but still need a solution.
I can figure out, that in more recent version everything is ok.

[michellehirsch]

This discussion is also happening in issue #29 (sorry, I couldn't find that on Monday). Let's keep it there so it's on one thread. Feel free to move your comments there, then I'll close this issue.