Fix parsing webhook events for issues closed as duplicate

Author: tulir

github/api/types.py

@@ -330,6 +330,7 @@ class IssueState(SerializableEnum):
 class IssueStateReason(SerializableEnum):
     COMPLETED = "completed"
     NOT_PLANNED = "not_planned"
+    DUPLICATE = "duplicate"
 
 
 @dataclass

github/api/webhook.py

@@ -18,6 +18,7 @@
 import hashlib
 import hmac
 import json
+import logging
 
 from aiohttp import web
 from attr import dataclass
@@ -57,13 +58,19 @@ class GitHubWebhookReceiver:
     handler: "HandlerFunc"
     secrets: "WebhookManager"
     global_secret: Optional[str]
+    log: logging.Logger
 
     def __init__(
-        self, handler: "HandlerFunc", secrets: "WebhookManager", global_secret: Optional[str]
+        self,
+        handler: "HandlerFunc",
+        secrets: "WebhookManager",
+        global_secret: Optional[str],
+        log: logging.Logger,
     ) -> None:
         self.handler = handler
         self.secrets = secrets
         self.global_secret = global_secret
+        self.log = log
 
     @web_handler.post("/webhook")
     async def handle_global(self, request: web.Request) -> web.Response:
@@ -116,6 +123,7 @@ async def _handle(self, request: web.Request, webhook_info: "WebhookInfo") -> we
         try:
             event = type_class.deserialize(data)
         except SerializerError:
+            self.log.exception("Failed to parse webhook event")
             return web.Response(status=500, text="Failed to parse event content")
         resp = await self.handler(event_type, event, delivery_id, webhook_info)
         if not isinstance(resp, web.Response):

github/bot.py

@@ -58,6 +58,7 @@ async def start(self) -> None:
             handler=self.webhook_handler,
             secrets=self.webhook_manager,
             global_secret=self.config["global_webhook_secret"],
+            log=self.log.getChild("webhook_receiver"),
         )
         self.commands = Commands(bot=self)