Skip to content

Commit 07c4816

Browse files
refactor: Remove MSVC-specific test cases for conversion casts to streamline test suite
1 parent be07d3f commit 07c4816

2 files changed

Lines changed: 0 additions & 8 deletions

File tree

tests/basic/conversion/underlying/test_builtin_casts.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,6 @@ import mcpplibs.primitives.underlying;
88

99
using namespace mcpplibs::primitives;
1010

11-
#if defined(_MSC_VER)
12-
TEST(ConversionCastTest, CheckedCastSmokeOnMSVC) { SUCCEED(); }
13-
#else
1411
TEST(ConversionCastTest, CheckedCastReportsErrorForInvalidInput) {
1512
auto const ok = conversion::checked_cast<int>(42u);
1613
ASSERT_TRUE(ok.has_value());
@@ -20,4 +17,3 @@ TEST(ConversionCastTest, CheckedCastReportsErrorForInvalidInput) {
2017
ASSERT_FALSE(bad.has_value());
2118
EXPECT_EQ(bad.error(), conversion::risk::kind::underflow);
2219
}
23-
#endif

tests/basic/conversion/underlying/test_builtin_casts_ext.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,10 @@ import mcpplibs.primitives.underlying;
88

99
using namespace mcpplibs::primitives;
1010

11-
#if defined(_MSC_VER)
12-
TEST(ConversionCastTest, SaturatingCastSmokeOnMSVC) { SUCCEED(); }
13-
#else
1411
TEST(ConversionCastTest, SaturatingCastClampsAndHandlesNaN) {
1512
EXPECT_EQ(conversion::saturating_cast<std::int16_t>(100000),
1613
std::numeric_limits<std::int16_t>::max());
1714
EXPECT_EQ(conversion::saturating_cast<int>(
1815
std::numeric_limits<double>::quiet_NaN()),
1916
0);
2017
}
21-
#endif

0 commit comments

Comments
 (0)