Skip to content

Commit 4b8d50a

Browse files
authored
[MOO-1293]: Gallery pull down loading indicator (#114)
2 parents a616ba1 + 4e4ae97 commit 4b8d50a

4 files changed

Lines changed: 7 additions & 3 deletions

File tree

packages/pluggableWidgets/gallery-native/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Fixed
10+
11+
- We've resolved an issue where the loading indicator was triggered when pulling down the list, even in the absence of a pull-down event.
12+
913
## [1.0.2] - 2023-5-24
1014

1115
### Fixed

packages/pluggableWidgets/gallery-native/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "gallery-native",
33
"widgetName": "Gallery",
4-
"version": "1.0.2",
4+
"version": "1.0.3",
55
"description": "A flexible gallery widget that renders columns, rows and layouts.",
66
"copyright": "© Mendix Technology BV 2022. All rights reserved.",
77
"license": "Apache-2.0",

packages/pluggableWidgets/gallery-native/src/Gallery.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export const Gallery = (props: GalleryProps<GalleryStyle>): ReactElement => {
115115
pagination={props.pagination}
116116
loadMoreButtonCaption={props.loadMoreButtonCaption}
117117
phoneColumns={props.phoneColumns}
118-
pullDown={pullDown}
118+
pullDown={props.pullDown && pullDown}
119119
pullDownIsExecuting={props.pullDown?.isExecuting ?? false}
120120
scrollDirection={props.scrollDirection}
121121
style={styles}

packages/pluggableWidgets/gallery-native/src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="Gallery" version="1.0.2" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="Gallery" version="1.0.3" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="Gallery.xml" />
66
</widgetFiles>

0 commit comments

Comments
 (0)