Skip to content

Commit c89e59c

Browse files
chore: remove react-native-system-navigation-bar (#314)
2 parents a8ce275 + 3235bd3 commit c89e59c

7 files changed

Lines changed: 6 additions & 30 deletions

File tree

configs/e2e/native_dependencies.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"react-native-linear-gradient": "2.8.3",
88
"@react-native-community/netinfo": "11.4.1",
99
"react-native-svg": "15.11.1",
10-
"react-native-system-navigation-bar": "2.6.3",
1110
"react-native-video": "6.10.0",
1211
"@react-native-async-storage/async-storage": "2.0.0",
1312
"react-native-camera": "3.40.0",

packages/pluggableWidgets/video-player-native/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Changed
10+
11+
- We have removed react-native-system-navigation-bar and deprecated-react-native-prop-types dependencies. Navigation bar visibility is now handled by the react-native-video package.
12+
913
## [6.2.0] - 2025-08-18
1014

1115
### Changed

packages/pluggableWidgets/video-player-native/package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "video-player-native",
33
"widgetName": "VideoPlayer",
4-
"version": "6.2.0",
4+
"version": "6.3.0",
55
"license": "Apache-2.0",
66
"repository": {
77
"type": "git",
@@ -20,8 +20,6 @@
2020
},
2121
"dependencies": {
2222
"@mendix/piw-native-utils-internal": "*",
23-
"deprecated-react-native-prop-types": "^4.0.0",
24-
"react-native-system-navigation-bar": "2.6.3",
2523
"react-native-vector-icons": "10.2.0",
2624
"react-native-video": "6.10.0"
2725
},

packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,9 @@ export function VideoPlayer(props: VideoPlayerProps<VideoStyle>): ReactElement {
8686
setFullScreen(isFullScreen);
8787
const { NavigationBar } = NativeModules;
8888
if (NavigationBar) {
89-
const SystemNavigationBar = (await import("react-native-system-navigation-bar")).default;
90-
9189
if (isFullScreen) {
92-
SystemNavigationBar.navigationHide();
9390
StatusBar.setHidden(true);
9491
} else {
95-
SystemNavigationBar.navigationShow();
9692
StatusBar.setHidden(false);
9793
const isDark = Appearance.getColorScheme() === "dark";
9894
StatusBar.setBarStyle(isDark ? "light-content" : "dark-content");

packages/pluggableWidgets/video-player-native/src/__tests__/VideoPlayer.spec.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,6 @@ import { VideoStyle } from "../ui/Styles";
1010

1111
jest.useFakeTimers();
1212
jest.mock("react-native-video", () => "Video");
13-
jest.mock("react-native-system-navigation-bar", () => ({
14-
navigationHide: jest.fn(),
15-
navigationShow: jest.fn()
16-
}));
1713

1814
describe("VideoPlayer", () => {
1915
let defaultProps: VideoPlayerProps<VideoStyle>;

packages/pluggableWidgets/video-player-native/src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="VideoPlayer" version="6.2.0" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="VideoPlayer" version="6.3.0" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="VideoPlayer.xml" />
66
</widgetFiles>

pnpm-lock.yaml

Lines changed: 0 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)