Skip to content

Commit 049269a

Browse files
committed
fix: adding review suggestions
1 parent 5f8c19a commit 049269a

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

packages/pluggableWidgets/datagrid-web/src/components/ColumnSelector.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,6 @@ export function ColumnSelector(props: ColumnSelectorProps): ReactElement {
126126
className={`column-selectors`}
127127
data-focusindex={0}
128128
role="menu"
129-
aria-multiselectable="true"
130129
style={{ ...correctedFloatingStyles, maxHeight }}
131130
{...getFloatingProps()}
132131
>
@@ -161,8 +160,9 @@ export function ColumnSelector(props: ColumnSelectorProps): ReactElement {
161160
setShow(false);
162161
}
163162
}}
164-
role="menuitem"
165-
aria-selected={isVisible}
163+
role="menuitemcheckbox"
164+
aria-checked={isVisible}
165+
aria-disabled={isLastVisibleColumn}
166166
tabIndex={0}
167167
>
168168
<input
@@ -172,6 +172,7 @@ export function ColumnSelector(props: ColumnSelectorProps): ReactElement {
172172
style={{ pointerEvents: "none" }}
173173
type="checkbox"
174174
tabIndex={-1}
175+
aria-hidden="true"
175176
onChange={onChangeStub}
176177
/>
177178
<label htmlFor={`${props.id}_checkbox_toggle_${index}`} style={{ pointerEvents: "none" }}>

0 commit comments

Comments
 (0)