fix: wait for previous event to finish before scheduling a new one

Author: r0b1n

packages/pluggableWidgets/events-web/CHANGELOG.md

@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
+### Fixed
+
+- We fixed an issue with burst action execution which was still happening in some cases.
+
 ## [1.2.0] - 2025-11-07
 
 ### Fixed

packages/pluggableWidgets/events-web/src/hooks/useOnLoadTimer.ts

@@ -14,6 +14,7 @@ class TimerExecutor {
     private intervalHandle: ReturnType<typeof setTimeout> | undefined;
     private isFirstTime: boolean = true;
     private isPendingExecution: boolean = false;
+    private waitingExecutionToFinish: boolean = false;
     private canExecute: boolean = false;
 
     private delay?: number;
@@ -22,10 +23,26 @@ class TimerExecutor {
 
     private callback?: () => void;
 
-    setCallback(callback: () => void, canExecute: boolean): void {
+    setCallback(callback: () => void, newCanExecute: boolean): void {
         this.callback = callback;
-        this.canExecute = canExecute;
 
+        if (this.waitingExecutionToFinish && this.canExecute && !newCanExecute) {
+            // this means we just executed the command, and canExecute went from true to false
+            // we should not do anything, only wait for the flag to go back to true
+            this.canExecute = newCanExecute;
+            return;
+        }
+
+        if (this.waitingExecutionToFinish && !this.canExecute && newCanExecute) {
+            // this means action completed successfully
+            // we can start a new timer
+            this.waitingExecutionToFinish = false;
+            this.canExecute = newCanExecute;
+            this.next();
+            return;
+        }
+
+        this.canExecute = newCanExecute;
         this.trigger();
     }
 
@@ -34,15 +51,18 @@ class TimerExecutor {
         this.interval = interval;
         this.repeat = repeat;
 
-        this.next();
+        if (this.isFirstTime) {
+            // kickstart the timer for the first time
+            this.next();
+        }
     }
 
     get isReady(): boolean {
         return this.delay !== undefined && (!this.repeat || this.interval !== undefined);
     }
 
     next(): void {
-        if (!this.isReady) {
+        if (!this.isReady || this.waitingExecutionToFinish) {
             return;
         }
 
@@ -56,9 +76,8 @@ class TimerExecutor {
         this.intervalHandle = setTimeout(
             () => {
                 this.isPendingExecution = true;
-                this.trigger();
                 this.isFirstTime = false;
-                this.next();
+                this.trigger();
             },
             this.isFirstTime ? this.delay : this.interval
         );
@@ -67,6 +86,7 @@ class TimerExecutor {
     trigger(): void {
         if (this.isPendingExecution && this.canExecute) {
             this.isPendingExecution = false;
+            this.waitingExecutionToFinish = true;
             this.callback?.();
         }
     }
@@ -77,6 +97,9 @@ class TimerExecutor {
         this.delay = undefined;
         this.interval = undefined;
         this.repeat = false;
+        this.isFirstTime = true;
+        this.isPendingExecution = false;
+        this.waitingExecutionToFinish = false;
     }
 }
 
@@ -97,11 +120,4 @@ export function useOnLoadTimer(props: UseOnLoadTimerProps): void {
             timerExecutor.stop();
         };
     }, [timerExecutor, delay, interval, repeat]);
-
-    // cleanup
-    useEffect(() => {
-        return () => {
-            timerExecutor.stop();
-        };
-    }, [timerExecutor]);
 }