Review feedback

Author: rchiodo

src/debugpy/common/messaging.py

@@ -21,7 +21,7 @@
 import threading
 
 from debugpy.common import json, log, util
-from debugpy.common.util import skip_trace
+from debugpy.common.util import hide_thread_from_debugger
 
 
 class JsonIOError(IOError):
@@ -1150,10 +1150,8 @@ def start(self):
             target=self._parse_incoming_messages, name=f"{self} message parser"
         )
 
-        if skip_trace():
-            self._parser_thread.pydev_do_not_trace = True
-            self._parser_thread.is_pydev_daemon_thread = True
-            self._parser_thread.daemon = True
+        hide_thread_from_debugger(self._parser_thread)
+        self._parser_thread.daemon = True
         self._parser_thread.start()
 
     def wait(self):

src/debugpy/common/sockets.py

@@ -7,7 +7,7 @@
 import threading
 
 from debugpy.common import log
-from debugpy.common.util import skip_trace
+from debugpy.common.util import hide_thread_from_debugger
 
 
 def create_server(host, port=0, backlog=socket.SOMAXCONN, timeout=None):
@@ -115,10 +115,8 @@ def accept_worker():
             handler(sock)
 
     thread = threading.Thread(target=accept_worker)
-    if skip_trace():
-        thread.daemon = True
-        thread.pydev_do_not_trace = True
-        thread.is_pydev_daemon_thread = True
+    thread.daemon = True
+    hide_thread_from_debugger(thread)
     thread.start()
 
     return listener

src/debugpy/common/util.py

@@ -150,16 +150,15 @@ def srcnameof(obj):
     return name
 
 
-def skip_trace():
-    """Returns True if tracing should be skipped for the current thread."""
+def hide_debugpy_internals():
+    """Returns True if the caller should hide something from debugpy."""
     return "DEBUGPY_TRACE_DEBUGPY" not in os.environ
 
 
-def disable_tracing(thread):
+def hide_thread_from_debugger(thread):
     """Disables tracing for the given thread if DEBUGPY_TRACE_DEBUGPY is not set.
     DEBUGPY_TRACE_DEBUGPY is used to debug debugpy with debugpy
     """
-    if skip_trace():
+    if hide_debugpy_internals():
         thread.pydev_do_not_trace = True
         thread.is_pydev_daemon_thread = True
-        thread.daemon = True

src/debugpy/server/api.py

@@ -14,7 +14,7 @@
 from debugpy.common import json, log, sockets
 from _pydevd_bundle.pydevd_constants import get_global_debugger
 from pydevd_file_utils import absolute_path
-from debugpy.common.util import skip_trace
+from debugpy.common.util import hide_debugpy_internals
 
 _tls = threading.local()
 
@@ -129,7 +129,7 @@ def debug(address, **kwargs):
             "patch_multiprocessing": _config.get("subProcess", True),
         }
 
-        if skip_trace():
+        if hide_debugpy_internals():
             debugpy_path = os.path.dirname(absolute_path(debugpy.__file__))
             settrace_kwargs["dont_trace_start_patterns"] = (debugpy_path,)
             settrace_kwargs["dont_trace_end_patterns"] = (str("debugpy_launcher.py"),)