Deal with exceptions in hasattr/dir/isinstance. Fixes microsoft/ptvsd#2076

Author: fabioz

src/debugpy/_vendored/pydevd/_pydev_bundle/_pydev_imports_tipper.py

@@ -4,15 +4,17 @@
 
 from _pydev_bundle._pydev_tipper_common import do_find
 from _pydevd_bundle.pydevd_constants import IS_PY2
+from _pydevd_bundle.pydevd_utils import hasattr_checked, dir_checked
 
 if IS_PY2:
     from inspect import getargspec as _originalgetargspec
+
     def getargspec(*args, **kwargs):
         ret = list(_originalgetargspec(*args, **kwargs))
         ret.append([])
         ret.append({})
         return ret
-        
+
 else:
     from inspect import getfullargspec
 
@@ -25,14 +27,15 @@ def getargspec(*args, **kwargs):
 except:
     xrange = range
 
-#completion types.
+# completion types.
 TYPE_IMPORT = '0'
 TYPE_CLASS = '1'
 TYPE_FUNCTION = '2'
 TYPE_ATTR = '3'
 TYPE_BUILTIN = '4'
 TYPE_PARAM = '5'
 
+
 def _imp(name, log=None):
     try:
         return __import__(name)
@@ -58,32 +61,32 @@ def _imp(name, log=None):
 if sys.platform == 'cli':
     IS_IPY = True
     _old_imp = _imp
+
     def _imp(name, log=None):
-        #We must add a reference in clr for .Net
-        import clr #@UnresolvedImport
+        # We must add a reference in clr for .Net
+        import clr  # @UnresolvedImport
         initial_name = name
         while '.' in name:
             try:
                 clr.AddReference(name)
-                break #If it worked, that's OK.
+                break  # If it worked, that's OK.
             except:
                 name = name[0:name.rfind('.')]
         else:
             try:
                 clr.AddReference(name)
             except:
-                pass #That's OK (not dot net module).
+                pass  # That's OK (not dot net module).
 
         return _old_imp(initial_name, log)
 
 
-
 def get_file(mod):
     f = None
     try:
         f = inspect.getsourcefile(mod) or inspect.getfile(mod)
     except:
-        if hasattr(mod, '__file__'):
+        if hasattr_checked(mod, '__file__'):
             f = mod.__file__
             if f.lower(f[-4:]) in ['.pyc', '.pyo']:
                 filename = f[:-4] + '.py'
@@ -92,6 +95,7 @@ def get_file(mod):
 
     return f
 
+
 def Find(name, log=None):
     f = None
 
@@ -107,9 +111,9 @@ def Find(name, log=None):
     old_comp = None
     for comp in components[1:]:
         try:
-            #this happens in the following case:
-            #we have mx.DateTime.mxDateTime.mxDateTime.pyd
-            #but after importing it, mx.DateTime.mxDateTime shadows access to mxDateTime.pyd
+            # this happens in the following case:
+            # we have mx.DateTime.mxDateTime.mxDateTime.pyd
+            # but after importing it, mx.DateTime.mxDateTime shadows access to mxDateTime.pyd
             mod = getattr(mod, comp)
         except AttributeError:
             if old_comp != comp:
@@ -126,6 +130,7 @@ def Find(name, log=None):
 
     return f, mod, parent, foundAs
 
+
 def search_definition(data):
     '''@return file, line, col
     '''
@@ -146,7 +151,7 @@ def generate_tip(data, log=None):
         data = data.rstrip('.')
 
     f, mod, parent, foundAs = Find(data, log)
-    #print_ >> open('temp.txt', 'w'), f
+    # print_ >> open('temp.txt', 'w'), f
     tips = generate_imports_tip_for_module(mod)
     return f, tips
 
@@ -156,8 +161,10 @@ def check_char(c):
         return '_'
     return c
 
+
 _SENTINEL = object()
 
+
 def generate_imports_tip_for_module(obj_to_complete, dir_comps=None, getattr=getattr, filter=lambda name:True):
     '''
         @param obj_to_complete: the object from where we should get the completions
@@ -170,17 +177,17 @@ def generate_imports_tip_for_module(obj_to_complete, dir_comps=None, getattr=get
     ret = []
 
     if dir_comps is None:
-        dir_comps = dir(obj_to_complete)
-        if hasattr(obj_to_complete, '__dict__'):
+        dir_comps = dir_checked(obj_to_complete)
+        if hasattr_checked(obj_to_complete, '__dict__'):
             dir_comps.append('__dict__')
-        if hasattr(obj_to_complete, '__class__'):
+        if hasattr_checked(obj_to_complete, '__class__'):
             dir_comps.append('__class__')
 
     get_complete_info = True
 
     if len(dir_comps) > 1000:
-        #ok, we don't want to let our users wait forever...
-        #no complete info for you...
+        # ok, we don't want to let our users wait forever...
+        # no complete info for you...
 
         get_complete_info = False
 
@@ -200,15 +207,15 @@ def generate_imports_tip_for_module(obj_to_complete, dir_comps=None, getattr=get
                 obj = getattr(obj_to_complete.__class__, d)
             except:
                 obj = getattr(obj_to_complete, d)
-        except: #just ignore and get it without additional info
+        except:  # just ignore and get it without additional info
             ret.append((d, '', args, TYPE_BUILTIN))
         else:
 
             if get_complete_info:
                 try:
                     retType = TYPE_BUILTIN
 
-                    #check if we have to get docs
+                    # check if we have to get docs
                     getDoc = True
                     for class_ in dontGetDocsOn:
 
@@ -218,32 +225,31 @@ def generate_imports_tip_for_module(obj_to_complete, dir_comps=None, getattr=get
 
                     doc = ''
                     if getDoc:
-                        #no need to get this info... too many constants are defined and
-                        #makes things much slower (passing all that through sockets takes quite some time)
+                        # no need to get this info... too many constants are defined and
+                        # makes things much slower (passing all that through sockets takes quite some time)
                         try:
                             doc = inspect.getdoc(obj)
                             if doc is None:
                                 doc = ''
-                        except: #may happen on jython when checking java classes (so, just ignore it)
+                        except:  # may happen on jython when checking java classes (so, just ignore it)
                             doc = ''
 
-
                     if inspect.ismethod(obj) or inspect.isbuiltin(obj) or inspect.isfunction(obj) or inspect.isroutine(obj):
                         try:
                             args, vargs, kwargs, defaults, kwonly_args, kwonly_defaults = getargspec(obj)
 
                             args = args[:]
-                                
+
                             for kwonly_arg in kwonly_args:
                                 default = kwonly_defaults.get(kwonly_arg, _SENTINEL)
                                 if default is not _SENTINEL:
                                     args.append('%s=%s' % (kwonly_arg, default))
                                 else:
                                     args.append(str(kwonly_arg))
-                            
+
                             args = '(%s)' % (', '.join(args))
                         except TypeError:
-                            #ok, let's see if we can get the arguments from the doc
+                            # ok, let's see if we can get the arguments from the doc
                             args, doc = signature_from_docstring(doc, getattr(obj, '__name__', None))
 
                         retType = TYPE_FUNCTION
@@ -257,14 +263,13 @@ def generate_imports_tip_for_module(obj_to_complete, dir_comps=None, getattr=get
                     else:
                         retType = TYPE_ATTR
 
-
-                    #add token and doc to return - assure only strings.
+                    # add token and doc to return - assure only strings.
                     ret.append((d, doc, args, retType))
 
-                except: #just ignore and get it without aditional info
+                except:  # just ignore and get it without aditional info
                     ret.append((d, '', args, TYPE_BUILTIN))
 
-            else: #get_complete_info == False
+            else:  # get_complete_info == False
                 if inspect.ismethod(obj) or inspect.isbuiltin(obj) or inspect.isfunction(obj) or inspect.isroutine(obj):
                     retType = TYPE_FUNCTION
 
@@ -276,8 +281,8 @@ def generate_imports_tip_for_module(obj_to_complete, dir_comps=None, getattr=get
 
                 else:
                     retType = TYPE_ATTR
-                #ok, no complete info, let's try to do this as fast and clean as possible
-                #so, no docs for this kind of information, only the signatures
+                # ok, no complete info, let's try to do this as fast and clean as possible
+                # so, no docs for this kind of information, only the signatures
                 ret.append((d, '', str(args), retType))
 
     return ret

src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_comm.py

@@ -96,7 +96,7 @@
 import sys
 import traceback
 from _pydevd_bundle.pydevd_utils import quote_smart as quote, compare_object_attrs_key, \
-    notify_about_gevent_if_needed
+    notify_about_gevent_if_needed, isinstance_checked
 from _pydev_bundle import pydev_log
 from _pydev_bundle.pydev_log import exception as pydev_log_exception
 from _pydev_bundle import _pydev_completer
@@ -1005,7 +1005,7 @@ def __create_frame():
         else:
             frame = py_db.find_frame(thread_id, frame_id)
             eval_result = pydevd_vars.evaluate_expression(py_db, frame, expression, is_exec=False)
-            is_error = isinstance(eval_result, ExceptionOnEvaluate)
+            is_error = isinstance_checked(eval_result, ExceptionOnEvaluate)
             if is_error:
                 if context == 'hover':  # In a hover it doesn't make sense to do an exec.
                     _evaluate_response(py_db, request, result='', error_message='Exception occurred during evaluation.')

src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_resolver.py

@@ -1,4 +1,5 @@
 from _pydev_bundle import pydev_log
+from _pydevd_bundle.pydevd_utils import hasattr_checked
 try:
     import StringIO
 except:
@@ -113,7 +114,7 @@ def _get_jy_dictionary(self, obj):
         found = java.util.HashMap()
 
         original = obj
-        if hasattr(obj, '__class__') and obj.__class__ == java.lang.Class:
+        if hasattr_checked(obj, '__class__') and obj.__class__ == java.lang.Class:
 
             # get info about superclasses
             classes = []
@@ -171,7 +172,7 @@ def get_names(self, var):
         except Exception:
             names = []
         if not names:
-            if hasattr(var, '__dict__'):
+            if hasattr_checked(var, '__dict__'):
                 names = dict_keys(var.__dict__)
                 used___dict__ = True
         return names, used___dict__

src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_utils.py

@@ -271,3 +271,28 @@ def notify_about_gevent_if_needed(stream=None):
                 return True
 
     return False
+
+
+def hasattr_checked(obj, name):
+    try:
+        getattr(obj, name)
+    except:
+        # i.e.: Handle any exception, not only AttributeError.
+        return False
+    else:
+        return True
+
+
+def dir_checked(obj):
+    try:
+        return dir(obj)
+    except:
+        return []
+
+
+def isinstance_checked(obj, cls):
+    try:
+        return isinstance(obj, cls)
+    except:
+        return False
+

src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_xml.py

@@ -7,6 +7,7 @@
     DEFAULT_VALUE
 from _pydev_bundle.pydev_imports import quote
 from _pydevd_bundle.pydevd_extension_api import TypeResolveProvider, StrPresentationProvider
+from _pydevd_bundle.pydevd_utils import isinstance_checked, hasattr_checked
 
 try:
     import types
@@ -155,7 +156,7 @@ def _get_type(self, o, type_object, type_name):
                     return type_object, type_name, resolver
 
             for t in self._default_type_map:
-                if isinstance(o, t[0]):
+                if isinstance_checked(o, t[0]):
                     # Cache it
                     resolver = t[1]
                     self._type_to_resolver_cache[type_object] = resolver
@@ -223,7 +224,7 @@ def is_builtin(x):
 
 
 def should_evaluate_full_value(val):
-    return not LOAD_VALUES_ASYNC or (is_builtin(type(val)) and not isinstance(val, (list, tuple, dict)))
+    return not LOAD_VALUES_ASYNC or (is_builtin(type(val)) and not isinstance_checked(val, (list, tuple, dict)))
 
 
 def return_values_from_dict_to_xml(return_dict):
@@ -294,7 +295,7 @@ def get_variable_details(val, evaluate_full_value=True, to_string=None):
             elif to_string is not None:
                 value = to_string(v)
 
-            elif hasattr(v, '__class__'):
+            elif hasattr_checked(v, '__class__'):
                 if v.__class__ == frame_type:
                     value = pydevd_resolver.frameResolver.get_frame_name(v)
 

src/debugpy/_vendored/pydevd/tests/test_simpleTipper.py

@@ -218,6 +218,17 @@ def test_dot_net_libraries(self):
             tip = _pydev_imports_tipper.generate_tip('System.Drawing.Brushes')
             self.assert_in('Aqua' , tip)
 
+    def test_tips_hasattr_failure(self):
+
+        class MyClass(object):
+
+            def __getattribute__(self, attr):
+                raise RuntimeError()
+
+        obj = MyClass()
+
+        _pydev_imports_tipper.generate_imports_tip_for_module(obj)
+
     def test_inspect(self):
 
         class C(object):

src/debugpy/_vendored/pydevd/tests_python/resources/_debugger_case_hasattr_crash.py

@@ -0,0 +1,10 @@
+class MyClass(object):
+
+    def __getattribute__(self, attr):
+        raise RuntimeError()
+
+
+obj = MyClass()
+
+if __name__ == '__main__':
+    print('TEST SUCEEDED')  # break here