fix: Address all Copilot review comments

- compiler.py: Move platform import to module level
- compiler.py: Fix libc detection logic (default to glibc when detection fails)
- compiler.py: Lower macOS platform tag from 15.0 to 11.0 (Big Sur)
- compiler.py: Update coverage param docs to say Linux/macOS
- compiler.py: Print stdout on build failure (not just stderr)
- build_backend.py: Handle build_editable import gracefully with better error
- pyproject.toml: Fix license field to SPDX string format with license-files
- pyproject.toml: Add explicit build_ddbc/tests/benchmarks exclusion
- pyproject.toml: Expand self-reference in optional deps for older pip
- setup.py: Fix circular dependency by duplicating get_platform_info

Author: bewithgaurav

build_ddbc/build_backend.py

@@ -27,6 +27,7 @@
 # PEP 517 Required Hooks
 # =============================================================================
 
+
 def get_requires_for_build_wheel(config_settings=None):
     """Return build requirements for wheel."""
     return _get_requires_for_build_wheel(config_settings)
@@ -97,6 +98,7 @@ def build_sdist(sdist_directory, config_settings=None):
 # Optional PEP 660 Hooks (Editable Installs)
 # =============================================================================
 
+
 def get_requires_for_build_editable(config_settings=None):
     """Return build requirements for editable install."""
     return get_requires_for_build_wheel(config_settings)
@@ -121,6 +123,12 @@ def build_editable(wheel_directory, config_settings=None, metadata_directory=Non
         print(f"[build_backend] Compilation failed: {e}")
         raise
 
-    # Import here to avoid issues if not available
-    from setuptools.build_meta import build_editable as _setuptools_build_editable
+    # Import here and handle absence gracefully for older setuptools versions
+    try:
+        from setuptools.build_meta import build_editable as _setuptools_build_editable
+    except ImportError as exc:
+        raise RuntimeError(
+            "Editable installs are not supported with this setuptools version. "
+            "Please install setuptools>=64.0.0 to use PEP 660 editable installs."
+        ) from exc
     return _setuptools_build_editable(wheel_directory, config_settings, metadata_directory)

build_ddbc/compiler.py

@@ -5,6 +5,7 @@
 """
 
 import os
+import platform
 import sys
 import subprocess
 from pathlib import Path
@@ -34,13 +35,21 @@ def get_platform_info() -> Tuple[str, str]:
             return "x64", "win_amd64"
 
     elif sys.platform.startswith("darwin"):
-        return "universal2", "macosx_15_0_universal2"
+        return "universal2", "macosx_11_0_universal2"
 
     elif sys.platform.startswith("linux"):
-        import platform
         target_arch = os.environ.get("targetArch", platform.machine())
         libc_name, _ = platform.libc_ver()
-        is_musl = libc_name == "" or "musl" in libc_name.lower()
+        # Empty libc_name could indicate detection failure; default to glibc (manylinux)
+        if not libc_name:
+            print(
+                "[build_ddbc] Warning: libc detection failed (platform.libc_ver() "
+                "returned an empty name); defaulting to glibc (manylinux) tags.",
+                file=sys.stderr,
+            )
+            is_musl = False
+        else:
+            is_musl = "musl" in libc_name.lower()
 
         if target_arch == "x86_64":
             return "x86_64", "musllinux_1_2_x86_64" if is_musl else "manylinux_2_28_x86_64"
@@ -86,7 +95,7 @@ def compile_ddbc(
 
     Args:
         arch: Target architecture (Windows only: x64, x86, arm64)
-        coverage: Enable coverage instrumentation (Linux only)
+        coverage: Enable coverage instrumentation (Linux/macOS only)
         verbose: Print build output
 
     Returns:
@@ -128,8 +137,11 @@ def _run_windows_build(pybind_dir: Path, arch: str, verbose: bool) -> bool:
     )
 
     if result.returncode != 0:
-        if not verbose and result.stderr:
-            print(result.stderr.decode(), file=sys.stderr)
+        if not verbose:
+            if result.stdout:
+                print(result.stdout.decode(), file=sys.stderr)
+            if result.stderr:
+                print(result.stderr.decode(), file=sys.stderr)
         raise RuntimeError(f"build.bat failed with exit code {result.returncode}")
 
     if verbose:
@@ -163,8 +175,11 @@ def _run_unix_build(pybind_dir: Path, coverage: bool, verbose: bool) -> bool:
     )
 
     if result.returncode != 0:
-        if not verbose and result.stderr:
-            print(result.stderr.decode(), file=sys.stderr)
+        if not verbose:
+            if result.stdout:
+                print(result.stdout.decode(), file=sys.stderr)
+            if result.stderr:
+                print(result.stderr.decode(), file=sys.stderr)
         raise RuntimeError(f"build.sh failed with exit code {result.returncode}")
 
     if verbose:

pyproject.toml

@@ -15,6 +15,7 @@ version = "1.2.0"
 description = "A Python library for interacting with Microsoft SQL Server"
 readme = "PyPI_Description.md"
 license = "MIT"
+license-files = ["LICENSE"]
 requires-python = ">=3.10"
 authors = [
     { name = "Microsoft Corporation", email = "mssql-python@microsoft.com" }
@@ -68,7 +69,23 @@ lint = [
     "types-setuptools",
 ]
 all = [
-    "mssql-python[dev,lint]",
+    # Dev dependencies
+    "pytest",
+    "pytest-cov",
+    "coverage",
+    "unittest-xml-reporting",
+    "psutil",
+    "pybind11",
+    "setuptools",
+    "wheel",
+    "build",
+    # Lint dependencies
+    "black",
+    "autopep8",
+    "pylint",
+    "cpplint",
+    "mypy",
+    "types-setuptools",
 ]
 
 # =============================================================================
@@ -81,6 +98,7 @@ include-package-data = true
 [tool.setuptools.packages.find]
 where = ["."]
 include = ["mssql_python*"]
+exclude = ["build_ddbc*", "tests*", "benchmarks*"]
 
 [tool.setuptools.package-data]
 mssql_python = [

setup.py

@@ -14,30 +14,65 @@
     pip install -e .           # Editable install with auto-compile
 """
 
+import os
+import platform
 import sys
 
 from setuptools import setup, find_packages
 from setuptools.dist import Distribution
 from wheel.bdist_wheel import bdist_wheel
 
-from build_ddbc import get_platform_info
+
+def get_platform_info():
+    """
+    Get platform-specific architecture and platform tag information.
+
+    Note: This is duplicated from build_ddbc.compiler to avoid circular imports
+    during fresh installs where build_ddbc isn't available yet.
+    """
+    if sys.platform.startswith("win"):
+        arch = os.environ.get("ARCHITECTURE", "x64")
+        if isinstance(arch, str):
+            arch = arch.strip("\"'")
+        if arch in ["x86", "win32"]:
+            return "x86", "win32"
+        elif arch == "arm64":
+            return "arm64", "win_arm64"
+        else:
+            return "x64", "win_amd64"
+    elif sys.platform.startswith("darwin"):
+        return "universal2", "macosx_11_0_universal2"
+    elif sys.platform.startswith("linux"):
+        target_arch = os.environ.get("targetArch", platform.machine())
+        libc_name, _ = platform.libc_ver()
+        is_musl = libc_name and "musl" in libc_name.lower()
+        if target_arch == "x86_64":
+            return "x86_64", "musllinux_1_2_x86_64" if is_musl else "manylinux_2_28_x86_64"
+        elif target_arch in ["aarch64", "arm64"]:
+            return "aarch64", "musllinux_1_2_aarch64" if is_musl else "manylinux_2_28_aarch64"
+        else:
+            raise OSError(f"Unsupported architecture '{target_arch}' for Linux")
+    raise OSError(f"Unsupported platform: {sys.platform}")
 
 
 # =============================================================================
 # Platform-Specific Package Discovery
 # =============================================================================
 
+
 def get_platform_packages():
     """Get platform-specific package list."""
     packages = find_packages()
     arch, _ = get_platform_info()
 
     if sys.platform.startswith("win"):
-        packages.extend([
-            f"mssql_python.libs.windows.{arch}",
-            f"mssql_python.libs.windows.{arch}.1033",
-            f"mssql_python.libs.windows.{arch}.vcredist",
-        ])
+        packages.extend(
+            [
+                f"mssql_python.libs.windows.{arch}",
+                f"mssql_python.libs.windows.{arch}.1033",
+                f"mssql_python.libs.windows.{arch}.vcredist",
+            ]
+        )
     elif sys.platform.startswith("darwin"):
         packages.append("mssql_python.libs.macos")
     elif sys.platform.startswith("linux"):
@@ -50,6 +85,7 @@ def get_platform_packages():
 # Custom Distribution (Force Platform-Specific Wheel)
 # =============================================================================
 
+
 class BinaryDistribution(Distribution):
     """Distribution that forces platform-specific wheel creation."""
 
@@ -61,6 +97,7 @@ def has_ext_modules(self):
 # Custom bdist_wheel Command
 # =============================================================================
 
+
 class CustomBdistWheel(bdist_wheel):
     """Custom wheel builder with platform-specific tags."""
 
@@ -81,10 +118,8 @@ def finalize_options(self):
 setup(
     # Package discovery
     packages=get_platform_packages(),
-
     # Force binary distribution
     distclass=BinaryDistribution,
-
     # Register custom commands
     cmdclass={
         "bdist_wheel": CustomBdistWheel,