Make old member available for IntelliCode

Author: MikhailArkhipov

src/Analysis/Engine/Impl/Definitions/IModuleAnalysis.cs

@@ -147,7 +147,7 @@ public interface IModuleAnalysis {
         /// <param name="location">
         /// The location in the file where the available members should be looked up.
         /// </param>
-        IEnumerable<IMemberResult> GetAllAvailableMembers(SourceLocation location, GetMemberOptions options = GetMemberOptions.IntersectMultipleResults);
+        IEnumerable<IMemberResult> GetAllMembers(SourceLocation location, GetMemberOptions options = GetMemberOptions.IntersectMultipleResults);
 
         /// <summary>
         /// Gets the AST for the given text as if it appeared at the specified location.

src/Analysis/Engine/Impl/ModuleAnalysis.cs

@@ -351,7 +351,7 @@ public IEnumerable<IMemberResult> GetMembers(
             GetMemberOptions options = GetMemberOptions.IntersectMultipleResults
         ) {
             if (string.IsNullOrEmpty(exprText)) {
-                return GetAllAvailableMembers(location, options);
+                return GetAllMembers(location, options);
             }
 
             var expr = GetExpressionForText(exprText, location, out var scope, out var ast);
@@ -631,7 +631,11 @@ public IEnumerable<IOverloadResult> GetOverrideable(SourceLocation location) {
         internal IEnumerable<IMemberResult> GetAllAvailableMembersByIndex(
             int index,
             GetMemberOptions options = GetMemberOptions.IntersectMultipleResults
-        ) => GetAllAvailableMembers(_unit.Tree.IndexToLocation(index), options);
+        ) => GetAllMembers(_unit.Tree.IndexToLocation(index), options);
+
+        [Obsolete]
+        public IEnumerable<MemberResult> GetAllAvailableMembers(SourceLocation location, GetMemberOptions options = GetMemberOptions.IntersectMultipleResults)
+            => GetAllMembers(location, options).OfType<MemberResult>();
 
         /// <summary>
         /// Gets the available names at the given location.  This includes
@@ -642,7 +646,7 @@ internal IEnumerable<IMemberResult> GetAllAvailableMembersByIndex(
         /// looked up.
         /// </param>
         /// <remarks>New in 2.2</remarks>
-        public IEnumerable<IMemberResult> GetAllAvailableMembers(SourceLocation location, GetMemberOptions options = GetMemberOptions.IntersectMultipleResults) {
+        public IEnumerable<IMemberResult> GetAllMembers(SourceLocation location, GetMemberOptions options = GetMemberOptions.IntersectMultipleResults) {
             var result = new Dictionary<string, IEnumerable<AnalysisValue>>();
 
             // collect builtins

src/LanguageServer/Impl/Implementation/CompletionAnalysis.cs

@@ -771,7 +771,7 @@ private IEnumerable<CompletionItem> GetCompletionsFromTopLevel(bool allowKeyword
             }
 
             _log.TraceMessage($"Completing all names");
-            var members = Analysis.GetAllAvailableMembers(Position, opts);
+            var members = Analysis.GetAllMembers(Position, opts);
 
             if (allowArguments) {
                 var finder = new ExpressionFinder(Tree, new GetExpressionOptions { Calls = true });

src/LanguageServer/Impl/Implementation/Server.WorkspaceSymbols.cs

@@ -72,7 +72,7 @@ private static async Task<List<IMemberResult>> GetModuleVariablesAsync(ProjectEn
         }
 
         private static IEnumerable<IMemberResult> GetModuleVariables(ProjectEntry entry, GetMemberOptions opts, string prefix, IModuleAnalysis analysis) {
-            var all = analysis.GetAllAvailableMembers(SourceLocation.None, opts);
+            var all = analysis.GetAllMembers(SourceLocation.None, opts);
             return all
                 .Where(m => {
                     if (m.Values.Any(v => v.DeclaringModule == entry || v.Locations.Any(l => l.DocumentUri == entry.DocumentUri))) {