Remove All member in favor of enumerable

Author: MikhailArkhipov

src/Analysis/Engine/Test/ServerExtensions.cs

@@ -149,7 +149,7 @@ public static async Task<IModuleAnalysis> OpenDefaultDocumentAndGetAnalysisAsync
             var cancellationToken = new CancellationTokenSource(failAfter).Token;
             await server.SendDidOpenTextDocument(TestData.GetDefaultModuleUri(), content, languageId);
             cancellationToken.ThrowIfCancellationRequested();
-            var projectEntry = (ProjectEntry) server.ProjectFiles.All.Single();
+            var projectEntry = (ProjectEntry) server.ProjectFiles.Single();
             return await projectEntry.GetAnalysisAsync(cancellationToken: cancellationToken);
         }
 
@@ -167,7 +167,7 @@ public static Task SendDidChangeTextDocumentAsync(this Server server, Uri uri, s
         }
 
         public static async Task<IModuleAnalysis> ChangeDefaultDocumentAndGetAnalysisAsync(this Server server, string text, int failAfter = 30000) {
-            var projectEntry = (ProjectEntry) server.ProjectFiles.All.Single();
+            var projectEntry = (ProjectEntry) server.ProjectFiles.Single();
             await server.SendDidChangeTextDocumentAsync(projectEntry.DocumentUri, text);
             return await projectEntry.GetAnalysisAsync(cancellationToken: new CancellationTokenSource(failAfter).Token);
         }

src/LanguageServer/Impl/Implementation/EditorFiles.cs

@@ -42,7 +42,7 @@ public EditorFiles(Server server) {
         public void Close(Uri uri) => GetDocument(uri).Close(uri);
 
         public void UpdateDiagnostics() {
-            foreach (var entry in _server.ProjectFiles.All) {
+            foreach (var entry in _server.ProjectFiles) {
                 GetDocument(entry.DocumentUri).UpdateAnalysisDiagnostics(entry, -1);
             }
         }

src/LanguageServer/Impl/Implementation/ProjectFiles.cs

@@ -40,13 +40,6 @@ public IProjectEntry RemoveEntry(Uri documentUri) {
             return _projectFiles.TryRemove(documentUri, out var entry) ? entry : null;
         }
 
-        public IEnumerable<IProjectEntry> All {
-            get {
-                ThrowIfDisposed();
-                return _projectFiles.Values;
-            }
-        }
-
         public IEnumerable<string> GetLoadedFiles() {
             ThrowIfDisposed();
             return _projectFiles.Keys.Select(k => k.AbsoluteUri);
@@ -103,8 +96,13 @@ private void ThrowIfDisposed() {
         }
 
         #region IEnumerable<IProjectEntry>
-        public IEnumerator<IProjectEntry> GetEnumerator() => All.GetEnumerator();
-        IEnumerator IEnumerable.GetEnumerator() => All.GetEnumerator();
+        public IEnumerator<IProjectEntry> GetEnumerator() => GetAll().GetEnumerator();
+        IEnumerator IEnumerable.GetEnumerator() => GetAll().GetEnumerator();
+
+        private ICollection<IProjectEntry>  GetAll() {
+            ThrowIfDisposed();
+            return _projectFiles.Values;
+        }
         #endregion
     }
 }

src/LanguageServer/Impl/Implementation/Server.WorkspaceSymbols.cs

@@ -34,7 +34,7 @@ public override async Task<SymbolInformation[]> WorkspaceSymbols(WorkspaceSymbol
             var members = Enumerable.Empty<IMemberResult>();
             var opts = GetMemberOptions.ExcludeBuiltins | GetMemberOptions.DeclaredOnly;
 
-            foreach (var entry in ProjectFiles.All) {
+            foreach (var entry in ProjectFiles) {
                 members = members.Concat(
                     await GetModuleVariablesAsync(entry as ProjectEntry, opts, @params.query, 50, cancellationToken)
                 );