Revert "Limit analysis"

Mikhail Arkhipov · Mikhail Arkhipov · commit e9e1a90af33b · 2018-10-03T11:14:26.000-07:00
This reverts commit 9f3666a.
diff --git a/src/Analysis/Engine/Impl/AnalysisUnit.cs b/src/Analysis/Engine/Impl/AnalysisUnit.cs
@@ -109,7 +109,7 @@ public AnalysisUnit CopyForEval() {
         }
 
         internal void Enqueue() {
-            if (!ForEval && !IsInQueue && !_suppressEnqueue && NeedsAnalysis()) {
+            if (!ForEval && !IsInQueue && !_suppressEnqueue) {
                 State.Queue.Append(this);
                 AnalysisLog.Enqueue(State.Queue, this);
                 IsInQueue = true;
@@ -120,10 +120,6 @@ internal void Enqueue() {
             }
         }
 
-        private bool NeedsAnalysis()
-            => _analysisCount == 0 || (_scope != null && _scope.AllVariables.Select(k => k.Value).Any(v => !v.HasTypes));
-
-
         /// <summary>
         /// The AST which will be analyzed when this node is analyzed
         /// </summary>

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public AnalysisUnit CopyForEval() {`
`109`	`109`	`}`
`110`	`110`
`111`	`111`	`internal void Enqueue() {`
`112`		`- if (!ForEval && !IsInQueue && !_suppressEnqueue && NeedsAnalysis()) {`
	`112`	`+ if (!ForEval && !IsInQueue && !_suppressEnqueue) {`
`113`	`113`	`State.Queue.Append(this);`
`114`	`114`	`AnalysisLog.Enqueue(State.Queue, this);`
`115`	`115`	`IsInQueue = true;`
`@@ -120,10 +120,6 @@ internal void Enqueue() {`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`
`123`		`- private bool NeedsAnalysis()`
`124`		`- => _analysisCount == 0 \|\| (_scope != null && _scope.AllVariables.Select(k => k.Value).Any(v => !v.HasTypes));`
`125`		`-`
`126`		`-`
`127`	`123`	`/// <summary>`
`128`	`124`	`/// The AST which will be analyzed when this node is analyzed`
`129`	`125`	`/// </summary>`