refactor: move default values into destructuring assignments

Agent-Logs-Url: https://github.com/microsoft/rushstack/sessions/2fa38687-8cb7-4932-b927-0db70e54c476

Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>

Author: Copilot

apps/heft/src/cli/actions/PhaseAction.ts

@@ -20,19 +20,20 @@ export class PhaseAction extends CommandLineAction implements IHeftAction {
   private _selectedPhases: Set<HeftPhase> | undefined;
 
   public constructor(options: IPhaseActionOptions) {
-    const { phase, watch } = options;
+    const { phase, watch = false } = options;
+    const { phaseName, phaseDescription } = phase;
     super({
-      actionName: `${phase.phaseName}${watch ? '-watch' : ''}`,
+      actionName: `${phaseName}${watch ? '-watch' : ''}`,
       documentation:
-        `Runs to the ${phase.phaseName} phase, including all transitive dependencies` +
+        `Runs to the ${phaseName} phase, including all transitive dependencies` +
         (watch ? ', in watch mode.' : '.') +
-        (phase.phaseDescription ? `  ${phase.phaseDescription}` : ''),
+        (phaseDescription ? `  ${phaseDescription}` : ''),
       summary:
-        `Runs to the ${phase.phaseName} phase, including all transitive dependencies` +
+        `Runs to the ${phaseName} phase, including all transitive dependencies` +
         (watch ? ', in watch mode.' : '.')
     });
 
-    this.watch = watch ?? false;
+    this.watch = watch;
     this._phase = phase;
     this._actionRunner = new HeftActionRunner({ action: this, ...options });
     this._actionRunner.defineParameters();

libraries/operation-graph/src/Operation.ts

@@ -198,12 +198,12 @@ export class Operation<TMetadata extends {} = {}, TGroupMetadata extends {} = {}
   public readonly metadata: TMetadata;
 
   public constructor(options: IOperationOptions<TMetadata, TGroupMetadata>) {
-    const { group, runner, weight, name, metadata } = options;
+    const { group, runner, weight = 1, name, metadata = {} as TMetadata } = options;
     this.group = group;
     this.runner = runner;
-    this.weight = weight ?? 1;
+    this.weight = weight;
     this.name = name;
-    this.metadata = metadata || ({} as TMetadata);
+    this.metadata = metadata;
 
     if (this.group) {
       this.group.addOperation(this);

libraries/rush-lib/src/cli/scriptActions/PhasedScriptAction.ts

@@ -182,7 +182,7 @@ export class PhasedScriptAction extends BaseScriptAction<IPhasedCommandConfig> i
       originalPhases,
       initialPhases,
       watchPhases,
-      watchDebounceMs,
+      watchDebounceMs = RushConstants.defaultWatchDebounceMs,
       alwaysWatch,
       alwaysInstall,
       phases
@@ -194,7 +194,7 @@ export class PhasedScriptAction extends BaseScriptAction<IPhasedCommandConfig> i
     this._originalPhases = originalPhases;
     this._initialPhases = initialPhases;
     this._watchPhases = watchPhases;
-    this._watchDebounceMs = watchDebounceMs ?? RushConstants.defaultWatchDebounceMs;
+    this._watchDebounceMs = watchDebounceMs;
     this._alwaysWatch = alwaysWatch;
     this._alwaysInstall = alwaysInstall;
     this._runsBeforeInstall = false;

libraries/rush-lib/src/utilities/RushAlerts.ts

@@ -103,14 +103,14 @@ export class RushAlerts {
       rushAlertsStateFilePath,
       rushAlertsConfigFilePath,
       rushAlertsConfig,
-      rushAlertsState
+      rushAlertsState = {}
     } = options;
     this._terminal = terminal;
     this._rushJsonFolder = rushJsonFolder;
     this.rushAlertsStateFilePath = rushAlertsStateFilePath;
     this.rushAlertsConfigFilePath = rushAlertsConfigFilePath;
     this._rushAlertsConfig = rushAlertsConfig;
-    this._rushAlertsState = rushAlertsState ?? {};
+    this._rushAlertsState = rushAlertsState;
   }
 
   public static async loadFromConfigurationAsync(

libraries/terminal/src/TextRewriterTransform.ts

@@ -68,8 +68,13 @@ export class TextRewriterTransform extends TerminalTransform {
   public constructor(options: ITextRewriterTransformOptions) {
     super(options);
 
-    const { textRewriters: inputTextRewriters, removeColors, normalizeNewlines, ensureNewlineAtEnd } = options;
-    const textRewriters: TextRewriter[] = inputTextRewriters || [];
+    const {
+      textRewriters: inputTextRewriters = [],
+      removeColors,
+      normalizeNewlines,
+      ensureNewlineAtEnd
+    } = options;
+    const textRewriters: TextRewriter[] = [...inputTextRewriters];
 
     if (removeColors) {
       textRewriters.push(new RemoveColorsTextRewriter());

libraries/ts-command-line/src/providers/AliasCommandLineAction.ts

@@ -63,9 +63,9 @@ export class AliasCommandLineAction extends CommandLineAction {
   private _parameterKeyMap: Map<string, string> = new Map();
 
   public constructor(options: IAliasCommandLineActionOptions) {
-    const { toolFilename, targetAction, defaultParameters: defaultParams, aliasName } = options;
+    const { toolFilename, targetAction, defaultParameters: defaultParams = [], aliasName } = options;
     const targetActionName: string = targetAction.actionName;
-    const defaultParametersString: string = (defaultParams || []).join(' ');
+    const defaultParametersString: string = defaultParams.join(' ');
     const summary: string = `An alias for "${toolFilename} ${targetActionName}${
       defaultParametersString ? ` ${defaultParametersString}` : ''
     }".`;
@@ -79,7 +79,7 @@ export class AliasCommandLineAction extends CommandLineAction {
     });
 
     this.targetAction = targetAction;
-    this.defaultParameters = defaultParams || [];
+    this.defaultParameters = defaultParams;
   }
 
   /** @internal */

libraries/typings-generator/src/TypingsGenerator.ts

@@ -108,13 +108,18 @@ export class TypingsGenerator<TFileContents = string> {
   );
   public constructor(options: ITypingsGeneratorOptionsWithCustomReadFile<string | undefined, TFileContents>);
   public constructor(options: ITypingsGeneratorOptionsWithCustomReadFile<string | undefined, TFileContents>) {
-    const { readFile, generatedTsFolder, srcFolder, fileExtensions, globsToIgnore, terminal } = options;
+    const {
+      readFile = ((filePath: string, relativePath: string): Promise<TFileContents> =>
+        FileSystem.readFileAsync(filePath) as Promise<TFileContents>) as typeof options.readFile,
+      generatedTsFolder,
+      srcFolder,
+      fileExtensions,
+      globsToIgnore = [],
+      terminal = new Terminal(new ConsoleTerminalProvider({ verboseEnabled: true }))
+    } = options;
     this._options = {
       ...options,
-      readFile:
-        readFile ??
-        ((filePath: string, relativePath: string): Promise<TFileContents> =>
-          FileSystem.readFileAsync(filePath) as Promise<TFileContents>)
+      readFile
     };
 
     if (!generatedTsFolder) {
@@ -138,9 +143,9 @@ export class TypingsGenerator<TFileContents = string> {
       throw new Error('At least one file extension must be provided.');
     }
 
-    this.ignoredFileGlobs = globsToIgnore || [];
+    this.ignoredFileGlobs = globsToIgnore;
 
-    this.terminal = terminal ?? new Terminal(new ConsoleTerminalProvider({ verboseEnabled: true }));
+    this.terminal = terminal;
 
     this._options.fileExtensions = this._normalizeFileExtensions(fileExtensions);
 

rush-plugins/rush-azure-storage-build-cache-plugin/src/AzureAuthenticationBase.ts

@@ -180,20 +180,20 @@ export abstract class AzureAuthenticationBase {
       azureEnvironment = 'AzurePublicCloud',
       credentialUpdateCommandForLogging,
       loginFlow = process.env.CODESPACES === 'true' ? 'AdoCodespacesAuth' : 'VisualStudioCode',
-      loginFlowFailover
+      loginFlowFailover = {
+        AdoCodespacesAuth: 'VisualStudioCode',
+        VisualStudioCode: 'AzureCli',
+        AzureCli: 'AzureDeveloperCli',
+        AzureDeveloperCli: 'AzurePowerShell',
+        AzurePowerShell: 'InteractiveBrowser',
+        InteractiveBrowser: 'DeviceCode',
+        DeviceCode: undefined
+      }
     } = options;
     this._azureEnvironment = azureEnvironment;
     this._credentialUpdateCommandForLogging = credentialUpdateCommandForLogging;
     this._loginFlow = loginFlow;
-    this._failoverOrder = loginFlowFailover || {
-      AdoCodespacesAuth: 'VisualStudioCode',
-      VisualStudioCode: 'AzureCli',
-      AzureCli: 'AzureDeveloperCli',
-      AzureDeveloperCli: 'AzurePowerShell',
-      AzurePowerShell: 'InteractiveBrowser',
-      InteractiveBrowser: 'DeviceCode',
-      DeviceCode: undefined
-    };
+    this._failoverOrder = loginFlowFailover;
   }
 
   public async updateCachedCredentialAsync(terminal: ITerminal, credential: string): Promise<void> {

rush-plugins/rush-http-build-cache-plugin/src/HttpBuildCacheProvider.ts

@@ -78,11 +78,11 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
       rushJsonFolder,
       isCacheWriteAllowed,
       url,
-      uploadMethod,
-      headers,
+      uploadMethod = 'PUT',
+      headers = {},
       tokenHandler,
-      cacheKeyPrefix,
-      minHttpRetryDelayMs
+      cacheKeyPrefix = '',
+      minHttpRetryDelayMs = DEFAULT_MIN_HTTP_RETRY_DELAY_MS
     } = options;
 
     this._pluginName = pluginName;
@@ -91,11 +91,11 @@ export class HttpBuildCacheProvider implements ICloudBuildCacheProvider {
     this._environmentCredential = EnvironmentConfiguration.buildCacheCredential;
     this._isCacheWriteAllowedByConfiguration = isCacheWriteAllowed;
     this._url = new URL(url.endsWith('/') ? url : url + '/');
-    this._uploadMethod = uploadMethod ?? 'PUT';
-    this._headers = headers ?? {};
+    this._uploadMethod = uploadMethod;
+    this._headers = headers;
     this._tokenHandler = tokenHandler;
-    this._cacheKeyPrefix = cacheKeyPrefix ?? '';
-    this._minHttpRetryDelayMs = minHttpRetryDelayMs ?? DEFAULT_MIN_HTTP_RETRY_DELAY_MS;
+    this._cacheKeyPrefix = cacheKeyPrefix;
+    this._minHttpRetryDelayMs = minHttpRetryDelayMs;
   }
 
   public async tryGetCacheEntryBufferByIdAsync(

rush-plugins/rush-serve-plugin/src/RushServePlugin.ts

@@ -61,11 +61,16 @@ export class RushServePlugin implements IRushPlugin {
   private readonly _buildStatusWebSocketPath: string | undefined;
 
   public constructor(options: IRushServePluginOptions) {
-    const { phasedCommands, portParameterLongName, globalRouting, logServePath, buildStatusWebSocketPath } =
-      options;
+    const {
+      phasedCommands,
+      portParameterLongName,
+      globalRouting = [],
+      logServePath,
+      buildStatusWebSocketPath
+    } = options;
     this._phasedCommands = new Set(phasedCommands);
     this._portParameterLongName = portParameterLongName;
-    this._globalRoutingRules = globalRouting ?? [];
+    this._globalRoutingRules = globalRouting;
     this._logServePath = logServePath;
     this._buildStatusWebSocketPath = buildStatusWebSocketPath;
   }